From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJ1mHP304mAkWAAAgWs5BA (envelope-from ) for ; Mon, 05 Jul 2021 14:03:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AGQGGP304mB4RwAA1q6Kng (envelope-from ) for ; Mon, 05 Jul 2021 12:03:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3AFB7E34A for ; Mon, 5 Jul 2021 14:03:09 +0200 (CEST) Received: from localhost ([::1]:43378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0NJc-0007xj-8D for larch@yhetil.org; Mon, 05 Jul 2021 08:03:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0NJW-0007us-4i for guix-patches@gnu.org; Mon, 05 Jul 2021 08:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0NJV-0002Ch-Rb for guix-patches@gnu.org; Mon, 05 Jul 2021 08:03:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0NJV-0008AD-O8 for guix-patches@gnu.org; Mon, 05 Jul 2021 08:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49238] [PATCH v3 2/2] gnu: Add ytfzf. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Jul 2021 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49238 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 49238@debbugs.gnu.org Cc: jgart Received: via spool by 49238-submit@debbugs.gnu.org id=B49238.162548654730355 (code B ref 49238); Mon, 05 Jul 2021 12:03:01 +0000 Received: (at 49238) by debbugs.gnu.org; 5 Jul 2021 12:02:27 +0000 Received: from localhost ([127.0.0.1]:44321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0NIw-0007tJ-Qq for submit@debbugs.gnu.org; Mon, 05 Jul 2021 08:02:27 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:39510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0NIt-0007pw-Sz for 49238@debbugs.gnu.org; Mon, 05 Jul 2021 08:02:25 -0400 Received: from butterfly.local ([188.189.37.160]) by andre.telenet-ops.be with bizsmtp id RQ2M250063TK16401Q2M7h; Mon, 05 Jul 2021 14:02:22 +0200 Message-ID: <43898301886a211ed76e3bdea47203ca5dcf9625.camel@telenet.be> From: Maxime Devos Date: Mon, 05 Jul 2021 14:02:20 +0200 In-Reply-To: <20210705111425.14479-2-rg@raghavgururajan.name> References: <20210705111425.14479-1-rg@raghavgururajan.name> <20210705111425.14479-2-rg@raghavgururajan.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-FjbmS081+JGOdI/a2ze5" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625486542; bh=9YWG+EkxnYX4mC80dONLM7li7J8yKTV7ocBsv+eumJM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=NLyOtUaP5f0qQsctFnnU1z0IOTc7Mw+7NJxQfI+ZzLWMuPOLI0jBW2dBO+yeO5P73 QSVxppuLvvMKisqt1H7vqMPOq4Hcb7FZx+TVPI/ZWWElNj3Vgt515A8ALx0eEBXEPl F04qbjd61t+owLjDea9AX6k2gDzGg2fMJbEA0MlPOQzAb/olATlXESkwX45dnlodAS xZpBRY8xYeBuWDvvg5wcvEvcdBWRj7B1Q+KR7KAyoNIucTyAgMGKCWZV1Zx3U5GyBp n+jX3xljlbcxYNfoA08aWDCS/608QeKdxxjcLeGokYC2Jq+WW9UPUjESPcljdbqJcg LMNBoSJmdZsxw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 3AFB7E34A X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: dWCNPrlfnN1A --=-FjbmS081+JGOdI/a2ze5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, > + (modify-phases %standard-phases > + (add-after 'unpack 'patch > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (binutils (assoc-ref inputs "binutils")) The 'binutils' input doesn't seem to be used anywhere. > + if [ -n "$sub_list" ]; then > +- [ -n "$selected_sub" ] || selected_sub=3D$(printf "$sub_li= st" | eval "$menu_command") && youtube-dl --sub-lang $selected_sub --wri= te-auto-sub --skip-download "$selected_urls" -o /tmp/ytfzf && YTFZF_SUBT_NA= ME=3D"--sub-file=3D/tmp/ytfzf.$selected_sub.vtt" || printf "Auto generated = subs not available." > ++ [ -n "$selected_sub" ] || selected_sub=3D$(printf "$sub_li= st" | eval "$menu_command") && @youtube-dl@ --sub-lang $selected_sub --w= rite-auto-sub --skip-download "$selected_urls" -o /tmp/ytfzf && YTFZF_SUBT_= NAME=3D"--sub-file=3D/tmp/ytfzf.$selected_sub.vtt" || printf "Auto generate= d subs not available." For a previous version of this patch series, I noted that writing /tmp/ytfzf is quite possibly insecure, and also incorrect on multi-user systems. I don't see this addressed anywhere. Greetings, Maxime. --=-FjbmS081+JGOdI/a2ze5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYOL0zBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tiHAQDZpO/ZidvfIpGONMjr+7C/3hPA WXu1KOvgSOM+0yOq7AD5AUdYpbPtq1lk0Xo7SPjYhJW2aJvRJWQVpjNZZ30TGQk= =iy0Q -----END PGP SIGNATURE----- --=-FjbmS081+JGOdI/a2ze5--