unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Aleksej via Guix-patches via <guix-patches@gnu.org>
To: 72621@debbugs.gnu.org
Subject: [bug#72621] [PATCH] gnu: Add clasp.
Date: Thu, 15 Aug 2024 14:12:58 +0300	[thread overview]
Message-ID: <434b0060-b39e-4704-861f-a8628ee1993c@disroot.org> (raw)
In-Reply-To: <e3e60078b0b434dfe097c0f27309889a5951e5a5.1723639578.git.ashish.is@lostca.se>

Hi! I've applied your patch, and it seems to have some problems.

1) We already have the package with name "clasp", consider renaming it 
to something like "clasp-cl".

2) The license of clasp should be "lgpl2.1+", not "lgpl2.1".

3) After renaming run "guix lint" on the package, it has quite a lot of 
warnings.

4) I see you use gnu-build-system, and modify it a lot to use ninja. We 
have meson-build-system in GNU Guix, shouldn't it be used instead?

Also I've looked at clasp git repo, they have package definition for GNU 
Guix, maybe you should check it out!

-- 
Best regards,
Lesik Edelweiss





  reply	other threads:[~2024-08-15 12:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 12:46 [bug#72621] [PATCH] gnu: Add clasp ashish.is--- via Guix-patches via
2024-08-15 11:12 ` Aleksej via Guix-patches via [this message]
2024-08-15 12:29 ` bug#72621: " Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434b0060-b39e-4704-861f-a8628ee1993c@disroot.org \
    --to=guix-patches@gnu.org \
    --cc=72621@debbugs.gnu.org \
    --cc=lesikedelweiss@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).