From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52619) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSPH-0006oJ-Sj for guix-patches@gnu.org; Fri, 18 Oct 2019 09:35:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLSPG-00073n-Hf for guix-patches@gnu.org; Fri, 18 Oct 2019 09:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40757) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLSPG-00073c-7I for guix-patches@gnu.org; Fri, 18 Oct 2019 09:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLSPG-0006FV-2T for guix-patches@gnu.org; Fri, 18 Oct 2019 09:35:02 -0400 Subject: [bug#37738] [PATCH] gnu: add lxqt-connman-applet Resent-Message-ID: From: "Reza Alizadeh Majd" Message-Id: <433034AB-FB22-4FD9-8579-9EC1EB0F67F0@pantherx.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_34610DC4-C0EB-4833-88C5-16E0DAC0A8B3" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\)) Date: Fri, 18 Oct 2019 17:04:24 +0330 In-Reply-To: <878spi5qvq.fsf@gnu.org> References: <5f405186-9136-4470-b5d8-5ad35743139a@www.fastmail.com> <878spi5qvq.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37738@debbugs.gnu.org --Apple-Mail=_34610DC4-C0EB-4833-88C5-16E0DAC0A8B3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Ludo,=20 > Nice. A few comments/questions: >=20 >> +(define-public lxqt-connman-applet >> + (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e") >> + (revision "0")) >=20 > Why did you choose this specific commit? >=20 > Normally we only package upstream releases (tags); we resort to = commits > in between releases only when there=E2=80=99s a good reason to do = that, and in > that cases it=E2=80=99s better to add a comment explaining why we did = that. since the package developers didn=E2=80=99t release a specific version = so I=20 decided to choose their latest commit in `master` branch. besides that=20= I had tested the applet on LXQt desktop and it works without issues.=20 >> + (arguments >> + `(#:tests? #f >=20 > Could you add a comment explaining why tests are disabled? OK, sure, I will submit updated patch ASAP.=20 >> + (home-page "https://github.com/lxqt/lxqt-connman-applet") >> + (synopsis "System-tray applet for connman") >> + (description "LXQt based system-tray applet for connman") >=20 > Please write a full description: >=20 > = https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html unfortunately the original developers didn=E2=80=99t provide any further=20= details about this package yet. so is it OK to write a description=20 about this package by myself?=20 Regards, Reza --Apple-Mail=_34610DC4-C0EB-4833-88C5-16E0DAC0A8B3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hi Ludo, 


Nice.  A few comments/questions:

+(define-public lxqt-connman-applet
+  (let ((commit = "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
+        (revision "0"))

Why did you choose this specific commit?

Normally we only package upstream releases (tags); we resort = to commits
in between releases only = when there=E2=80=99s a good reason to do that, and in
that cases it=E2=80=99s better to add a = comment explaining why we did that.

since the package = developers didn=E2=80=99t release a specific version so = I 
decided to choose their latest commit in = `master` branch. besides that 
I had tested = the applet on LXQt desktop and it works without = issues. 


+      (arguments
+        `(#:tests? #f

Could you add a comment explaining why tests are disabled?

OK, sure, I will submit updated patch ASAP. 


+   =    (home-page "https://github.com/lxqt/lxqt-connman-applet")
+      (synopsis = "System-tray applet for connman")
+ =      (description "LXQt based system-tray applet for = connman")

Please write a full description:

 https://guix.gnu.org/manual/en/html_node/Synopses-and-Descripti= ons.html

unfortunately the original developers = didn=E2=80=99t provide any further 
details = about this package yet. so is it OK to write a = description 
about this package by = myself? 



Regards,
Reza

= --Apple-Mail=_34610DC4-C0EB-4833-88C5-16E0DAC0A8B3--