From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uEFuAWcRZmFwBQEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 00:51:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cNrCOGYRZmELfwAAbx9fmQ (envelope-from ) for ; Tue, 12 Oct 2021 22:51:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5530C13F1D for ; Wed, 13 Oct 2021 00:51:18 +0200 (CEST) Received: from localhost ([::1]:34444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maQc9-0007sT-Bs for larch@yhetil.org; Tue, 12 Oct 2021 18:51:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maQbw-0007jz-D4 for guix-patches@gnu.org; Tue, 12 Oct 2021 18:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maQbu-0006L9-Q2 for guix-patches@gnu.org; Tue, 12 Oct 2021 18:51:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maQbt-0005y5-TJ for guix-patches@gnu.org; Tue, 12 Oct 2021 18:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51085] [PATCH v2 6/7] gnu: Add mp3guessenc. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Oct 2021 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51085 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 51085@debbugs.gnu.org Received: via spool by 51085-submit@debbugs.gnu.org id=B51085.163407901022857 (code B ref 51085); Tue, 12 Oct 2021 22:51:01 +0000 Received: (at 51085) by debbugs.gnu.org; 12 Oct 2021 22:50:10 +0000 Received: from localhost ([127.0.0.1]:55503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maQb4-0005wa-HI for submit@debbugs.gnu.org; Tue, 12 Oct 2021 18:50:10 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maQb0-0005vm-F4 for 51085@debbugs.gnu.org; Tue, 12 Oct 2021 18:50:09 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DFECB240101 for <51085@debbugs.gnu.org>; Wed, 13 Oct 2021 00:49:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634078999; bh=FArtPEqMVLZflj3I3G/C6PHCoVF2EFN4kmOTxMHKq1c=; h=Subject:From:To:Cc:Date:From; b=cHWAOHUSkzzpmQ+fgfLYkEUTy8ro59rmA1Y7uQ8DGGAbIlbVd0AIGvr5VC/EngsKt Vpc0hGR4LY18kS9o+K7ZMG3V20QYecU7et3RatQO1C10D3DNaItTdE+kTHjHbJVfF8 okZJh9wn7B18jpE6r3a61YPt4O4Z8XFUksURNKWeXNghSkSdx8a+mdTdMCMhsv6lc9 6n7WF7q5ZMnup1vu0L4wWdtGoEgPYYN4855LcpI93tHO/TTKLWVzeYR8sO+WtG4Mi1 1OTgAiKUOQLcZNUiRYcHGf7vqvigTm2V5z8o+WJv5C6eI/1+KxF+vY23QAyCS6Bi/M vIIzufOljDz0g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HTW85606Pz9rxL; Wed, 13 Oct 2021 00:49:57 +0200 (CEST) Message-ID: <41e830ae7c79d1dd72a579528a8d3f8732913c31.camel@posteo.net> From: Vinicius Monego Date: Tue, 12 Oct 2021 22:49:47 +0000 In-Reply-To: References: <20211009152820.294764-1-monego@posteo.net> <20211009152820.294764-6-monego@posteo.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634079078; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=grzQlgGHQEIRFrvr1ZSLISpZPY6RzMqV48S/pHbpKcQ=; b=urP8OLPGci1CgnM22CqqLnqZjcgS6r8L95vJJjNe6ShiSDLJSAVBfb0CayapkLThCA0BMS EntSe+cCokqRy+Uz1YlbYYJmxzAtP8mIQbS34J+IPFc8cFzgdIs8xIN2vi+b9UAxKLy0he 1llmzpe+BRmdT4wMqPa7UKYp1S5ImEEmMzEjKq5BqQ8hm1/0gVmw/CGGv2KFhAQxxbsfbS aEqOSIpQhY181ZWL1+XZQRLZoKAlx76i7utpowm9oeDj3dSha4JZ4bhTJxeyAbr2aBJrms Q2RJZB4HEdu24DNbulV5ZXqhfBKAVKpL8fVR+peQYN6TrYtNTW1OqzT/tHMH9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634079078; a=rsa-sha256; cv=none; b=rfCS0nui/Sl3JNlp/LPZB8uvmXPJt+adcM877CncnERiXUIbNOLsBC+YZMXVdeSndeWgDP 7H/yEBfZjjlrjNZQZsswqXvh1q5pJS1aXgMxExQT4b5NT+A4QvI0z8Uvo3W1Yy/4B5KIRP AyBYY6MQyOOHG00UX1e71hSJGnc4OaGVKR8tPyfc/AxsVO+n0mFOYv2aNJpetDG8qj1DQm CwZFyAHI7VbqsDmrnntf3ugXdckKSF6GE05bSe2mp4dyL14vHWxGFcoCKRI/KPE/g3WzbU AL3hEUdkjRNWCl4NShZy119I1QuJ7dScLTLIgBTurAhySsthrKyp557L1skVwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=cHWAOHUS; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=cHWAOHUS; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5530C13F1D X-Spam-Score: 0.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1rJoy4y4o7Mb Em seg, 2021-10-11 às 17:55 -0400, Leo Famulari escreveu: > Thanks for these patches! I've hoped for a Mixxx Guix package for a > long > time. > > The patches look good to me overall, but I have a couple questions: > > On Sat, Oct 09, 2021 at 03:28:19PM +0000, Vinicius Monego wrote: > > * gnu/packages/audio.scm (mp3guessenc): New variable. > > > +       (list (string-append "PREFIX=" (assoc-ref %outputs "out")) > > +             (string-append "SUFFIX=")) > > What is SUFFIX? That string doesn't appear in the mp3guessenc source > code. Oh I copied that part from another package and didn't adjust. SUFFIX can be removed.