From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id s8m5HrWFfGDOcAEAgWs5BA (envelope-from ) for ; Sun, 18 Apr 2021 21:17:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4LdiGbWFfGAPEAAA1q6Kng (envelope-from ) for ; Sun, 18 Apr 2021 19:17:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0657C1A3A7 for ; Sun, 18 Apr 2021 21:17:09 +0200 (CEST) Received: from localhost ([::1]:56628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYCup-0000HT-Mw for larch@yhetil.org; Sun, 18 Apr 2021 15:17:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCuk-0000Fp-FA for guix-patches@gnu.org; Sun, 18 Apr 2021 15:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYCuk-0004tr-7K for guix-patches@gnu.org; Sun, 18 Apr 2021 15:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYCuk-00018L-0w for guix-patches@gnu.org; Sun, 18 Apr 2021 15:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47104] grumble status update Resent-From: "jgart" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Apr 2021 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47104 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Leo Prikler" , 47104@debbugs.gnu.org Cc: raghavgururajan@disroot.org, rprior@protonmail.com, Raghav Gururajan Received: via spool by 47104-submit@debbugs.gnu.org id=B47104.16187734104333 (code B ref 47104); Sun, 18 Apr 2021 19:17:01 +0000 Received: (at 47104) by debbugs.gnu.org; 18 Apr 2021 19:16:50 +0000 Received: from localhost ([127.0.0.1]:47851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCuX-00017o-Ne for submit@debbugs.gnu.org; Sun, 18 Apr 2021 15:16:50 -0400 Received: from mx1.dismail.de ([78.46.223.134]:38745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCuS-00017T-Ql for 47104@debbugs.gnu.org; Sun, 18 Apr 2021 15:16:48 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id bda1b709; Sun, 18 Apr 2021 21:16:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:content-transfer-encoding:from :message-id:subject:to:cc:in-reply-to:references; s=20190914; bh=yePI/oERMh7LmpVhZpTXTHhCWkcCNx6sLzgX56r0y5w=; b=AAT3j/LgS5MO NF+Iuf0xCYZ7iiHqtnl4apiQFY023d4Ako+BdaCAdDd9TwtGZkZZcTSF8WStQTnZ RfQsE6XGGFKCtvFaONSLMS/WbY9yjJHjFVtmn1VnX8Lx0RsWW1zg4p+tSPZrUWIZ whXCcjuOueHyQbgy5GY6fmwR0+RsOsifjotwD5+uwFwgaasZx7O+dFU6sdzckPIo dMTv0PDe7l3ml8EU08YyJOW5YV82tffXlQHDJZM9rb/4FrWyOCODuDK8jLSFqWOh 0sDPA8z8EjiikzIZ8HjF8xsk79RR/k9r/2Jv42e7Wi3OQSU4OgK1lGbxRjLopLji A6w8SOcNbw== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 3c39e97f; Sun, 18 Apr 2021 21:16:37 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 2334cee8; Sun, 18 Apr 2021 21:16:37 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 201c090b (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 18 Apr 2021 21:16:36 +0200 (CEST) MIME-Version: 1.0 Date: Sun, 18 Apr 2021 19:16:35 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: RainLoop/1.14.0a Message-ID: <4164d47d2927aa352d2c7c9c15e9bda4@dismail.de> In-Reply-To: References: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618773429; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yePI/oERMh7LmpVhZpTXTHhCWkcCNx6sLzgX56r0y5w=; b=eKKvpxYAi9ibYdabRm03eF+mygs6HuearkLfiJd99wBQVyClfjhRj5UgKuZN2WBx8cNrFT 3fihxcJ1bRGGhY7LHcaDUSkKe3R9dYUMy1tZbL0HeDHkbG/pxAhHETzzKKSvIrlordOT/K anHnbNGxUuKsauC9LMbdyrZc3Rrkh+dzkwxrfP5UgcCY5br8EV6npuUpi9Dri7YY34V1W9 ORQ3bxt45QQ0p/twbrTeURfDR7st32fEqLn6gZZx30xK+3H45jdHzQTSA8tO8fs4tPjUQ3 24shrEbzw9Eca1JopqzdAgjixvU45owTdHxiXQG5fUWBr0RutdE6upXeGJYAiA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618773429; a=rsa-sha256; cv=none; b=MAkvgEcPis4ihpv3Ipq84TmRO285uGZxAdL2sOu8Pbb/lxRydFkLamV+6NUxqtiQSYDAgq 0MV7wUz8Yym4jMQNGrz7iLoOoi43V7cdUj+rsVzp2U+s/GwY4YEDaFq0BL1MqAF/3Lydli fYYwyrI+0hpzgEjzeY6W26H+Li5aWWfu7gq4SACE74LSNusZ0ZFNs0lCy9SVPJ/m+xBFT/ yNSckbRKHyGoyPlrhoMPh3qfwW9QocS1c9yJh76gmHUWlGyUf57SYdFuOtyrvNhohx9eGH ERTREy1F+Nz0zUOPXUjOTxDyFLX2uQbgEYTOURB7uktC3Y4twk/ZrqiFZD4cmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="AAT3j/Lg"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="AAT3j/Lg"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0657C1A3A7 X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: oCrm+aS5McQv > It is not so much me insisting rather than me thinking, that channels= =0A> fit such "niche" uses better. As far as I can tell, Guix tries to ma= ke=0A> system services as secure as possible and having a service with gl= aring=0A> security flaws is not really a good fit in that scenario. See a= lso the=0A> recent removal of mongodb.=0A=0AI also agree that this will b= e a good use case for a guix channel. Thanks for the advice on that.=0A= =0AWe'll move grumble and wahay (tbd) to our channel for community testin= g and experimentation. =0A=0A> While the package description itself LGTM,= the patch inadvertently=0A> version bumps some Go protobuf package. If i= t's okay with you and=0A> Ryan, I think the better solution would be to s= end a clean patch along=0A> with hugo or perhaps separately.=0A=0AI'll re= send a patch for go-github-com-gorilla-websocket soon. =0A=0AHugo might b= e a while. It's a beast of a package:=0A=0Ahttps://github.com/ryanprior/g= uix-packages/blob/master/testing/hugo.scm=0Ahttps://github.com/ryanprior/= guix-packages/blob/master/testing/new-hugo-deps.org=0A=0AIt definitely do= esn't resemble the one in nixpkgs :)=0A=0Ahttps://github.com/NixOS/nixpkg= s/blob/nixos-unstable/pkgs/applications/misc/hugo/default.nix#L36=0A=0ATh= ank you for taking the time to review our patches.=0A=0Aall the best,=0A= =0Ajgart=0A=0AApril 18, 2021 2:32 PM, "Leo Prikler" wrote:=0A=0A> Hi jgart,=0A> =0A> Am Sonntag, den 18.04.2021, 1= 7:25 +0000 schrieb jgart:=0A> =0A>> Hi Leo,=0A>> =0A>> I know you mean th= is somewhat jokingly, but is there anything=0A>> (apart=0A>> maybe from t= he name of the binary), that would keep you from=0A>> reusing=0A>> murmur= -service-type?=0A>> =0A>> See here:=0A>> =0A>> https://github.com/mumble-= voip/grumble/issues/21=0A>> https://github.com/mumble-voip/grumble/pull/2= 6=0A>> =0A>> There are more sources related to the grumble config that's = currently=0A>> implemented that I can't locate at the moment.=0A>> =0A>> = I remember reading that they didn't necessarily want to maintain=0A>> fea= ture parity with the grumble config format.=0A> =0A> That's=E2=80=A6 disa= ppointing.=0A> =0A>> 1. Is this package in its current state usable?=0A>>= =0A>> I would say yes. We packaged grumble while talking over grumble. I= t=0A>> feels pretty solid.=0A>> =0A>> Grumble also has an active fork as = a library and being used by wahay:=0A>> https://wahay.org=0A>> =0A>> It i= s currently 16 commits ahead of upstream:=0A>> =0A>> https://github.com/d= igitalautonomy/grumble=0A> =0A> This doesn't really look active to me eit= her. It appears as though=0A> they diverged at some point and simultaneou= sly came to a halt. Now=0A> wahay is still active, but that's a different= beast.=0A> =0A>> 2. Is it still maintained upstream? It is a little stre= tch to say=0A>> Grumble is undergoing active development after a year of = no=0A>> activity.=0A>> =0A>> It sounds like the project maintainers of th= e upstream grumble=0A>> project are very slow to review pull requests. It= sounds like they=0A>> are too busy with other projects/work.=0A>> =0A>> = See the complaint here by one of the contributors that chimed in when=0A>= > I opened an issue:=0A>> =0A>> https://github.com/mumble-voip/grumble/is= sues/76=0A> =0A> I take that as a "Maybe, but actually no".=0A> =0A>> 3. = https://github.com/mumble-voip/grumble#project-statuslists quite=0A>> a= =0A>> few features that are lacking, but does it maybe contain features,= =0A>> that=0A>> would make it worth packaging?=0A>> =0A>> See https://git= hub.com/mumble-voip/grumble/issues/76=0A>> =0A>> "... Grumble has the dis= tinguishing feature of native support for=0A>> Websockets (because I was = a lot worse at C++ back then and so I=0A>> contributed a patch here inste= ad), and Murmur will probably not have=0A>> that for the foreseeable futu= re. You could of course just configure a=0A>> proxy in front of Murmur if= you need this. A lot of the plans for=0A>> work we were making a few yea= rs ago pointed towards Grumble being=0A>> more focused on ease-of-use and= these small workloads I talked about=0A>> above. It makes sense: the Mur= mur static binary has issues and so a=0A>> Grumble static (just how Go wo= rks) binary that you can download and=0A>> run, trivially configure and e= asily negotiate certs over LE=0A>> (unfortunately never happened due to L= E issues, but it would be=0A>> viable now), accessible over the Web could= fulfil a sort of=0A>> "batteries-included" user-friendly niche."=0A> =0A= > W.r.t. ease-of-use I don't think it should be too difficult to get=0A> = murmur + certbot working in Guix. All I can recall from the Debian=0A> (y= eah, I know) server, that I currently run murmur on, is that you need=0A>= to get your hook for restarting murmur right.=0A> =0A>> If the answer is= "no" to any of the above, I'm not too sure whether=0A>> it=0A>> would be= wise to have this in Guix upstream. If LibreMiami wanted=0A>> to=0A>> ho= st grumble instances on Guix regardless, perhaps a channel might=0A>> be = a=0A>> better fit?=0A>> =0A>> We can put this in a LibreMiami channel wit= h a service for it if you=0A>> insist it not be included in upstream guix= .=0A> =0A> It is not so much me insisting rather than me thinking, that c= hannels=0A> fit such "niche" uses better. As far as I can tell, Guix trie= s to make=0A> system services as secure as possible and having a service = with glaring=0A> security flaws is not really a good fit in that scenario= . See also the=0A> recent removal of mongodb.=0A> =0A>> If upstream grumb= le picks up development then I can send a patch=0A>> again for review.=0A= > =0A> Please do so.=0A> =0A>> That said, can you take the patch for go-g= ithub-com-gorilla-=0A>> websocket?=0A>> =0A>> We will need go-github-com-= gorilla-websocket for many other packages=0A>> that we're working on. One= of them being the hugo static site=0A>> generator that we're working on = with Ryan Prior.=0A> =0A> While the package description itself LGTM, the = patch inadvertently=0A> version bumps some Go protobuf package. If it's o= kay with you and=0A> Ryan, I think the better solution would be to send a= clean patch along=0A> with hugo or perhaps separately.=0A> =0A>> Related= ly, we're planning on packaging wahay (https://wahay.org).=0A>> =0A>> wah= ay depends on the fork of grumble that I linked above.=0A>> =0A>> Should = we package only the fork of grumble in that case and not=0A>> upstream gr= umble?=0A> =0A> Again, since wahay has no public release and LibreMiami m= ight want to=0A> tail upstream, I think that this would be a better fit o= utside of Guix.=0A> As for the differences in their versions of grumble, = I honestly don't=0A> know what to do. Guix usually tries not to vendor pa= ckages and this=0A> might mean using upstream grumble for wahay, but the = grumble fork might=0A> also implement features, that are necessary for wa= hay.=0A> =0A> This is just my personal opinion, but right now Guix seems = to have=0A> about 70 "no release" comments, some of which are actually "n= o release=0A> since". I don't think there's a reason to bump this number = unless the=0A> developer has a good reason not to assign version numbers = (other than=0A> "it's not ready yet", which is a perfect reason not to as= sign version=0A> numbers, but also a perfect reason to refrain from packa= ging it), which=0A> does not seem to hold here.=0A> =0A> Regards,=0A> Leo