From: "Jovany Leandro G.C" <bit4bit@riseup.net>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 36804-done@debbugs.gnu.org
Subject: [bug#36804] [PATCH] gnu: Add xchm.
Date: Thu, 25 Jul 2019 08:05:57 -0700 [thread overview]
Message-ID: <4155934b43d0cbd851f62b889e8fe673@riseup.net> (raw)
In-Reply-To: <87ftmua86v.fsf@elephly.net>
On 2019-07-25 07:23, Ricardo Wurmus wrote:
> Hi,
>
> thank you for your patch.
>
>> * gnu/packages/ebook.scm (xchm): New variable.
>> ---
>> gnu/packages/ebook.scm | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
>> index cf424f285d..7c919710d4 100644
>> --- a/gnu/packages/ebook.scm
>> +++ b/gnu/packages/ebook.scm
>> @@ -330,3 +330,31 @@ following formats:
>> @item XHTML
>> @end enumerate")
>> (license license:gpl2+)))
>> +
>> +(define-public xchm
>> + (package
>> + (name "xchm")
>> + (version "1.30")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append "https://github.com/rzvncj/xCHM/archive/"
>> + version ".tar.gz"))
>> + (file-name (string-append name "-" version ".tar.gz"))
>
> The project provides a bootstrapped tarball. We avoid the “/archive”
> URLs on Github as they may change over time.
>
>> + (sha256
>> + (base32
>> + "13733g2bz84a15z08qwhrdcn0ff6g9c0aabdn0kzvx0nanj9vra9"))))
>> + (build-system gnu-build-system)
>> + (inputs
>> + `(("wxwidgets" ,wxwidgets)
>> + ("chmlib" ,chmlib)))
>> + (native-inputs
>> + `(("pkg-config" ,pkg-config)
>> + ("autoconf" ,autoconf)
>> + ("automake" ,automake)
>> + ("libtool" ,libtool)
>> + ("gettext" ,gettext-minimal)))
>
> When using the bootstrapped tarball most of these inputs are not needed.
>
>> + (home-page "https://github.com/rzvncj/xCHM")
>> + (synopsis "UNIX CHM Viewer")
>> + (description "xCHM is a cross-platform GPL frontend for CHMLIB written
>> +with the wxWidgets framework.")
>
> I have changed both synopsis and description. We don’t usually mention
> UNIX, nor do we repeat the license or the inputs in the description.
>
> You missed the import of (gnu packages wxwidgets), which makes me think
> that you haven’t tried building this patch.
>
> I have pushed this to the master branch with commit 7c0411879b after
> including my changes.
>
> Thanks!
>
> --
> Ricardo
thanks for your time, sorry i already build with rounds=2, but i have
the source
[https://efossils.somxslibres.net/fossil/user/bit4bit/repository/guix_packages/index]
in other place when i sure it's build and i use for a time i merge the
patch to guix-dev, i miss the import sorry.
si 'guix lint' show about tarball but i was not sure what to do
thanks
Fossil: https://efossils.somxslibres.net
E-Sitio: https://www.somxslibres.net
prev parent reply other threads:[~2019-07-25 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 1:35 [bug#36804] [PATCH] gnu: Add xchm Jovany Leandro G.C
2019-07-25 7:23 ` bug#36804: " Ricardo Wurmus
2019-07-25 15:05 ` Jovany Leandro G.C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4155934b43d0cbd851f62b889e8fe673@riseup.net \
--to=bit4bit@riseup.net \
--cc=36804-done@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).