From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dF1Df-0000Si-U1 for guix-patches@gnu.org; Sun, 28 May 2017 12:39:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dF1Da-0001I1-VC for guix-patches@gnu.org; Sun, 28 May 2017 12:39:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dF1Da-0001Hx-M9 for guix-patches@gnu.org; Sun, 28 May 2017 12:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dF1Da-0000ZS-Dt for guix-patches@gnu.org; Sun, 28 May 2017 12:39:02 -0400 Subject: bug#27107: [PATCH] gnu: font-comic-neue: Add fontconfig alias. Resent-Message-ID: Message-Id: <40fbd535.ADsAAg_HJlQAAAAAAAAAAAPFkxoAAAACwQwAAAAAAAW9WABZKv0R@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Sun, 28 May 2017 22:08:27 +0530 In-reply-to: <1495911253.2824873.990503296.5E43EB91@webmail.messagingengine.com> References: <1495911253.2824873.990503296.5E43EB91@webmail.messagingengine.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Griffin Cc: 27107@debbugs.gnu.org Thanks for the patch! Could you rewrite the patch with the new font-build-system? That would make the patch much shorter. Look at font-dejavu for an example. I noticed that the source zip archive for font-comic-neue doesn't have a top level directory. This might cause problems. If so, you'll have to replace the 'unpack phase as well. Finally, we should have two patches -- the first patch to re-indent and switch to the new font-build-system, the second patch to add the fontconfig alias. =