unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Alex Griffin <a@ajgrf.com>
Cc: 27107@debbugs.gnu.org
Subject: bug#27107: [PATCH] gnu: font-comic-neue: Add fontconfig alias.
Date: Sun, 28 May 2017 22:08:27 +0530	[thread overview]
Message-ID: <40fbd535.ADsAAg_HJlQAAAAAAAAAAAPFkxoAAAACwQwAAAAAAAW9WABZKv0R@mailjet.com> (raw)
In-Reply-To: <1495911253.2824873.990503296.5E43EB91@webmail.messagingengine.com>


Thanks for the patch!

Could you rewrite the patch with the new font-build-system? That would
make the patch much shorter. Look at font-dejavu for an example. I
noticed that the source zip archive for font-comic-neue doesn't have a
top level directory. This might cause problems. If so, you'll have to
replace the 'unpack phase as well.

Finally, we should have two patches -- the first patch to re-indent and
switch to the new font-build-system, the second patch to add the
fontconfig alias.

  reply	other threads:[~2017-05-28 16:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27 18:54 bug#27107: [PATCH] gnu: font-comic-neue: Add fontconfig alias Alex Griffin
2017-05-28 16:38 ` Arun Isaac [this message]
     [not found] ` <971c125f.ADsAAg_HJlUAAAAAAAAAAAPFkxsAAAACwQwAAAAAAAW9WABZKv0R@mailjet.com>
2017-05-31 17:01   ` Alex Griffin
2017-06-01 13:50     ` Arun Isaac
     [not found]     ` <c757126b.AEEALPlfx1UAAAAAAAAAAAPFkxsAAAACwQwAAAAAAAW9WABZMBvE@mailjet.com>
2017-06-01 14:03       ` Alex Griffin
2017-06-01 15:12         ` Arun Isaac
     [not found]         ` <ed110519.AEUAKvsBN2MAAAAAAAAAAAPFkxsAAAACwQwAAAAAAAW9WABZMC7e@mailjet.com>
2017-06-01 15:34           ` Alex Griffin
2017-06-01 15:48             ` Alex Griffin
2017-06-01 16:01               ` Arun Isaac
2017-06-01 16:50               ` Arun Isaac
     [not found]               ` <59879525.AEMAK8sFRAAAAAAAAAAAAAPFkxsAAAACwQwAAAAAAAW9WABZMEXM@mailjet.com>
2017-06-01 18:11                 ` Alex Griffin
2017-06-01 18:46                   ` Arun Isaac
2017-05-31 19:56 ` Alex Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40fbd535.ADsAAg_HJlQAAAAAAAAAAAPFkxoAAAACwQwAAAAAAAW9WABZKv0R@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=27107@debbugs.gnu.org \
    --cc=a@ajgrf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).