unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Herman Rimm via Guix-patches via <guix-patches@gnu.org>
To: 68524@debbugs.gnu.org
Cc: Lilah Tascheter <lilah@lunabee.space>
Subject: [bug#68524] [PATCH v3 4/5] gnu: system: Fix bootloader crypto device recognition.
Date: Wed, 25 Sep 2024 13:12:02 +0200	[thread overview]
Message-ID: <40e4b478889cb61296f9559591e1c7affa540ad8.1727262600.git.herman@rimm.ee> (raw)
In-Reply-To: <cover.1727262600.git.herman@rimm.ee>

From: Lilah Tascheter <lilah@lunabee.space>

* gnu/system.scm (operating-system-bootloader-crypto-devices): Check for
luks-device-mapping-with-options in addition to luks-device-mapping.

Change-Id: Iafc9afe608640b97083c4d559c9240846330472a
---
 gnu/system.scm | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/gnu/system.scm b/gnu/system.scm
index 85e02a9965..3dde0f4959 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -402,13 +402,16 @@ (define operating-system-bootloader-crypto-devices
   (mlambdaq (os)                        ;to avoid duplicated output
     "Return the sources of the LUKS mapped devices specified by UUID."
     ;; XXX: Device ordering is important, we trust the returned one.
-    (let* ((luks-devices (filter (lambda (m)
-                                   (eq? luks-device-mapping
-                                        (mapped-device-type m)))
-                                 (operating-system-boot-mapped-devices os)))
-           (uuid-crypto-devices non-uuid-crypto-devices
-                                (partition (compose uuid? mapped-device-source)
-                                           luks-devices)))
+    ;; Check against the close-luks-device procedure to get both maptypes.
+    (let* ((close (compose mapped-device-kind-close mapped-device-type))
+           (luks (mapped-device-kind-close luks-device-mapping))
+           (luks? (lambda (m) (eq? (close m) luks)))
+           (os-devices (operating-system-boot-mapped-devices os))
+           (luks-devices (filter luks? os-devices))
+           (uuid? (compose uuid? mapped-device-source))
+           (uuid-crypto-devices
+            non-uuid-crypto-devices
+            (partition uuid? luks-devices)))
       (when (not (null? non-uuid-crypto-devices))
         (for-each (lambda (dev)
                     (warning
-- 
2.45.2





  parent reply	other threads:[~2024-09-25 12:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  4:23 [bug#68524] [PATCH 0/2] Support root encryption and secure boot Lilah Tascheter via Guix-patches
2024-01-17  4:23 ` [bug#68525] [PATCH 1/2] gnu: bootloaders: Add uki packages Lilah Tascheter via Guix-patches
2024-01-17  4:23 ` [bug#68526] [PATCH 2/2] gnu: bootloaders: Add uefi-uki-bootloader Lilah Tascheter via Guix-patches
2024-01-17  4:48 ` [bug#68524] [PATCH 1/2] gnu: bootloaders: Add uki packages Lilah Tascheter via Guix-patches
2024-01-17  4:48   ` [bug#68524] [PATCH 2/2] gnu: bootloaders: Add uefi-uki-bootloader Lilah Tascheter via Guix-patches
2024-01-25 10:03     ` Herman Rimm via Guix-patches via
2024-01-28  0:50       ` Lilah Tascheter via Guix-patches
2024-01-28  9:51 ` [bug#68524] [PATCH v2 0/2] Support root encryption and secure boot Lilah Tascheter via Guix-patches
2024-01-28  9:51   ` [bug#68524] [PATCH v2 1/2] gnu: bootloaders: Add uki packages Lilah Tascheter via Guix-patches
2024-02-11 18:37     ` Hilton Chain via Guix-patches via
2024-01-28  9:51   ` [bug#68524] [PATCH v2 2/2] gnu: bootloaders: Add uefi-uki-bootloader Lilah Tascheter via Guix-patches
2024-02-11 18:39     ` Hilton Chain via Guix-patches via
2024-02-13  2:11       ` Lilah Tascheter via Guix-patches
2024-02-13  7:34         ` Lilah Tascheter via Guix-patches
2024-02-14 18:02           ` Hilton Chain via Guix-patches via
2024-02-11 18:37   ` [bug#68524] [PATCH v2 0/2] Support root encryption and secure boot Hilton Chain via Guix-patches via
2024-02-20  1:08 ` [bug#68524] [PATCH " Nikolaos Chatzikonstantinou
2024-03-08  8:09 ` Lilah Tascheter via Guix-patches
2024-03-08 10:41 ` [bug#68524] Nikolaos Chatzikonstantinou
2024-03-23 19:40 ` [bug#68524] [PATCH 0/2] Support root encryption and secure boot Lilah Tascheter via Guix-patches
2024-03-24  9:38   ` Nikolaos Chatzikonstantinou
2024-07-29  5:11 ` [bug#68524] Fwd: " Ryan S via Guix-patches via
2024-08-15 13:14 ` [bug#68524] Rewrite Posted Lilah Tascheter via Guix-patches
2024-08-15 17:18   ` Nikolaos Chatzikonstantinou
2024-09-25 11:11 ` [bug#68524] [PATCH v3 0/5] Support root encryption and secure boot Herman Rimm via Guix-patches via
2024-09-25 11:11   ` [bug#68524] [PATCH v3 1/5] gnu: packages: Add pesign Herman Rimm via Guix-patches via
2024-09-25 11:12   ` [bug#68524] [PATCH v3 2/5] gnu: packages: Add ukify Herman Rimm via Guix-patches via
2024-09-25 11:12   ` [bug#68524] [PATCH v3 3/5] gnu: packages: Add systemd-stub Herman Rimm via Guix-patches via
2024-09-25 11:12   ` Herman Rimm via Guix-patches via [this message]
2024-09-25 11:12   ` [bug#68524] [PATCH v3 5/5] gnu: bootloaders: Add uki-efi-bootloader Herman Rimm via Guix-patches via
2024-10-18  5:47 ` [bug#68524] One problem with uki bootloader amano.kenji via Guix-patches via
2024-10-21 15:41 ` [bug#68524] Can uki be used with grub? amano.kenji via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40e4b478889cb61296f9559591e1c7affa540ad8.1727262600.git.herman@rimm.ee \
    --to=guix-patches@gnu.org \
    --cc=68524@debbugs.gnu.org \
    --cc=herman@rimm.ee \
    --cc=lilah@lunabee.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).