From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4HdgKas+B2WswwAA9RJhRA:P1 (envelope-from ) for ; Sun, 17 Sep 2023 20:00:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4HdgKas+B2WswwAA9RJhRA (envelope-from ) for ; Sun, 17 Sep 2023 20:00:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E22C369B2 for ; Sun, 17 Sep 2023 20:00:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=planete-kraus.eu header.s=albinoniA header.b="l OpjmYV"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694973611; a=rsa-sha256; cv=none; b=Uw1ZulPUM9DrgxMnMILLdn9fg/AY6KPZxp23jxB1W/2PU2wIpL6NWNg+0uzRgXAF6x0rGd 2kUfvILp1Av/O5VAcsVG6HLC25fvTaR+K5NZf5TdJ/aKJpBOqUiYgJ7NNnh6hVHlkWbiwZ VKM41G4N6HkyCp89sXBL4fBtsagTo8GiM5U9XUYyr2lfDlmegxIHfxYNmnyayOZHhe4hl+ qT4v+qVKF9hOhb+jbmfDOHxDv5mA3O1O4qUyRjJR9epFSNGLxwh6UbmktJ3hMdEZJkB/Ft jNp2BIKZobJxUyaTJwatm85bhDQchg5v77H4DjED7m5oi26nLlIOwFjgSyxolw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694973611; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wtEcxVgu4bRnC1qDeV9ND34FS5+J5kk1b+KFyk6Z9DI=; b=DKZYPlUrcbAssBekoPKBmtBwj4+XwIoRk0zIp2Vx9GzcoFXw4AmIHZbQUxXESEle56w7HS BxwEpJMNxQbvCmd4ToJTl3UUuVINEXyISsxM1IAD4UodGpVylJrcd+6i4h2IRvv7pX3dlV 0J5URmfLq6/8xUGFyym+PcgXjrGhxU72kM+y4g16uja6UhbCozIjo+d09STbjfDYW0Q789 rIfCdvB+1gushgm4OQHQyKXr/YX/fqRC6Pf94Rd+N4WernNJxWk3sUaCP3EA417bzD1Rhu Bc0kXPNiv/BYjQkKET+Kzyl4X1misrAyD8Z3mQc/EKEW2o0dCab8CAI3MOou6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=planete-kraus.eu header.s=albinoniA header.b="l OpjmYV"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhw3p-0005qV-1I; Sun, 17 Sep 2023 13:59:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhw3n-0005ns-In for guix-patches@gnu.org; Sun, 17 Sep 2023 13:59:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhw3n-0007Cn-Ab for guix-patches@gnu.org; Sun, 17 Sep 2023 13:59:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhw3v-0007R4-0t for guix-patches@gnu.org; Sun, 17 Sep 2023 14:00:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66052] [PATCH gnome-team v3] gnu: tracker: Update to 3.6.0. Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 Sep 2023 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66052 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 66052@debbugs.gnu.org Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com Received: via spool by 66052-submit@debbugs.gnu.org id=B66052.169497360228554 (code B ref 66052); Sun, 17 Sep 2023 18:00:02 +0000 Received: (at 66052) by debbugs.gnu.org; 17 Sep 2023 18:00:02 +0000 Received: from localhost ([127.0.0.1]:51390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhw3t-0007QN-9b for submit@debbugs.gnu.org; Sun, 17 Sep 2023 14:00:01 -0400 Received: from planete-kraus.eu ([89.234.140.182]:39910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhw3q-0007QC-9O for 66052@debbugs.gnu.org; Sun, 17 Sep 2023 14:00:00 -0400 Received: from planete-kraus.eu (localhost.lan [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 95df0cb9; Sun, 17 Sep 2023 17:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:in-reply-to:references:from:date:subject:to:cc :mime-version; s=albinoniA; bh=hM8qAgOQctWZQkw1jG8rHzoL040=; b=l OpjmYV13cM2c1DHMr7YdzM/jaZmP3q9bH6la0OMBtwt5nTd2AUEygKbbR81XCR4a BUtHpxNIY9wrP7O4OU40brZ1DjefoSSbc9TA9RikNyfYCnjdLax+YQhVIUr2cIvC NTGCMX6rRVj0LKxFv/aQ2ft7IWrPJdoiSfZzOi+XnIWBL0CEHxvEpg8dlPOFmCNG vZVXSndfI7nCe1Jb2Y9rFG2DfSXu//BgFMHtHUpK6tIN7brTepEyyyEjwa3WCgPC uzJIdILhl1RCwWD+9WDzhwi24lrJDIoLEIiadlKcDBLxHb3gYL2FONvyN++wW6GO uMOLzzeYVKK1JvNzp2+aQ== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id f9004664 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 17 Sep 2023 17:59:47 +0000 (UTC) Message-ID: <409de86ce727f6f09b2e9a063e79848578be5fa9.1694972905.git.vivien@planete-kraus.eu> In-Reply-To: <0235430d802b793ab401ee6ed15b51a587cf38dd.camel@gmail.com> References: <0235430d802b793ab401ee6ed15b51a587cf38dd.camel@gmail.com> Date: Sun, 17 Sep 2023 13:29:18 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.46.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches From: Vivien Kraus via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.70 X-Spam-Score: -1.70 X-Migadu-Queue-Id: 4E22C369B2 X-Migadu-Scanner: mx2.migadu.com X-TUID: fMGqRMy3LXCQ * gnu/packages/gnome.scm (tracker): Update to 3.6.0. [#:phases]: Add 'disable-failing-tests'. --- > > > You can (and probably should) make this into a ‘disable-failing- > > > tests’ or inline it into an existing one. Otherwise LGTM but > > > waiting for CI to test. > > > > This is only for i686, I want to keep all tests for x86_64. So, it’s > > named 'disable-i686-failing-tests'. > > > > I would not hold my breath for CI. Looking at the qa-frontpage > > repository, I suspect the base for all QA builds is always master (it > > invokes "git tag base-for-issue-*" without a specific branch name), > > so it will likely fail. > Fine by me. Not sure whether we'll need to distinguish failing tests > like that in the future or chain multiple ones after another (there is > precedent to putting them all in one phase and we are already > rebuilding tracker, so we might also have a phase that reads > *unspecified* on arches that don't need any fixes, but who am I to > insist on that). Sorry, I’m not sure I understood everything. Is this more what you expected? I’m not sure about the *unspecified* thing. If I drop the "else" leg of the conditional, I get: guix build: error: #: invalid G-expression input Same if I replace the "if" with a "when". So, the phase does not read *unspecified* if no fix is needed, it reads #t instead. gnu/packages/gnome.scm | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 2077478ff2..422d6de28f 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9387,7 +9387,7 @@ (define-public gnome-autoar (define-public tracker (package (name "tracker") - (version "3.5.3") + (version "3.6.0") (source (origin (method url-fetch) (uri (string-append "mirror://gnome/sources/tracker/" @@ -9395,7 +9395,7 @@ (define-public tracker "tracker-" version ".tar.xz")) (sha256 (base32 - "1vi878f95a2nlvqz46ph6f05hywjb2ni0znqavhdkrbvi6qchrhl")))) + "1whdqidxmagsc35pmz9kcc5vs3bmvbkmnis7prnx3zxs37z2qnaj")))) (build-system meson-build-system) (arguments (list @@ -9417,6 +9417,22 @@ (define-public tracker (substitute* "utils/trackertestutils/__main__.py" (("/bin/bash") (search-input-file inputs "bin/bash"))))) + (add-after 'unpack 'disable-failing-tests + (lambda _ + #$(if (target-x86-32?) + ;; On 32-bit systems, the far away dates are incorrect, and + ;; the floats are not parsed exactly. + #~(begin + (substitute* + "tests/libtracker-sparql/tracker-statement-test.c" + (("g_assert_cmpfloat *\\((.*), ==, ([0-9.e-]+)\\);" + total actual expected) + (string-append "g_assert_cmpfloat_with_epsilon (" + actual ", " expected ", 1e-12);"))) + (substitute* "tests/core/tracker-sparql-test.c" + (("\\{ \"datetime/direct-1\", .* \\},") + "/* datetime test disabled */"))) + #~#t))) (add-before 'configure 'set-shell (lambda _ (setenv "SHELL" (which "bash")))) base-commit: e9ff5d51e3297089e66c124195e1f1b42dbded65 -- 2.41.0