unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: 50131@debbugs.gnu.org, Andrew Whatson <whatson@gmail.com>
Subject: [bug#50131] [PATCH 2/3] gnu: Add docbook2x.
Date: Thu, 26 Aug 2021 12:36:45 -0300	[thread overview]
Message-ID: <40771916.5y4UuSq5LN@popigai> (raw)
In-Reply-To: <20210820120907.83191-2-whatson@gmail.com>

Hello Andrew,

Em sexta-feira, 20 de agosto de 2021, às 09:09:06 -03, Andrew Whatson 
escreveu:
> * gnu/packages/docbook.scm (docbook2x): New variable.
> ---
>  gnu/packages/docbook.scm | 87 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 87 insertions(+)

FWIW, this looks good to me. Just one minor comment below.
 
> @@ -473,3 +478,85 @@ DB2LaTeX.")
>     (package/inherit dblatex
>       (inputs (alist-replace "imagemagick" `(,imagemagick/stable)
>                              (package-inputs dblatex))))))
> +
> +(define-public docbook2x
> +  (package
> +    (name "docbook2x")
> +    (version "0.8.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "mirror://sourceforge/docbook2x/docbook2x/" +                           
>       version "/docbook2X-" version ".tar.gz")) +              (sha256
> +               (base32
> +               
> "0ifwzk99rzjws0ixzimbvs83x6cxqk1xzmg84wa1p7bs6rypaxs0")))) +   
> (build-system gnu-build-system)
> +    (inputs
> +     `(("bash-minimal" ,bash-minimal)
> +       ("docbook-xml" ,docbook-xml)
> +       ("perl" ,perl)
> +       ("perl-xml-namespacesupport" ,perl-xml-namespacesupport)
> +       ("perl-xml-parser" ,perl-xml-parser)
> +       ("perl-xml-sax" ,perl-xml-sax)
> +       ("perl-xml-sax-base" ,perl-xml-sax-base)
> +       ("texinfo" ,texinfo)
> +       ("xsltproc" ,libxslt)))
> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "--prefix=" (assoc-ref %outputs "out")))

There’s no need to pass the prefix argument. ‘gnu-build-system’ already 
does it.

-- 
Thanks,
Thiago







  reply	other threads:[~2021-08-26 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 12:03 [bug#50131] [PATCH 0/3] Add docbook2x and generate lxc man pages Andrew Whatson
2021-08-20 12:09 ` [bug#50131] [PATCH 1/3] gnu: Prefix licenses in docbook module Andrew Whatson
2021-08-20 12:09   ` [bug#50131] [PATCH 2/3] gnu: Add docbook2x Andrew Whatson
2021-08-26 15:36     ` Thiago Jung Bauermann via Guix-patches via [this message]
2021-08-20 12:09   ` [bug#50131] [PATCH 3/3] gnu: Generate man pages for lxc Andrew Whatson
2021-08-26 15:49     ` Thiago Jung Bauermann via Guix-patches via
2021-08-27  4:21       ` Andrew Whatson
2021-08-27  4:15   ` [bug#50131] [PATCH 2/3 v2] gnu: Add docbook2x Andrew Whatson
2021-08-27  4:15   ` [bug#50131] [PATCH 3/3 v2] gnu: Generate man pages for lxc Andrew Whatson
2021-08-27 17:48     ` Thiago Jung Bauermann via Guix-patches via
2021-09-13 10:30       ` bug#50131: [PATCH 0/3] Add docbook2x and generate lxc man pages Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40771916.5y4UuSq5LN@popigai \
    --to=guix-patches@gnu.org \
    --cc=50131@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    --cc=whatson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).