From: Bruno Victal <mirai@makinata.eu>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 66609@debbugs.gnu.org
Subject: [bug#66609] [PATCH 1/1] services: admin: Export rottlog-configuration accessors.
Date: Wed, 18 Oct 2023 16:44:31 +0100 [thread overview]
Message-ID: <405466f7-f78d-437c-ac9f-bea54e22e91c@makinata.eu> (raw)
In-Reply-To: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com>
Hi Simon,
On 2023-10-18 16:10, Simon Tournier wrote:
> * gnu/services/admin.scm (<rottlog-configuration>): Rename accessors
> rottlog-rottlog to rottlog-configuration-rottlog, rottlog-rc-file to
> rottlog-configuration-rc-file, rottlog-rotations to
> rottlog-configuration-rotations, rottlog-jobs to rottlog-configuration-jobs.
> (rottlog-etc, rottlog-jobs-or-default, rottlog-service-type): Adjust
> accordingly.
[…]
> +;;; Copyright © 2023 Simon Tournier <zimon.toutoune@gmail.com>
The changes don't look original enough to warrant this IMO, other
than that it LGTM.
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.
next prev parent reply other threads:[~2023-10-18 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 15:08 [bug#66609] [PATCH 0/1] services: admin: Export rottlog-configuration accessors Simon Tournier
2023-10-18 15:10 ` [bug#66609] [PATCH 1/1] " Simon Tournier
2023-10-18 15:44 ` Bruno Victal [this message]
2023-10-24 16:56 ` bug#66609: " Simon Tournier
2023-10-20 22:21 ` [bug#66609] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405466f7-f78d-437c-ac9f-bea54e22e91c@makinata.eu \
--to=mirai@makinata.eu \
--cc=66609@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).