From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vagrant Cascadian <vagrant@debian.org>, 63435@debbugs.gnu.org
Cc: iyzsong@envs.net
Subject: [bug#63435] Add vcmi 1.2.1 to games.scm
Date: Sat, 13 May 2023 08:12:23 +0200 [thread overview]
Message-ID: <40512ea5dbdf297cea0d06f7270ee5ac8cb3e34e.camel@gmail.com> (raw)
In-Reply-To: <87ttwhm2vg.fsf@wireframe>
Hi,
Am Freitag, dem 12.05.2023 um 18:33 -0700 schrieb Vagrant Cascadian:
> + %D%/packages/patches/fuzzylite-relative-path-in-tests.patch \
> + %D%/packages/patches/fuzzylite-use-catch2.patch \
> + %D%/packages/patches/fuzzylite-when-testing-large-float-numbers-
> for-equ.patch
Prefer names that don't blow up the file name, e.g. "fuzzylite-fix-
test", "fuzzylite-soften-float-equality", or "fuzzylite-workaround-
issue-N" – although I'm not sure whether we have a precedent for the
latter.
> + (patches (search-patches "fuzzylite-use-catch2.patch"
> + "fuzzylite-when-testing-large-float-numbers-
> for-equ.patch"
> + "fuzzylite-relative-path-in-tests.patch"))))
This doesn't appear properly indented.
> + (synopsis "fuzzy logic control binary")
Capitalize the first word. IIRC we also allow title case for proper
names and such, but I don't think that'd be necessary here.
> + "fuzzylite is a fuzzy logic control library which allows one
> +to easily create fuzzy logic controllers in a few steps utilizing
> +object-oriented programming.")
Proper sentences start with an uppercase letter. The convention is to
use @-constructs when the package name prohibits that. You can also
cheat via "This package provides ..."
> + (license license:gpl3)))
No +?
> fuzzylite is a registered trademark of FuzzyLite Limited.
Perhaps also look into their trademark policy then, if they have any.
> +-#include "test/catch.hpp"
> ++#include "catch2/catch.hpp"
Use <catch2/catch.hpp> to signal that this is a system header.
Cheers
next prev parent reply other threads:[~2023-05-13 6:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 5:43 [bug#63435] Add vcmi 1.2.1 to games.scm Vagrant Cascadian
2023-05-11 17:17 ` Liliana Marie Prikler
2023-05-11 21:48 ` Vagrant Cascadian
2023-05-11 23:07 ` Vagrant Cascadian
2023-05-12 1:47 ` Liliana Marie Prikler
2023-05-12 6:17 ` Vagrant Cascadian
2023-05-12 20:53 ` Liliana Marie Prikler
2023-05-13 1:33 ` Vagrant Cascadian
2023-05-13 1:35 ` Vagrant Cascadian
2023-05-13 6:16 ` Liliana Marie Prikler
2023-05-14 19:52 ` Vagrant Cascadian
2023-05-15 18:31 ` Liliana Marie Prikler
2023-05-15 19:07 ` Vagrant Cascadian
2023-07-03 2:50 ` Vagrant Cascadian
2023-07-09 5:36 ` bug#63435: " Liliana Marie Prikler
2023-05-13 6:12 ` Liliana Marie Prikler [this message]
2023-05-14 19:50 ` [bug#63435] " Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40512ea5dbdf297cea0d06f7270ee5ac8cb3e34e.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=63435@debbugs.gnu.org \
--cc=iyzsong@envs.net \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).