From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gBG2FzhGtF+xHgAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 21:52:56 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iEepEzhGtF/+BgAA1q6Kng (envelope-from ) for ; Tue, 17 Nov 2020 21:52:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 064F39403AD for ; Tue, 17 Nov 2020 21:52:56 +0000 (UTC) Received: from localhost ([::1]:58490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf8uE-0001RI-Uw for larch@yhetil.org; Tue, 17 Nov 2020 16:52:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf8tN-0000Lx-UE for guix-patches@gnu.org; Tue, 17 Nov 2020 16:52:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf8tN-0008Uj-KX for guix-patches@gnu.org; Tue, 17 Nov 2020 16:52:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kf8tN-0003Ga-Jh for guix-patches@gnu.org; Tue, 17 Nov 2020 16:52:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38408] [PATCH v16 3/6] import: crate: Use guile-semver to resolve module versions. Resent-From: Martin Becze Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Nov 2020 21:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38408 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 38408@debbugs.gnu.org Received: via spool by 38408-submit@debbugs.gnu.org id=B38408.160564990612531 (code B ref 38408); Tue, 17 Nov 2020 21:52:01 +0000 Received: (at 38408) by debbugs.gnu.org; 17 Nov 2020 21:51:46 +0000 Received: from localhost ([127.0.0.1]:33197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf8t8-0003G3-Me for submit@debbugs.gnu.org; Tue, 17 Nov 2020 16:51:46 -0500 Received: from mx1.riseup.net ([198.252.153.129]:35608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf8t6-0003Fs-HX for 38408@debbugs.gnu.org; Tue, 17 Nov 2020 16:51:45 -0500 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4CbKQj6Z9BzFdwm; Tue, 17 Nov 2020 13:51:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1605649901; bh=NutzVUrK4gAXeMg9iYEacQfocVYk+OX1QQlT+BTTI1I=; h=Subject:From:To:References:Date:In-Reply-To:From; b=nF3ZMxhGMqJRByFHkwV/RI2+X0EteddgIpyRqCMDbpCcq5n4UZyRFmvHJw0NNfJg3 Ezqcux3RZcFLRA3PzKZMS8vUYMRxUgCse1/Zn2A6IwkIwYj8cSWrQovL/lLGGR/3po xKvATsNcU/GO5TKPEii69EYohCOE4PI+F0ZxgVaY= X-Riseup-User-ID: BDEB6756EDF7F04560E4D3397CF0788F6B49223ACF1104C826E3CE494B0A2AAF Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 4CbKQh4F5MzJn5S; Tue, 17 Nov 2020 13:51:38 -0800 (PST) From: Martin Becze References: <9a14a3c5-dcab-98ce-8d81-d5c19b77cf93@crazy-compilers.com> <9a7b9c3e-8553-d2d5-6b8a-2ad62b0132c7@riseup.net> Message-ID: <3f9e33f3-a21b-8d9a-fdc2-7ec4ed016999@riseup.net> Date: Tue, 17 Nov 2020 15:51:36 -0600 MIME-Version: 1.0 In-Reply-To: <9a7b9c3e-8553-d2d5-6b8a-2ad62b0132c7@riseup.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=riseup.net header.s=squak header.b=nF3ZMxhG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: bqFXeedlHbXy Hartmut, I just saw you v17 I think that is probably better then what I have attached. On 11/17/20 3:43 PM, Martin Becze wrote: > > > On 11/10/20 4:13 PM, Hartmut Goebel wrote: >> Please add a brief change description for crate-recursive-import. > > Done > >> > >> I could not spot this change. has this been reverted in one of the many > >> version of this series? > > > I added a better description in the attached commit. > >> Does this still fetch the latest version? Or is it the latest version > >> matching a semver range, or the latest non-beta version? > > > The latest version including beta versions > >> Is this change in the last line intended? Another patch of this series > >> reverts this change. > > No, nice catch. Changing this creates conflicts so I will update the > patch set. > >> Does this still fetch the latest version? Or is it the latest version > >> matching a semver range, or the latest non-beta version? > > > I will add more advance tests in a separate commit at the end. > > Attached is the updated patch set. I believe it address everything > brought up but please let me know if there is anything else. Thanks a > lot for looking at this.