From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id yFuyOFQnT2fl1wAAqHPOHw:P1 (envelope-from ) for ; Tue, 03 Dec 2024 15:44:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id yFuyOFQnT2fl1wAAqHPOHw (envelope-from ) for ; Tue, 03 Dec 2024 16:44:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=kMdaYawP; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b=JHCiPWrJ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733240660; a=rsa-sha256; cv=none; b=U+cCwj55kGJI9yvFNyHLBtEoGveCZl6pKfjneDrGmHG3iwMQ27nrKod16bQo3sDUS2NMum usfLp0JZ2Em3/o72jqSLuo0bgerKSheWJ8oZmEb4WNIkqbjwkBY025cTxPCerxQPNIGsZo izZmt3zwTL8RM6Xuqu2ApcE2N5nIPiSTufPBsAbtR16KytBkMbVq+0paH41Db9iAjUc7J3 RO4q2jAXKm9AhGKiQ9HNMSkW/ijiy3Z5fXMJQV5MWuu/izTJJxwzef7Hk/6BWr1WatSlR4 ihwcgY5BHOdPp/Mbp11XF8GOeERI1kaq0sQx7BA4dLV0pvvTp9434MF8usH0VQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=kMdaYawP; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b=JHCiPWrJ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733240660; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=p42QqMtA+5s/J8FUnTtwRI1bEtnMV8cXjawPSHAUQV0=; b=gwZQGwbJDoNyZbj8aeOKm4QQJxwipsqzOiEN0XeiaCKQeI7ZME5aKznUdN4dyc8dMXE86M Z9uM9GvP7Sb1GXPFdN8J346q3TI2LweFkN7qDGAuakO6y60OG6MB9KR55hJVrJZrUrgc0b 4wrAoRs5tPAS3xFbWbFxsHWZuHY2kKPqS8DORQzDlZ8YbGffRNeX+0rhh6XS3c6Cg5aClt wtx/VguCziP1hEXblArwCO6UQ52jhuAR24nx7i3KzZGKCCpxqFZV4WgOhD2YloRSCpnesl Ia9EE9cosoPSXQve6R34Ea7d70ge2msCAp2SWzAHg1+4AXX4/GQZvEaCcW2SOg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5377161D04 for ; Tue, 03 Dec 2024 16:44:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIUaJ-0006Li-SN; Tue, 03 Dec 2024 10:13:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIUaH-0006JM-7R for guix-patches@gnu.org; Tue, 03 Dec 2024 10:13:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIUaF-00061P-Mc; Tue, 03 Dec 2024 10:13:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=p42QqMtA+5s/J8FUnTtwRI1bEtnMV8cXjawPSHAUQV0=; b=kMdaYawPRjuPLCxWEOBiHydeRRKyw+fKiuojsB81F1y4BfQ2bDHCr/m1lQYKvU8IIabm/pCxr65mTp8fYU+uvS/6lqWdwjo6I3mNrAP9anIYkQeBR358MG5M5VdiB1botJ1Rgdc1pIv9PMywloIsEeNZQP4sI1bxdK/xE1EQwwZOrfxys/lcTkY+MEXZ1ybslF5ldDF55TE7IUSMu99oJ4RifluyhJAoLHYPnETm/MDtN0CVkVE3sV+tjLpixRaCpXICGEqUM+2yAtKPYKWI8895QyHpmMbLDrc0vGd2eFvfXjYcNz8sUfrfSITojeLUkuY31Z6QE9shSAKeaPsSdw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIUaE-0003k4-HN; Tue, 03 Dec 2024 10:13:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74670] [PATCH] tests: pack: Fix AppImage tests. Resent-From: =?UTF-8?Q?No=C3=A9?= Lopez Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, guix-patches@gnu.org Resent-Date: Tue, 03 Dec 2024 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74670@debbugs.gnu.org Cc: =?UTF-8?Q?No=C3=A9?= Lopez , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by submit@debbugs.gnu.org id=B.173323876814352 (code B ref -1); Tue, 03 Dec 2024 15:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Dec 2024 15:12:48 +0000 Received: from localhost ([127.0.0.1]:60816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIUa0-0003jP-3h for submit@debbugs.gnu.org; Tue, 03 Dec 2024 10:12:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:52172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIUZx-0003jF-M5 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 10:12:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIUZq-0005nx-Cs for guix-patches@gnu.org; Tue, 03 Dec 2024 10:12:40 -0500 Received: from smtp.domeneshop.no ([2a01:5b40:0:3006::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIUZo-0005yy-49 for guix-patches@gnu.org; Tue, 03 Dec 2024 10:12:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=p42QqMtA+5s/J8FUnTtwRI1bEtnMV8cXjawPSHAUQV0=; b=JHCiPWrJkcRZMmcYjQkH7yFZ30 /J2zep7yU38HSudrF334IJNp7dLol+nSh5BwszS3jpYQQXaeTAl/sw+xSMQDjxf5VuImrvNBSGtE1 wblQhm9LXyctULr/ZNbnPdunOhOaFekQpDFsnPZD1CvkjAAasYIIVz4ffFgVDYrmG6OZUsRT/O1GU MRyUwC7IwOBC4qVOs6zffDl2cuOYaQupTDtltQnuPnfp2Uu5wcOSx0J4hQtKC2IxDI+rmzwRrCWro Q1SVaAAIb8Pwqrob9IMqC2O0o1frn9/G+B1oLsRbF2QFhgALTy8ItLqYv8C+5c+R0IQ2AMwU0j9fm uugwiSHA==; Received: from smtp by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) id 1tIUZj-006sVB-96; Tue, 03 Dec 2024 16:12:31 +0100 Date: Tue, 3 Dec 2024 16:13:24 +0100 Message-ID: <3f75445c04184678b357e777bfbc5eb751b9f363.1733238317.git.noelopez@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:5b40:0:3006::1; envelope-from=noe@xn--no-cja.eu; helo=smtp.domeneshop.no X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: =?UTF-8?Q?No=C3=A9?= Lopez X-ACL-Warn: , =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= From: =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.05 X-Spam-Score: -0.05 X-Migadu-Queue-Id: 5377161D04 X-Migadu-Scanner: mx12.migadu.com X-TUID: w84nWnaY//dF From: Noé Lopez * tests/pack.scm: Add glibc to AppImage tests’ profiles. Change-Id: I7890b902f65a2944ae8fa03db8a964deda3c725c --- Hi, This patch fixes the tests failing for AppImage pack. I believe the issue was that without the AppImage runtime (--appimage-extract-and-run), the glibc is not available to the AppRun binary, causing a file not found error. This is an issue caused because AppRun is built using the relocatable runtime, which requires (or at least is built with) the glibc. This is not an issue when using the AppImage runtime with FUSE, since it correctly mounts the store payload before starting the AppRun. Have a nice day, Noé tests/pack.scm | 39 ++++++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/tests/pack.scm b/tests/pack.scm index 1c1e312557..2cb643f136 100644 --- a/tests/pack.scm +++ b/tests/pack.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2017-2021, 2023 Ludovic Courtès +;;; Copyright © 2017-2021, 2023, 2024 Ludovic Courtès ;;; Copyright © 2018 Ricardo Wurmus ;;; Copyright © 2021, 2023 Maxim Cournoyer ;;; Copyright © 2023 Oleg Pykhalov @@ -34,7 +34,7 @@ (define-module (test-pack) #:use-module ((guix build utils) #:select (%store-directory)) #:use-module (gnu packages) #:use-module ((gnu packages base) #:select (libc-utf8-locales-for-target - hello)) + hello glibc)) #:use-module (gnu packages bootstrap) #:use-module ((gnu packages package-management) #:select (rpm)) #:use-module ((gnu packages compression) #:select (squashfs-tools)) @@ -347,36 +347,53 @@ (define rpm-for-tests (mlet* %store-monad ((guile (set-guile-for-build (default-guile))) (profile -> (profile - (content (packages->manifest (list %bootstrap-guile hello))) + (content (packages->manifest (list %bootstrap-guile hello glibc))) (hooks '()) (locales? #f))) (image (self-contained-appimage "hello-appimage" profile #:entry-point "bin/hello" #:extra-options - (list #:relocatable? #t))) + '(#:relocatable? #t))) (check (gexp->derivation "check-appimage" - #~(invoke #$image)))) - (built-derivations (list check)))) + (with-imported-modules '((guix build utils)) + #~(begin + (use-modules (ice-9 popen) + (guix build utils)) + (let ((pipe (open-pipe* OPEN_READ + #$image "--appimage-extract-and-run"))) + (call-with-output-file #$output + (lambda (port) + (dump-port pipe port))) + (exit (status:exit-val (close-pipe pipe))))))))) + (built-derivations (list (pk 'APPIMAGE-drv check))))) (unless store (test-skip 1)) (test-assertm "appimage + localstatedir" (mlet* %store-monad ((guile (set-guile-for-build (default-guile))) (profile -> (profile - (content (packages->manifest (list %bootstrap-guile hello))) + (content (packages->manifest (list %bootstrap-guile hello glibc))) (hooks '()) (locales? #f))) (image (self-contained-appimage "hello-appimage" profile #:entry-point "bin/hello" #:localstatedir? #t #:extra-options - (list #:relocatable? #t))) + '(#:relocatable? #t))) (check (gexp->derivation "check-appimage" - #~(begin - (invoke #$image))))) - (built-derivations (list check)))) + (with-imported-modules '((guix build utils)) + #~(begin + (use-modules (ice-9 popen) + (guix build utils)) + (let ((pipe (open-pipe* OPEN_READ + #$image "--appimage-extract-and-run"))) + (call-with-output-file #$output + (lambda (port) + (dump-port pipe port))) + (exit (status:exit-val (close-pipe pipe))))))))) + (built-derivations (list (pk 'APPIMAGE-drv check))))) (unless store (test-skip 1)) (test-assertm "deb archive with symlinks and control files" base-commit: bb8a6f0ac47296d3a18e1e0a26ea3a833eb77c4a -- 2.46.0