From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id UBDSHfFTrWVMUwEA62LTzQ:P1 (envelope-from ) for ; Sun, 21 Jan 2024 18:27:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UBDSHfFTrWVMUwEA62LTzQ (envelope-from ) for ; Sun, 21 Jan 2024 18:27:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=runbox.com header.s=selector1 header.b=fWrRbICn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705858033; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bYHALp1O7J2NQhE9c2y8t9emPJmmRp0A0yZpNtO9k54=; b=WDBwLk0OQ/nI3Vw7OorBv0Jyp/zCjpkAXT4QRbvl+dtrUFYz6LN2CBFePlhB0Pr5vRsp44 19gJhSi+oDECukpan6XTkLwIDkCi0LJwn2jhKfS/hkQuRd5GnIueuwEEJdY8jBSqbudKjV /vK72zJTvOFFUXuQ6miugtGbbXjlwFdBhTlP3fTTN0LkqZZv650FhyFLQgdU5Xpv2wIn+3 93+XAcIk8xVke4i4HhqHs1nvncOYqhasrdJCKhaWSRGLER8B2VObd8sun6+QFnjBsXqqCV LJrjf65PApb+lgjbs9VVHXc7+1G8TNj3kpmFLxlLxcSsK/BnlMmYSChIuHqTXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=runbox.com header.s=selector1 header.b=fWrRbICn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705858033; a=rsa-sha256; cv=none; b=B0tW+dRHemBKSaD0VMmaFl2atfAUYCCWAhsRuaERZ5sCRd7W1BS5w+J9inYfJ5hFx25DQs gp4IJv9UyxP4trUqclAer0W1OlJ1BblOQo/ArFNfUP2tXuQBaTg+NrS9NfYpyBeEiSV1q7 LBwB1+LPsrrGqDuTNOeSIq1kJBJqPSQVnpOad89Hc1wpR43vYCHUnwy4zAUKV5WD8uji0M 6QQ4CyJN2u1LlO3rlwqvVaYQ0/DjiUmSc3eN51voVSJJ/fjEBjyagUD7iKq6AJUiGRUuqs aUNx3UkqdWGdCNzuZsFP0n+C41tHvHYkzTuSPL8TjXHh+eppLJ63wLqUiJeh4w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFBBF3CDB1 for ; Sun, 21 Jan 2024 18:27:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRbb5-0006MM-D3; Sun, 21 Jan 2024 12:27:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRbb3-0006MC-E2 for guix-patches@gnu.org; Sun, 21 Jan 2024 12:27:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRbb0-00058l-LC for guix-patches@gnu.org; Sun, 21 Jan 2024 12:27:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRbb3-0000I7-Pq for guix-patches@gnu.org; Sun, 21 Jan 2024 12:27:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67983] built-in downloader Resent-From: Jaeme Sifat Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Jan 2024 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67983 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 67983@debbugs.gnu.org Cc: cox.katherine.e+guix@gmail.com, andrew@trop.in Received: via spool by 67983-submit@debbugs.gnu.org id=B67983.17058579621022 (code B ref 67983); Sun, 21 Jan 2024 17:27:01 +0000 Received: (at 67983) by debbugs.gnu.org; 21 Jan 2024 17:26:02 +0000 Received: from localhost ([127.0.0.1]:38943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRba6-0000GF-14 for submit@debbugs.gnu.org; Sun, 21 Jan 2024 12:26:02 -0500 Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]:60130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRba2-0000Fp-Lp for 67983@debbugs.gnu.org; Sun, 21 Jan 2024 12:26:00 -0500 Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rRbZq-00BDkf-A5; Sun, 21 Jan 2024 18:25:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Cc: References:To:Subject:MIME-Version:Date:Message-ID; bh=bYHALp1O7J2NQhE9c2y8t9emPJmmRp0A0yZpNtO9k54=; b=fWrRbICnTvPsqdwQtYZ8Z30Je1 ChjcrCkYI4owRNVKDvbxRxPAl2v11/+ZSe7XDdhOCknM1q7vEkM+FNB8Iqzp+I5vi58jkUj3C1xqU ma0aVRg3lJMJgfAJkpMDCQ9bmmV1vr/phFDJFzoHPdh4YWZUOI8Uq4SlVdG6iUHCt5WyHAy1ruSvk 1yQV0RWFBlF5rJPu6lde6XupWBHL5YOjiFkmLGSGBibULTBL53WyIZJcefnCV0wP+h9WDx7wHiMPg 8fM9sU2L6ngaxIqTifVYFYYfZFG4ezm7lvRSHA3d4kEv4cE+mKWgGmqePQ5S1aUn+XsJYujAzL2fj mMYWkQ8g==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rRbZp-0002uh-TM; Sun, 21 Jan 2024 18:25:46 +0100 Received: by submission02.runbox with esmtpsa [Authenticated ID (1176697)] (TLS1.2:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rRbZj-00CUiI-0I; Sun, 21 Jan 2024 18:25:39 +0100 Message-ID: <3eb2b8eb-50d8-455a-9e54-ca66c88fe551@runbox.com> Date: Sun, 21 Jan 2024 12:25:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <0e78f8a0772c2779a8849a1846e098a0fdfb760f.camel@gmail.com> Content-Language: en-US In-Reply-To: <0e78f8a0772c2779a8849a1846e098a0fdfb760f.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jaeme Sifat X-ACL-Warn: , Jaeme Sifat via Guix-patches From: Jaeme Sifat via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.75 X-Migadu-Queue-Id: DFBBF3CDB1 X-Spam-Score: -5.75 X-Migadu-Scanner: mx11.migadu.com X-TUID: seKMxDasDLLi On 1/21/24 03:29, Liliana Marie Prikler wrote: > Am Samstag, dem 20.01.2024 um 18:51 -0500 schrieb Jaeme Sifat: >> Hi, This is just a friendly bump for my patchset to add nerd font >> packages to Emacs. There has been no activity on this thread for >> almost a month regarding the new patches. > I don't see how "a built-in downloader" fixes the issues I've pointed > out. Rather, unless this downloader only picks free fonts, it might > well violate the FSDG. I think we'd do well in substitute*-ing the > nerd fonts where needed. > > Cheers On closer inspection, The built-in downloader for `nerd-icons.el' is this procedure. --8<---------------cut here---------------start------------->8--- ;;;###autoload (defun nerd-icons-install-fonts (&optional pfx) "Helper function to download and install the latests fonts based on OS. The provided Nerd Font is Symbols Nerd Font Mono. When PFX is non-nil, ignore the prompt and just install" (interactive "P") (when (or pfx (yes-or-no-p "This will download and install fonts, are you sure you want to do this?")) (let* ((url-format "https://raw.githubusercontent.com/rainstormstudio/nerd-icons.el/main/fonts/%s") (font-dest (cond ;; Default Linux install directories ((member system-type '(gnu gnu/linux gnu/kfreebsd)) (concat (or (getenv "XDG_DATA_HOME") (concat (getenv "HOME") "/.local/share")) "/fonts/" nerd-icons-fonts-subdirectory)) ;; Default MacOS install directory ((eq system-type 'darwin) (concat (getenv "HOME") "/Library/Fonts/" nerd-icons-fonts-subdirectory)))) (known-dest? (stringp font-dest)) (font-dest (or font-dest (read-directory-name "Font installation directory: " "~/")))) (unless (file-directory-p font-dest) (mkdir font-dest t)) (mapc (lambda (font) (url-copy-file (format url-format font) (expand-file-name font font-dest) t)) nerd-icons-font-names) (when known-dest? (message "Fonts downloaded, updating font cache... ") (shell-command-to-string (format "fc-cache -f -v"))) (message "%s Successfully %s `nerd-icons' fonts to `%s'!" (nerd-icons-wicon "nf-weather-stars" :v-adjust 0.0) (if known-dest? "installed" "downloaded") font-dest)))) --8<---------------cut here---------------end--------------->8--- The provided font is Symbols Nerd Font Mono, which is distributed under the expat license. However, I agree that this built in downloader has the chance of violating the FSDG sometime in the future since it points to the main branch of the repo. It [the nerd icons repository] also redistributes the nerd icons font without the respective license notice. > I think we'd do well in substitute*-ing the > nerd fonts where needed. I agree, the much better solution would be to create a patch that removes this crude built-in downloader and instead uses Guix for the nerd icons. So I'm going to send patches that 1. removes the built-in font downloader for `emacs-nerd-icons' and 2. Adds the nerd icons font to Emacs (licensed under expat) and 3. Adds that icon font as a propagated input to `emacs-nerd-icons' As a note I'm surprised that `emacs-nerd-icons' managed to be merged into master as it seems to be the main culprit. Maybe we should remove it for the sake of consistency until this fix is made? I'm willing to send a revised patchset that contains all the emacs nerd font packages + compliance patches with the FSDG. I'm going to see what I can do, thank you for your patience. --- Jaeme