From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:38845)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gttj5-0003dm-DV
	for guix-patches@gnu.org; Wed, 13 Feb 2019 07:33:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gttWE-0005iF-Gk
	for guix-patches@gnu.org; Wed, 13 Feb 2019 07:20:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:46552)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gttWE-0005iA-D6
	for guix-patches@gnu.org; Wed, 13 Feb 2019 07:20:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gttWE-0001xV-7F
	for guix-patches@gnu.org; Wed, 13 Feb 2019 07:20:02 -0500
Subject: [bug#34466] Fwd: Re: [bug#34466] [PATCH] gnu: Add coq-equations.
Resent-Message-ID: <handler.34466.B34466.15500603777491@debbugs.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Wed, 13 Feb 2019 13:19:32 +0100
From: Julien Lepiller <julien@lepiller.eu>
In-Reply-To: <e463eb9d-009f-5d9e-831a-a3ae8eb6dbac@cs.ru.nl>
References: <7a093050-4495-7650-7b9b-2abf73a2efc7@cs.ru.nl>
	<e463eb9d-009f-5d9e-831a-a3ae8eb6dbac@cs.ru.nl>
Message-ID: <3d6474b5553bfe4480dcbfbb558c3b3b@lepiller.eu>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Dan Frumin <dfrumin@cs.ru.nl>
Cc: 34466@debbugs.gnu.org

Le 2019-02-13 12:36, Dan Frumin a écrit :
> (sorry, sending this again because I forgot to CC the bugtracker)
> 
> 
> Hi Julien.
> 
> Thank you for your thorough comments, I really appreciate it!
> I hope that the quality of my patches increase in time so please bear
> with me for a bit :)
> 
> On 13-02-19 12:04, Julien Lepiller wrote:
>> 
>> We cannot use auto-generated tarballs from github, because we found 
>> that
>> they sometimes get regenerated in an unreproducible way, so it breaks 
>> the
>> checksum test. You can use this instead:
>> 
>> (method git-fetch)
>> (uri (git-reference
>>         (url "https://githu.com/mattam82/Coq-Equations.git")
>>         (commit (string-append "v" version "-8.8"))))
>> 
>> and update the sha256 accordingly. As an added bonus, this means that 
>> we
>> can always fetch from the software heritage in case the repo 
>> disappears
>> one day :)
> 
> I was not aware of that. How can I get the sha256 hash in this case?
> Normally I would do `guix download <url>`.

you can always try to build the package, which will fail and tell you
what the correct hash was. I forgot, the filename should be:

(file-name (git-file-name name version))

>> 
>> Please make sure that these two phases both return #t.
> 
> I thought that `invoke' automatically checks that the return code is 
> correct?

It does, and when the code is not correct, it throws an exception. When 
it is
correct, it returns #<unspecified>, so we need to explicitly return #t.

Thank you! I'll try to build the package and take care of the rest 
before pushing
your patch later today.