unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: 26500@debbugs.gnu.org
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Date: Wed, 19 Apr 2017 21:23:49 +0530	[thread overview]
Message-ID: <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> (raw)
In-Reply-To: <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li>


nee writes:

>> If mupdf is a heavy dependency and it is not commonly needed, you can
>> drop it and just package with 7z and rar as dependencies.
>
> I have successfully patched in the path for 7zip.
> I init the variable that stores it with a unicode string. I make the
> assumption that the store path will never contain a ' character.

> I read a little bit about unrar and it's issues with mcomix.
> Unrar is very old and only supports RAR2, as someone says in the mcomix
> issues it is unable to unpack most rar archives created after 2002¹. On
> other distro mcomix currently relies on an unfree rar package², and
> there is an open ticket³ about switching to a free library like
> libarchiver (which supports RAR5 and is also used by file-roller, which
> works fine on GuixSD).
>
> I tried unrar on the commandline and it would list file names, but
> always fail on unpacking. When called by mcomix, it would always try to
> read a password from stdin and freeze the gui.
> I will omit rar support for now, since unrar is mostly useless.

Ok, that's fine.

> @@ -28,6 +29,7 @@
>    #:use-module (guix packages)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system python)
>    #:use-module (gnu packages autotools)
>    #:use-module (gnu packages algebra)
>    #:use-module (gnu packages base)
> @@ -46,6 +48,7 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages qt)
>    #:use-module (gnu packages xorg)
> +  #:use-module (gnu packages python)
>    #:use-module (gnu packages))

Since these modules are already in alphabetical order, it would be good
to keep them that way. Insert (gnu packages python) at an appropriate
position.

> +    (inputs `(("python2-pillow" ,python2-pillow)
> +              ("python2-pygtk" ,python2-pygtk)
> +              ("p7zip" ,p7zip)))

Please put these in alphabetical order too. That means p7zip will go on
the top.

> +    (description "MComix is a customizable image viewer that specializes as
> +a comic and manga reader.  It supports a variety of container formats
> +including CBZ, CB7, CBT, LHA.
> +CBR and rar are currently unsupported, due to unfree dependencies.
> +For optional pdf support, you can install the mupdf package.")

Can we move the information about RAR and PDF support to a comment above
the package definition, as done for the octave package?

  reply	other threads:[~2017-04-19 15:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 17:50 bug#26500: [PATCH] gnu: Add mcomix nee
2017-04-15  8:36 ` Arun Isaac
2017-04-15  9:09   ` ng0
2017-04-16  8:53     ` Arun Isaac
2017-04-17  4:45       ` nee
2017-04-17 19:21         ` Arun Isaac
2017-04-18 22:09           ` nee
2017-04-19 15:53             ` Arun Isaac [this message]
2017-04-19 19:54               ` ng0
2017-04-21  9:00               ` Ludovic Courtès
2017-04-21 17:57                 ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=26500@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).