From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aK7/Eag3lWK4SwEAbAwnHQ (envelope-from ) for ; Mon, 30 May 2022 23:31:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UH35EKg3lWIM6wAAG6o9tA (envelope-from ) for ; Mon, 30 May 2022 23:31:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BBC216AF1 for ; Mon, 30 May 2022 23:31:19 +0200 (CEST) Received: from localhost ([::1]:54424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvmyr-0006lu-PF for larch@yhetil.org; Mon, 30 May 2022 17:31:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvmyd-0006lZ-52 for guix-patches@gnu.org; Mon, 30 May 2022 17:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvmyc-0007vf-Bt for guix-patches@gnu.org; Mon, 30 May 2022 17:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nvmyc-0005NH-8Y for guix-patches@gnu.org; Mon, 30 May 2022 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51314] [PATCH v4 05/14] gnu: Add python-zeroconf-0.33. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 May 2022 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego , 51314@debbugs.gnu.org Received: via spool by 51314-submit@debbugs.gnu.org id=B51314.165394621720567 (code B ref 51314); Mon, 30 May 2022 21:31:02 +0000 Received: (at 51314) by debbugs.gnu.org; 30 May 2022 21:30:17 +0000 Received: from localhost ([127.0.0.1]:46195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvmxt-0005Le-CR for submit@debbugs.gnu.org; Mon, 30 May 2022 17:30:17 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:40634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvmxp-0005LO-Bs for 51314@debbugs.gnu.org; Mon, 30 May 2022 17:30:15 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id d9WB270064UW6Th019WBaC; Mon, 30 May 2022 23:30:11 +0200 Message-ID: <3b5955a87bacf37e995907bc08cfdc6bdb20127f.camel@telenet.be> From: Maxime Devos Date: Mon, 30 May 2022 23:30:04 +0200 In-Reply-To: References: <20220529182746.314668-1-monego@posteo.net> <20220529182746.314668-6-monego@posteo.net> <57edc063f367512adf13e2ce7a9067b4b69850bd.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Xunxad1NPobdD2pw7JDZ" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1653946211; bh=roo6L2FQFJOOCFj/CxCN810ea7jiln611CCN6Fyp50E=; h=Subject:From:To:Date:In-Reply-To:References; b=d9eHwCJ/BfXG0RZATnsDJv6U3mz3+V0SV6j1+2TJQKC2U7pD6YuvY5/K5Wc71fJFc u6/h3GSCmGN58v+NSEO2m48r8vsowVpy9KY27jpmvT6MJNN5ZJ6uIbhb80BOktV+Xw w+kW7LNdmAJEFZSzRALI5ti5zBkY2EZqcCDvMoTX9+M2qvpfxZGjZXE7gy07Ocw66L oapIz7hWu8DD54O7Zax0Cqi5EtvBsixWYxYkU5EROkPqqAEGUIfW97GsFHSHyw9Acx xRX/Fg5y3fvE6Z/ZIQ7fvqnVGvvhu0Rlc2IPseQTdwHDkiD6OUGpoRjIVTgix/hgt3 uYfuSthm/4Ylw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653946279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=roo6L2FQFJOOCFj/CxCN810ea7jiln611CCN6Fyp50E=; b=P+4+bKOGMjwHDFuNm8okqHhlO/uA2AeMIDAmrAr8Vfnj47En5K+8d4MddBlzMVwy+DZrM+ AgC5TcDlxNR7vGCaozrseQzN8QKk0Fqd8NN9FEo3Y62pGeOWfWTS1OfSw2v32fOhTHprCG +FOV5xpnlNciJj8JHj4Pd3PjdouMeNMoyK6Kro4WY5R2rUGMVjdLLTakKvOLfn+dlOkDTE UEwEBR+Pe/aPCy+zWT7IDvkpViKWAm1pWWj8f8rbJ/z9i2EUGULL0yKpjVkBv9qAJNWQ2V 9oBGTN0tR+5eHV8MaMsU84rUDLJbfcJW+9UFraQv8P+QAjSUZuw71oy9rsN/5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653946279; a=rsa-sha256; cv=none; b=QGGwXAADYB0M2Iyz87c9WDydPYnsbMEUAyXDF6hjx5ylSXYH3SbH/9KKi8k+Cs8/MHvID/ FuIkzKrPjKgfV2QH7nLd1xqVmhGsE7C+EmXs3+bx8sX+6Bfp4Tp7rSTkdMkOyeejtxNFAN npxJ28NPKfizrfGsAVgMWEfFnD2kdekBk+RCy28d7XOGvhxXlZrw+/h5Kbz8aZV3sMozcD SVYV15xSJboJIPSLpBtaJocGY/V9IQP4YY1KIkvjvDARbqPym1KxeyomS1k4lMbZizcgrI Yf5Sr/WM6ux41exESYpKZiLM8VE/QBsK3txXagfSbtE8GqanMceybyQIsi61nQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="d9eHwCJ/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.47 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="d9eHwCJ/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7BBC216AF1 X-Spam-Score: 2.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: wvSGgWssGhiy --=-Xunxad1NPobdD2pw7JDZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Vinicius Monego schreef op ma 30-05-2022 om 20:55 [+0000]: > As mentioned in the cover letter for v4, octoprint hard-checks the > versions of its dependencies and uses pip to download new versions for > the packages it judges the version is incorrect. In the case of > zeroconf there is a notice in setup.py: >=20 > https://github.com/OctoPrint/OctoPrint/blob/53b9b6185781c07e8c4744a6e2846= 2e96448f249/setup.py#L67 To me this seems information to put in a comment next to the input list (and next to python-zeroconf-0.33). Also, I recommend removing the pip downloading code to be 100% sure it won't be run. > The author recognizes that octoprint is not so friendly to packagers: > https://github.com/OctoPrint/OctoPrint/issues/1922#issuecomment-302407764 > It does depend on specific versions of some packages, for the one > or other reasons, and this is something I do not want not change > > - I've run into too many problems with outdated python libraries > > provided by the system package manager that produced horribly > > hard to track down bugs. There are bugs in the python-zeroconf@0.33 that have been fixed in python-zeroconf@0.38.1. The readme in https://github.com/jstasiak/python-zeroconf mentions a few fixed bugs that seem rather subtle. So as-is, we would be distributing an octoprint with a known-buggy depdendency with known fixes. Though neither is changing to the new zeroconf an option (unless changes are made to octoprint) as-is because the new zeroconf is apparently incompatible. Greetings, Maxime. --=-Xunxad1NPobdD2pw7JDZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpU3XBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hbKAQC0k2P4NVHMVlTdQlBBT73Dc/LK sCdVZ5VD2blnW+Xx0AEA4sSBq9A4uXLEnhg8ybViEUY4OK9vGcKAmH7cUs8yUQk= =0gP0 -----END PGP SIGNATURE----- --=-Xunxad1NPobdD2pw7JDZ--