From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KKjgEsbg6GZOFQAAe85BDQ:P1 (envelope-from ) for ; Tue, 17 Sep 2024 01:52:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id KKjgEsbg6GZOFQAAe85BDQ (envelope-from ) for ; Tue, 17 Sep 2024 03:52:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Ll4hHrsv; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="a1ohH/8E"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726537925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pgDK+ypqOvEFqriZLGBC7CD66uoFEJ6Hku+P4DxpDOY=; b=MMawUnzaHG3rGx5JiRJ9rn19x+yCHRQtjbwb92GabjOXTPwJMrR4F5Fm2ePvWxicxNSSCl UN4U44H/apPbOm2R/bftYzzdYoq4GkmoFVAG8APkN+a/SNVZISrbPdDi0Ux69THoI4WyAF O7lW5kgmbBISiGmfLtGYlxm28Nare0THYwEwleBY/gdOUbP7GnR/D1m76xG4arU2y6PvHx sjWBfhFfZTYrHdeXZrLOMBElsjmwNK9aOg02C2DcA3MeM5lkMdamMflYSkVhIYFcbenMPE 4xgW7kOfk7goAy97AdJ8UxYEEEVJ5ZeK8/3kNpdWHzDejab/u6gZml8xTJBQeQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Ll4hHrsv; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="a1ohH/8E"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726537925; a=rsa-sha256; cv=none; b=HCxd0TEUg2jkDUE+A8pOI0Osp6wRX620DIuCqWAxMheUi3HpkZokFNVXFoFDXJbRyT1/jY UJOm/67YSMTh544kGYHgcjtjUmWrztprFb3JghSnklwnSev1lmmTTT7Uyn9dSbTGfgRRXj OHJPURCMhBopMJdOOydMtgFCTJ0zXvx/kHYWhrFUH3LQeCM5TivyWRymhjR0KNjQ1zd7Af uoLTG2dfJd9DXg4hECpbYvGItYwY5dhjgN8ui0xH4UGZ0fA7RDUQzPNA/rHt/a/c1Laj1A 2sb0mBGSD9t3X6YaAyVBacZhZDgiMjprZXFa8tEdto/v58GgVEAAe8yfZF1B0g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B67657B067 for ; Tue, 17 Sep 2024 03:52:05 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqNNe-00060m-91; Mon, 16 Sep 2024 21:51:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqNNc-00060a-FL for guix-patches@gnu.org; Mon, 16 Sep 2024 21:51:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqNNc-0005Hr-6B for guix-patches@gnu.org; Mon, 16 Sep 2024 21:51:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=pgDK+ypqOvEFqriZLGBC7CD66uoFEJ6Hku+P4DxpDOY=; b=Ll4hHrsvMLvVhYTePWJwuwmRhThQa3uw37+4OnYmXRRl2rBa8tkntFIGu3XYAjyz9h1WUGejK85pOUHHnfvpgpDXQkaMqyvDJuYWx9weHfZsWvuMSVfehqjrBQmedpU769bTTWXDzigTfC35IGwhsaPyVqewt8pq0KkxX/3bp3XROmimrxM3HORukuqRosKn0rzVRSoXLzsJlxjPb32Q73RRDMgYsjXHr4vF85qw31bSAPeNxtCAj/R7o1M/+LOK28HyfLNVAFpbNQGTP25xw/X+SLneYWO7EZSgpV9pm3+ut6UGciLFV6+lDN3nelcQPrfPzbmVTCbDn9kf7TBVGw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqNNp-0007Pw-KM for guix-patches@gnu.org; Mon, 16 Sep 2024 21:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73071] [PATCH mesa-updates 0/8] Various updates for mesa to 24.2.2 Resent-From: aurtzy Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Sep 2024 01:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73071 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73071@debbugs.gnu.org Cc: John Kehayias , aurtzy Received: via spool by 73071-submit@debbugs.gnu.org id=B73071.172653789628476 (code B ref 73071); Tue, 17 Sep 2024 01:52:01 +0000 Received: (at 73071) by debbugs.gnu.org; 17 Sep 2024 01:51:36 +0000 Received: from localhost ([127.0.0.1]:53686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqNNP-0007PD-L9 for submit@debbugs.gnu.org; Mon, 16 Sep 2024 21:51:36 -0400 Received: from mail-il1-f177.google.com ([209.85.166.177]:49514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqNNN-0007Ox-0m for 73071@debbugs.gnu.org; Mon, 16 Sep 2024 21:51:34 -0400 Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3a046d4c465so17097185ab.3 for <73071@debbugs.gnu.org>; Mon, 16 Sep 2024 18:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726537813; x=1727142613; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:subject:references:cc:to :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=pgDK+ypqOvEFqriZLGBC7CD66uoFEJ6Hku+P4DxpDOY=; b=a1ohH/8EcB6ShAl8LtWZ30u9rjY7HftTg2U0MXFvs6gjg+HJj66PvjTWWiSwUMmmq1 TiXanNDbPgis+WTdAkv5JPTJdiQkXIEL1LRlolwnktrZiqvDD39T8eg+ApQfPp5VTJSm 3iBgnBYUj7h+OfZEBlCJqpFf88ERyrgdQ4KG0e2/lWLov7dOx37Qb16XtUIfK3fbvzPT 7QOWB7WEb1hAIS986FUpqH44tUoV0tf+m+JJd6b0zm7SY5l7Adsmk0yDw2mdefSyyD0+ v8xKTtSNILyrc4bngRa1mxwmfKVysxKed2HPbRd1NOqkp6g5A2cFxf6mq6Md2m/Y2oqk ydmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726537813; x=1727142613; h=in-reply-to:from:content-language:subject:references:cc:to :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pgDK+ypqOvEFqriZLGBC7CD66uoFEJ6Hku+P4DxpDOY=; b=YE+lHbSqEJnD+v+uFUWBDmT2V2mlgsdhe9lEkeRMvfHaoA5/f4I/rd7tjRnVxc+Jct sBHhE6AxtufgnOBtaHwf/5Ug+9kOaUHqjtkv3nNNhaKpX+B46DLpsxY6RjIhoKUoEZWq QVbgdWdzq6Zq30EDOk8ANhv+mrWqk3Tc49Un6tC2j8xd9VOoQJ5bU7Vi1iRW0lpRw7Br b65iU17dfBQJPOcDnABHeQCVQ+XU/IFZlcu3G8Rs4LPJvRzcnWyT2NCS0HrcyH9pUAb3 BsTWgQjGzEGNyLuaUFxYkbN5iv2McgfecTP9EV80Vd5Aql01huou9iHo6bQHahOOJZzR Nz6w== X-Gm-Message-State: AOJu0Yzv9z4CEdH5xkBo/Ax2zfYj/0Pi+BtTlQ9wRw2qSocrcL1NqCt7 wFhryDg+XpbV8ZJSmZbKrzmTulUmqaf9x7S375rn3jrCxoj+Y+TaPqXgNA== X-Google-Smtp-Source: AGHT+IHlj3ubqr5Uwn24oTlvSpcXEImRCetRSK7fHKTQMYkFpZhefjKSSXh6ZeqTtp8QV0pNNG6TGw== X-Received: by 2002:a05:6e02:1a0f:b0:3a0:98cd:3754 with SMTP id e9e14a558f8ab-3a098cd3ab4mr65521565ab.4.1726537812514; Mon, 16 Sep 2024 18:50:12 -0700 (PDT) Received: from ?IPV6:2600:4808:a053:7600::e413? ([2600:4808:a053:7600::e413]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a092b83b33sm19752195ab.0.2024.09.16.18.50.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 18:50:11 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------HnxJgSCX7UtMHp1z0XQk93Z1" Message-ID: <3a438e24-05a0-4a7b-95d9-d91fa61047bd@gmail.com> Date: Mon, 16 Sep 2024 21:50:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <877cbcpalv.fsf@protonmail.com> Content-Language: en-US From: aurtzy In-Reply-To: <877cbcpalv.fsf@protonmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.01 X-Spam-Score: -6.01 X-Migadu-Queue-Id: B67657B067 X-Migadu-Scanner: mx10.migadu.com X-TUID: CdOCysz1a7b9 This is a multi-part message in MIME format. --------------HnxJgSCX7UtMHp1z0XQk93Z1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I have an additional question/concern that's come up, but to address your comments first: On 9/15/24 22:59, John Kehayias wrote: >> Since last, I have managed to find a better solution to the issue with >> substituting rust dependency sources. Briefly on what I have so far: this >> makes use of writing wrap files with just the "directory" property, having >> meson fall back to using a local directory that sources are copied to. Doing >> this resulted in an odd behavior with the overlay directories (i.e. important >> extra files in subprojects/packagefiles) where they don't seem to be >> automatically copied as expected when falling back to local files; however, a >> simple copy resolves it, although I thought it would still be good to note and >> add a comment about. >> >> I initially made the wrap-file-writing a build utility procedure >> 'patch-wrap-file' (which can be seen my personal config [1]) as it seemed like >> it could be useful for other meson packages, but for this patch I've inlined >> it since I'm not confident in its applicability across different projects. >> I'd be happy to hear thoughts about it if it might be useful, though. >> >> [1] >> > Very nice! Yes, more utilities to help with unbundling essentially > will be helpful. I don't know if I ever wrote a wrap file or just > patched the directory bit into the meson file directly. I would have > to look this over, but a utility function (or via keyword argument in > meson-build-system?) would be great. Okay! I'll have a look at the keyword argument approach as well and see if I can make a proposal for changes and further comments sometime soon. > As for the main patch: I've built locally and see nouveau as a vulkan > driver on x86_64 but not i686. That's about all I can test though. The > change to #:meson means other archs will rebuild too, but I don't know > if they got far anyway (so we can cancel old derivations). Perhaps a > new mesa point release will be out this week? Then I could bump the > version, rebase, and rebuild with this patch. Thoughts? I didn't consider this when writing the patch, but would it be a good idea to only use meson-1.5 for x86_64? We could avoid rebuilds that way. Looks like a new mesa release is planned for the 18th [1]. > Other than that, I made a minor tweak to the changelog (remove first > line, name the phase) locally, but have not done a rebase/push on > mesa-updates. Let me give it a few days for other comments and if > there are any other rebuilds to go with it. Regarding my concern (unrelated to NVK): I've had issues with a nonfree application segfaulting which I narrowed down to a mesa commit from a few months ago [2] [3] and hit a dead end with (until today). It's only this single program which I had ever noticed the issue with so I pushed it aside, but it just occurred to me that this seems like a change that could affect other cases my daily driving has not covered. Further investigation today has revealed that adding libglvnd as an input to mesa fixes this, although from what I can tell reading past discussions on adding it, it seems like a complicated issue [4]. Thoughts about this situation? [1] https://docs.mesa3d.org/release-calendar.html#calendar [2] https://gitlab.freedesktop.org/mesa/mesa/-/issues/11666 [3] https://gitlab.freedesktop.org/mesa/mesa/-/commit/50fc7cc290db49288b318c116c6fdc3daaf801e9 [4] https://issues.guix.gnu.org/49339#3 Cheers, aurtzy --------------HnxJgSCX7UtMHp1z0XQk93Z1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi,

I have an additional question/concern that's come up, but to address your comments first:

On 9/15/24 22:59, John Kehayias wrote:

Since last, I have managed to find a better solution to the issue with
substituting rust dependency sources.  Briefly on what I have so far: this
makes use of writing wrap files with just the "directory" property, having
meson fall back to using a local directory that sources are copied to.  Doing
this resulted in an odd behavior with the overlay directories (i.e. important
extra files in subprojects/packagefiles) where they don't seem to be
automatically copied as expected when falling back to local files; however, a
simple copy resolves it, although I thought it would still be good to note and
add a comment about.

I initially made the wrap-file-writing a build utility procedure
'patch-wrap-file' (which can be seen my personal config [1]) as it seemed like
it could be useful for other meson packages, but for this patch I've inlined
it since I'm not confident in its applicability across different projects.
I'd be happy to hear thoughts about it if it might be useful, though.

[1] <https://github.com/aurtzy/guix-config/blob/5cf4c9e277f4ab3a8f1ef87ec5ac47a686da0ad2/my-guix/build/utils.scm#L27>


Very nice! Yes, more utilities to help with unbundling essentially
will be helpful. I don't know if I ever wrote a wrap file or just
patched the directory bit into the meson file directly. I would have
to look this over, but a utility function (or via keyword argument in
meson-build-system?) would be great.
Okay! I'll have a look at the keyword argument approach as well and see if I can make a proposal for changes and further comments sometime soon. 
As for the main patch: I've built locally and see nouveau as a vulkan
driver on x86_64 but not i686. That's about all I can test though. The
change to #:meson means other archs will rebuild too, but I don't know
if they got far anyway (so we can cancel old derivations). Perhaps a
new mesa point release will be out this week? Then I could bump the
version, rebase, and rebuild with this patch. Thoughts?

I didn't consider this when writing the patch, but would it be a good idea to only use meson-1.5 for x86_64? We could avoid rebuilds that way.

Looks like a new mesa release is planned for the 18th [1]. 

Other than that, I made a minor tweak to the changelog (remove first
line, name the phase) locally, but have not done a rebase/push on
mesa-updates. Let me give it a few days for other comments and if
there are any other rebuilds to go with it.

Regarding my concern (unrelated to NVK): I've had issues with a nonfree application segfaulting which I narrowed down to a mesa commit from a few months ago [2] [3] and hit a dead end with (until today). It's only this single program which I had ever noticed the issue with so I pushed it aside, but it just occurred to me that this seems like a change that could affect other cases my daily driving has not covered.

Further investigation today has revealed that adding libglvnd as an input to mesa fixes this, although from what I can tell reading past discussions on adding it, it seems like a complicated issue [4]. Thoughts about this situation?

[1] https://docs.mesa3d.org/release-calendar.html#calendar

[2] https://gitlab.freedesktop.org/mesa/mesa/-/issues/11666

[3] https://gitlab.freedesktop.org/mesa/mesa/-/commit/50fc7cc290db49288b318c116c6fdc3daaf801e9

[4] https://issues.guix.gnu.org/49339#3

Cheers,

aurtzy


--------------HnxJgSCX7UtMHp1z0XQk93Z1--