unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 49315@debbugs.gnu.org
Subject: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input.
Date: Tue, 06 Jul 2021 22:51:29 +0200	[thread overview]
Message-ID: <3a1ae19bb6bb2ceca57e71312caf31391374a934.camel@telenet.be> (raw)
In-Reply-To: <87im1n49u0.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Mathieu Othacehe schreef op di 06-07-2021 om 19:43 [+0200]:
> > When using 'wrap-program', "bash" (or "bash-minimal") should be
> > in inputs.  Otherwise, when cross-compiling, 'wrap-program' will use
> > a native bash instead of the cross bash and the 'patch-shebangs' won't
> > be able to correct this.
> 
> Nice one! Seems to work fine, and as most packages that use wrap-program
> are broken in that aspect, that's a welcomed addition.

Thanks!  I sent a patch series lately adding "bash-minimal" to 'inputs'
when 'wrap-program' is used, using this linter to identify relevant cases.
Ludo would merge it (on core-updates, after some other things have been fixed
there).

I noticed 'qt-build-system' uses 'wrap-program' in its 'qt-wrap'
phase, so I've sent a patch to add 'bash-minimal' to the bag of 'qt-build-system'
when cross-compiling.  That should largely take care of the 'wrap-program'
cross-compilation issues, I hope!

Greetings,
Maxime.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

      reply	other threads:[~2021-07-06 20:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 11:39 [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input Maxime Devos
2021-07-06 17:29 ` Mathieu Othacehe
2021-07-06 20:38   ` Maxime Devos
2021-07-07  9:12     ` bug#49315: " Mathieu Othacehe
2021-07-06 17:43 ` [bug#49315] " Mathieu Othacehe
2021-07-06 20:51   ` Maxime Devos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a1ae19bb6bb2ceca57e71312caf31391374a934.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=49315@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).