From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AApuHqgU7mVv+AAAqHPOHw:P1 (envelope-from ) for ; Sun, 10 Mar 2024 21:14:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id AApuHqgU7mVv+AAAqHPOHw (envelope-from ) for ; Sun, 10 Mar 2024 21:14:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=a4ATa4GO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710101672; a=rsa-sha256; cv=none; b=KzFqqUVEaSrpvQhaaZB0etGZlWQUikzp2GSVMAmBVFo5Fc+iAz6uOCWk+OzDlJbPsANj2e p4h5W3N9MdS8FR6smVIi3ktM6mW2IICrWoy2wh5Y/aPcxXGPnBtL8AaDFKCmKagzhgffB2 +Ri3m/QGPKB5ei1dtrp5hZFQ3DDwgh23lyTtvQsBanUhHTO/N3rlAZoBitGGDfg9HrIrRy VreW3anRQhtc3pWBt9zha9ChN7j6686hmy3n6qXh3WmuxZHp9e9WTMGk570F9S6R6a906T fn0bg2PeSG75jnhfXTFcU/XW8hPD1G1nCF0exqQ30cC3xP62c4TPCHRzS5qM/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=a4ATa4GO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710101672; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8LSL2MX027ZKFPHdmgqJYkX9y1eDV83Vf9LBCXnpr80=; b=NvQxtoVEOznmA4bUm/MdSIS86RNggk+ZYgfEgF/kziMaSlrqsUucTKrgzUnwbx5HvUGqcR WS82wWpmUJ+PSOMTmM3I1aAtls2toKbrwbUzVsTCH8EUU7H9ZrDEsghzpWEovgtsGpttGA KE0m0PrtyB4veiquUzPUYmEiS87PlcRCvho26SX4wdDv77z27UiZ2Qs9iCyufk8K7QNdC3 2W1fX45eQ3nrKsCFj0LDGZHLchENdurU3CPxiCfSD7mzExLGriQx8FGf5cjdRaPg69FYAn pCQ27fQftst18GI2WBdvZykDYec81udq9Da0BOMxBuQ24hEMmjaukOmvo5Nq5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 525AF72F62 for ; Sun, 10 Mar 2024 21:14:31 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjPYz-0004Oy-TM; Sun, 10 Mar 2024 16:14:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjPYy-0004Om-LJ for guix-patches@gnu.org; Sun, 10 Mar 2024 16:14:28 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjPYy-0002n0-DF for guix-patches@gnu.org; Sun, 10 Mar 2024 16:14:28 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjPZV-0003oP-Ph for guix-patches@gnu.org; Sun, 10 Mar 2024 16:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. References: In-Reply-To: Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 10 Mar 2024 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69074@debbugs.gnu.org Cc: troy@troyfigiel.com Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.171010166914598 (code B ref 69074); Sun, 10 Mar 2024 20:15:01 +0000 Received: (at 69074) by debbugs.gnu.org; 10 Mar 2024 20:14:29 +0000 Received: from localhost ([127.0.0.1]:38039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjPYz-0003nO-88 for submit@debbugs.gnu.org; Sun, 10 Mar 2024 16:14:29 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:40478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjPYx-0003nF-19 for 69074@debbugs.gnu.org; Sun, 10 Mar 2024 16:14:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=8LSL2MX0 27ZKFPHdmgqJYkX9y1eDV83Vf9LBCXnpr80=; h=from:subject:cc:to:date; d=soeren-tempel.net; b=a4ATa4GO2jOeYtbN9P6oGfxWvv1r1RhKyBGWUfsB8xGYGVQ XtP40AfucMbsRa9kwYP88KCiFcvOfS+Pey5ukcy2sETcYsB1Y2xHlcenopHtt/EFaHcBuq cGbzX6gmpJJOpqVdxJB3h752qHktPIeYe+BzOC+LUozGvZfpFq8SvE= Received: from localhost (dynamic-2a02-3102-49da-001b-9766-31d2-bfd2-3d82.310.pool.telefonica.de [2a02:3102:49da:1b:9766:31d2:bfd2:3d82]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 3b140201 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 10 Mar 2024 21:13:52 +0100 (CET) Date: Sun, 10 Mar 2024 21:12:40 +0100 From: =?UTF-8?Q?S=C3=B6ren?= Tempel Message-Id: <3F8X2Q5S9RUQP.2PBT94JRGRMIB@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.72 X-Spam-Score: 2.72 X-Migadu-Queue-Id: 525AF72F62 X-TUID: cSyqCdZbifdp Hi, Thanks again for your feedback! I believe I implemented most of your suggestions. Most importantly, I believe, I resolved the cyclic dependency between python-xyz.scm and engineering.scm. Further comments below. > - Regarding binaries, I am honestly not sure how these would be best hand= led. > They are binaries, but without them there might not be much to test any= way... > A second opinion would be good here. I don't think there is an issue with the binaries. angr is a binary analysis tools. Naturally, the test suite will need sample binaries for testing purposes. The GNU FSDG has an explicit clause regarding "non-functional data", I believe this very much applies here as these binaries are not executed and only needed for testing angr's analysis capabilities. Without the binaries there are no tests to run for angr. I would strongly advocate for not disabling the angr test suite as running it on Guix has resulted in the discovery bugs both in angr and in capstone [1, 2]. > I noticed you set them to version 9.2.46, but this is not the latest vers= ion. Newer version of angr will require an update of the python-rich and python-pygments Guix package. Since this would entail a lot of rebuilds (and the upstream integration of the present changeset has already been quite effortful), I opted for packaging an "older" version of angr for now which does not depend on python-rich yet. As soon as python-rich and python-pygments are updated, we can update angr too. > The versions of all other angr packages you added are also set to > 9.2.46. It looks like this is on purpose, or not? This is intended, all of these packages are distributed by the angr development team and need to be set to the same version as angr itself. I added a corresponding comment. > I see that you back ported some upstream patches. I tend to use patches > more as a last resort and whenever possible I stick to upstream > versions and commits (in that order of preference). With the exception of one patch these are all upstreamed patches. I don't want to package unreleased Git versions of these packages and I think it's therefore preferable to just backport the bug fixes. Also consider that angr is very sensitive to versions of packages distributed by angr developers (see the prior comment). > - Hope this helps! The rest LGTM. I will ping the Python team, so > someone with commit rights can have a look. Yea, the feedback definitely helps. Would also love to hear from the Python team. What is left to do in order to get this merged? Greetings S=C3=B6ren [1]: https://github.com/angr/angr/pull/4443 [2]: https://github.com/capstone-engine/capstone/pull/2240