[bug#69074] [PATCH] Add python-angr.

["Sören Tempel" <soeren@soeren-tempel.net>]

Hi,

Thanks again for your feedback!

I believe I implemented most of your suggestions. Most importantly, I
believe, I resolved the cyclic dependency between python-xyz.scm and
engineering.scm. Further comments below.

> - Regarding binaries, I am honestly not sure how these would be best handled.
>   They are binaries, but without them there might not be much to test anyway...
>   A second opinion would be good here.

I don't think there is an issue with the binaries. angr is a binary
analysis tools. Naturally, the test suite will need sample binaries
for testing purposes. The GNU FSDG has an explicit clause regarding
"non-functional data", I believe this very much applies here as these
binaries are not executed and only needed for testing angr's analysis
capabilities. Without the binaries there are no tests to run for angr.
I would strongly advocate for not disabling the angr test suite as
running it on Guix has resulted in the discovery bugs both in angr
and in capstone [1, 2].

> I noticed you set them to version 9.2.46, but this is not the latest version.

Newer version of angr will require an update of the python-rich and
python-pygments Guix package. Since this would entail a lot of rebuilds
(and the upstream integration of the present changeset has already been
quite effortful), I opted for packaging an "older" version of angr for
now which does not depend on python-rich yet. As soon as python-rich and
python-pygments are updated, we can update angr too.

> The versions of all other angr packages you added are also set to
> 9.2.46. It looks like this is on purpose, or not?

This is intended, all of these packages are distributed by the angr
development team and need to be set to the same version as angr itself.
I added a corresponding comment.

> I see that you back ported some upstream patches. I tend to use patches
> more as a last resort and whenever possible I stick to upstream
> versions and commits (in that order of preference).

With the exception of one patch these are all upstreamed patches. I
don't want to package unreleased Git versions of these packages and
I think it's therefore preferable to just backport the bug fixes. Also
consider that angr is very sensitive to versions of packages distributed
by angr developers (see the prior comment).

> - Hope this helps! The rest LGTM. I will ping the Python team, so
> someone with commit rights can have a look.

Yea, the feedback definitely helps. Would also love to hear from the
Python team. What is left to do in order to get this merged?

Greetings
Sören

[1]: https://github.com/angr/angr/pull/4443
[2]: https://github.com/capstone-engine/capstone/pull/2240