From: "Sören Tempel" <soeren@soeren-tempel.net>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: 67896@debbugs.gnu.org
Subject: [bug#67896] [PATCH] gnu: ghc-9.2: Make Cabal respect GHC_PACKAGE_PATH
Date: Sat, 06 Jan 2024 16:07:05 +0100 [thread overview]
Message-ID: <3ELNY2F2SV7KX.2JFO7970OJNKU@8pit.net> (raw)
In-Reply-To: <ZZloY0SubqGqVa_O@noor.fritz.box>
Hi,
Lars-Dominik Braun <lars@6xq.net> wrote:
> sorry for the delay, I just tried your patch and it works well combining
> a local cabal project and libraries/GHC from Guix. I’d say this is a
> massive improvement, so I’d like to ship it with Guix. However this
> is a world rebuilding change, so I’ll push it to the haskell-team
> branch and probably wait for #67921 to be ready before it can hit master.
Yea, glad to hear that. Waiting for #67921 is fine by me. Should I also
prepare a patch for the GHC 9.4 package then? Currently this is only GHC
9.2.
> One minor issue: If you add a patch file, also add it to gnu/local.mk.
Oh, I wasn't aware. Thanks for pointing that out, will keep it in mind
for future patches!
> > However, given that Setup.hs also uses
> > Distribution.Simple and that there are several places in Guix itself
> > where we need to unset GHC_PACKAGE_PATH atm, I personally believe it
> > to be preferable to fix the vendored version.
>
> Which locations are you referring to?
I just grep'ed for GHC_PACKAGE_PATH, e.g.:
* https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/virtualization.scm#n784
* https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/haskell-build-system.scm#n111
* https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/haskell.scm#n963
Greetings
Sören
next prev parent reply other threads:[~2024-01-06 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 10:05 [bug#67896] [PATCH] gnu: ghc-9.2: Make Cabal respect GHC_PACKAGE_PATH soeren
2024-01-06 9:09 ` Sören Tempel
2024-01-06 14:49 ` Lars-Dominik Braun
2024-01-06 15:07 ` Sören Tempel [this message]
2024-01-06 15:51 ` Lars-Dominik Braun
2024-01-06 21:16 ` Saku Laesvuori via Guix-patches via
2024-01-07 9:37 ` Sören Tempel
2024-05-18 9:34 ` Sören Tempel
2024-05-25 17:06 ` Lars-Dominik Braun
2024-06-29 7:00 ` bug#67896: " Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ELNY2F2SV7KX.2JFO7970OJNKU@8pit.net \
--to=soeren@soeren-tempel.net \
--cc=67896@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).