From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uAY+HOzAj2I+fwEAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 20:03:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oHpVHOzAj2L97wAA9RJhRA (envelope-from ) for ; Thu, 26 May 2022 20:03:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 16C50297C5 for ; Thu, 26 May 2022 20:03:24 +0200 (CEST) Received: from localhost ([::1]:41288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuHpS-00049W-Ix for larch@yhetil.org; Thu, 26 May 2022 14:03:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHp8-00049O-TS for guix-patches@gnu.org; Thu, 26 May 2022 14:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuHp8-0006zk-L8 for guix-patches@gnu.org; Thu, 26 May 2022 14:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuHp8-0007m2-Ia for guix-patches@gnu.org; Thu, 26 May 2022 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 May 2022 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55663@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165358815029842 (code B ref -1); Thu, 26 May 2022 18:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2022 18:02:30 +0000 Received: from localhost ([127.0.0.1]:59937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuHob-0007lF-Vr for submit@debbugs.gnu.org; Thu, 26 May 2022 14:02:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:48778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuHoa-0007l6-Hi for submit@debbugs.gnu.org; Thu, 26 May 2022 14:02:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHoa-00041H-9V for guix-patches@gnu.org; Thu, 26 May 2022 14:02:28 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuHoY-0006yM-Eb for guix-patches@gnu.org; Thu, 26 May 2022 14:02:28 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CF0915C0184 for ; Thu, 26 May 2022 14:02:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 May 2022 14:02:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653588145; x=1653674545; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZ OwsVmalo=; b=RYt+MXLifizbp7Fc5waRoM73kZhI1LCR93L8i8KIcH1FZR7XZOP Z5wrkH+3xdcvOMwqlwxx/Kpn5C/qRBN4tCI/ZTiHFgnDV/+qC74TLASgRSV3y00W YfSeF3MSwzdi28PjGA9VXQz2mn38P3KQnpohAcsEG6eeeQqxcS3DMHSYgSFXUERd 65HQjH3cwxDokvp36md2eFQPA8wp0Tp6SlyTps+mkG52vdnBRz15fTxpvIz32Khz OqUNa+FcZWN9Bm2a2jji6oEhpuxSw1QTnH5CaIXzDyVcEkng86P1vcNLmaEzTbvc BTVUB/7XByAwn37iXirpiLNLMDjqnER6kOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653588145; x= 1653674545; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZOwsVmalo=; b=B fCDrx8Thx4u9KL1+LI9E5l/F0ejwXyJwr8kbMTqjxODSZZLz4JhGHaWF+hWuwXWp nxBH/GxpBhpMF0lI9YOCp57qYIC6CpSS0YrwV9zTyeOTQfX3pKgrFkItBlGe9qfE I+0w41Bg4WZIV/Y9+KNHFQAy5JBW6sJPP1lBX7QF6FTzLiQ5BlO8ntkYLNlA09pr v6XkGMsK8Oi64MrRo8MfAD7uAGPYMVmZekuqI8MJ8VfnDjKoNEz6dm7TakDqzLJH 7AIHpVpOgY3IBaDj5sLH6efpCCY22xsT31899DU6xqX5Uy7cPu3k8M7b519xK3xn qW8yZnRSw3thiOTQQpKjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeejgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh dtvdenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghn thhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepjeeiheefieevtefghfegveefhe duffekfeegkeegkefghfefleeljeegvdfhledunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgidroh hrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 26 May 2022 14:02:24 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> Date: Thu, 26 May 2022 21:02:22 +0300 X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=66.111.4.28; envelope-from=p.shlyak@pantherx.org; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653588204; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=cDVeun3lUPhbXR542NrmU5vSJNlVveVojLZOwsVmalo=; b=CkK93buDLFuhUiPJNDneskZCdJpfNs7uv3hfaYGwpdfZlO1RGfReG40nZ8zSnP4WM1iJFN DqvLq7+t+xeBDF5fWFCCjuBNrlHWg1XysaAuYUCwmAJjOtU0WNZruZPpht4y+tNJSCmyp6 ynehUQs/8+clORbkA19OnVRkRoZ+xaZvC8AF0q7l9txdXrWxSeV/h+vZvcMyeFesccL2+h gX4aZMU/OhT/e60CqRb3QXKDxtB4l1lbTvF31uXfd9EDZER3gsNvT/PyBarS8NT9FgLusz fB6Ra0v4K/oUT1UnA92v5FDF5If4SZMbaaR285G6uabIv2/gQ3fLyr8mEyTDtg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653588204; a=rsa-sha256; cv=none; b=blllbqGi4mhDBw9iSSAcbHhMij4BY58TodTslqRZWB4kTWyF3bhlwEmnN8/Bmy3gSvMzyw E8iPVJwmJzZPG/1GwRBTFvQdw4m6qWmOrQiVCBFYETniIvwwps8YFaSHDtipLGsia5i4xj mdfIeW4QgUyPR8ha1+qvcMRnAl29VK2XfPZzE+b8TEMEIQOd8QUOX6SfL2QY2U019PeHCW liCte6FXja2mM9AinNT03PFKJPlSgn02NoQZKWJaGQoi1TUuZjtLLxrVJHsfGrZTM9aJ+D 046++BbNh1TRgGy7MFUvsZGsl0igx/pW3us+dGuyClInZsJ3ooxtyItWAz/TVA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=RYt+MXLi; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="B fCDrx8"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=RYt+MXLi; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="B fCDrx8"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 16C50297C5 X-Spam-Score: 2.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: pMQSSwrG9vEW --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I believe it is an important change as Raspberry PI (and I suppose some = other boards) cannot boot with fat16 boot partitions.=20 With this patch, "vfat" is treated as fat16 partition not to break = backward-compatibility. "fat32", on the other hand, creates a fat32 = partition. --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F Content-Disposition: attachment; filename=0001-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=200700c443d9162ac4928ac8fee58278c1f0824736=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= Image=20API:=20support=20FAT32=20partitions=0A=0A---=0A=20= gnu/build/image.scm=20=20|=208=20+++++---=0A=20gnu/system/image.scm=20|=20= 2=20++=0A=202=20files=20changed,=207=20insertions(+),=203=20deletions(-)=0A= =0Adiff=20--git=20a/gnu/build/image.scm=20b/gnu/build/image.scm=0Aindex=20= 3e8b94e2d6..804685c7fb=20100644=0A---=20a/gnu/build/image.scm=0A+++=20= b/gnu/build/image.scm=0A@@=20-95,12=20+95,12=20@@=20(define*=20= (make-ext-image=20partition=20target=20root=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs_bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A=20=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A=20=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A+=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20fs_bits=20= "-S"=20"1024"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(size-in-kib=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(if=20(eq?=20size=20'guess)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(estimate-partition-size=20= root)=0A@@=20-121,7=20+121,9=20@@=20(define*=20(make-partition-image=20= partition-sexp=20target=20root)=0A=20=20=20=20=20=20((string-prefix?=20= "ext"=20type)=0A=20=20=20=20=20=20=20(make-ext-image=20partition=20= target=20root))=0A=20=20=20=20=20=20((string=3D?=20type=20"vfat")=0A-=20=20= =20=20=20=20(make-vfat-image=20partition=20target=20root))=0A+=20=20=20=20= =20=20(make-vfat-image=20partition=20target=20root=20"16"))=0A+=20=20=20=20= =20((string=3D?=20type=20"fat32")=0A+=20=20=20=20=20=20(make-vfat-image=20= partition=20target=20root=20"32"))=0A=20=20=20=20=20=20(else=0A=20=20=20=20= =20=20=20(raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(&message=0Adiff=20--git=20a/gnu/system/image.scm=20= b/gnu/system/image.scm=0Aindex=20dd32e58c2d..0dd16ed34e=20100644=0A---=20= a/gnu/system/image.scm=0A+++=20b/gnu/system/image.scm=0A@@=20-313,6=20= +313,7=20@@=20(define=20(partition->dos-type=20partition)=0A=20=20=20=20=20= =20=20=20=20=20((member=20'esp=20flags)=20"0xEF")=0A=20=20=20=20=20=20=20= =20=20=20((string-prefix?=20"ext"=20file-system)=20"0x83")=0A=20=20=20=20= =20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20"0x0E")=0A+=20=20= =20=20=20=20=20=20=20((string=3D?=20file-system=20"fat32")=20"0x0C")=0A=20= =20=20=20=20=20=20=20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20= (raise=20(condition=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(&message=0A@@=20-330,6=20+331,7=20@@=20(define=20= (partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20=20=20=20= ((member=20'esp=20flags)=20"U")=0A=20=20=20=20=20=20=20=20=20=20= ((string-prefix?=20"ext"=20file-system)=20"L")=0A=20=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"vfat")=20"F")=0A+=20=20=20=20=20=20=20= =20=20((string=3D?=20file-system=20"fat32")=20"F")=0A=20=20=20=20=20=20=20= =20=20=20(else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A--=20=0A= 2.32.1=20(Apple=20Git-133)=0A=0A= --Apple-Mail=_F2A75323-9AA7-4BAF-A554-A2E6B8C3D50F--