From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EPn5JNB00F+0awAA0tVLHw (envelope-from ) for ; Wed, 09 Dec 2020 06:55:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MJLHINB00F/0TQAAB5/wlQ (envelope-from ) for ; Wed, 09 Dec 2020 06:55:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B6E1940546 for ; Wed, 9 Dec 2020 06:55:12 +0000 (UTC) Received: from localhost ([::1]:42492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmtNX-0001nr-6m for larch@yhetil.org; Wed, 09 Dec 2020 01:55:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmtNN-0001nX-Vy for guix-patches@gnu.org; Wed, 09 Dec 2020 01:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmtNN-0008NA-P0 for guix-patches@gnu.org; Wed, 09 Dec 2020 01:55:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmtNN-0007bH-N4 for guix-patches@gnu.org; Wed, 09 Dec 2020 01:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44789] gnu: Add lemonbar-xft. Resent-From: elaexuotee@wilsonb.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Dec 2020 06:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44789 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Christopher Baines Cc: 44789@debbugs.gnu.org Received: via spool by 44789-submit@debbugs.gnu.org id=B44789.160749685029138 (code B ref 44789); Wed, 09 Dec 2020 06:55:01 +0000 Received: (at 44789) by debbugs.gnu.org; 9 Dec 2020 06:54:10 +0000 Received: from localhost ([127.0.0.1]:60830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmtMT-0007Zn-Ds for submit@debbugs.gnu.org; Wed, 09 Dec 2020 01:54:10 -0500 Received: from m42-5.mailgun.net ([69.72.42.5]:36632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmtMN-0007Z9-Jy for 44789@debbugs.gnu.org; Wed, 09 Dec 2020 01:54:04 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.wilsonb.com; q=dns/txt; s=krs; t=1607496840; h=Content-Type: MIME-Version: Message-Id: In-Reply-To: References: From: Subject: Cc: To: Date: Sender; bh=raib60jZyARkBHe/bXO0soRVngqj6zPn5pmv5sGI80s=; b=sgZnc4Qv5GaDoQBRoT9MK+xDbgjQCdp/dtG+Bvj6UZBhXg2jnGMcr2RyLiyaXHjpPJMwhm3s S9sWn0/sS/jjjdbOeYKhCjr6oI6OAhCVAbmCpqjOr9htNozHj43/21s0+XCxMWzxX/Q5U0fD x+taskyorq71JEd6+a+zlMpOhLqe3Dr2pYWz/7NtbfWsqdM8e6W++AUHXUp5bHK/LtCLT1bX 9dscyoclOIEu2Z6E+ka4TeokwbmG00doxyjrTKgyF3kbtXfhOWezGIHd/dUSC+JwLmzuRl1K uwhbeM53Xi6+HbSL5SaPQCL6V6HzJhqX1Pq6pq4UWrwuSdkZphZMMA== X-Mailgun-Sending-Ip: 69.72.42.5 X-Mailgun-Sid: WyJlNzZhNSIsICI0NDc4OUBkZWJidWdzLmdudS5vcmciLCAiMDg1NDdhIl0= Received: from wilsonb.com (wilsonb.com [104.199.203.42]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5fd07481ce88b59ab8bd5d1f (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Wed, 09 Dec 2020 06:53:53 GMT Received: from localhost (ac185230.dynamic.ppp.asahi-net.or.jp [183.77.185.230]) by wilsonb.com (Postfix) with ESMTPSA id 55645A0C57; Wed, 9 Dec 2020 06:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilsonb.com; s=201703; t=1607496831; bh=raib60jZyARkBHe/bXO0soRVngqj6zPn5pmv5sGI80s=; h=Date:To:Cc:Subject:From:References:In-Reply-To:From; b=DjlXKCAZHZzOES2PhiKLqs03OZ2Z59EpjpC3V7u/NLuQeop9CBdNzZoholVdo9r4B LZbZ9irciKDpORdu76myEklZkazIXBMk36h+zV1kcKULIEvCXchNtlL85HmIDtprKP ozdLCozBsTto86jAt3KZZ07XkcBwxETUKwaa8XQUoTPmcsJ8Y1hoWLW0enhFTjma5K k+hI/066EmykOUMLVCvHvcDzYVviYyIu/wOVxQ7AfKf6MYRvgmFsPTrBz3WrDxH4Os +1QlRj36g1eGWH6ALNcD4RSsHhLMp2mu33wwXQT9pUhXD8z/oBsKm5t7e3LsV7Xq72 91yKJzO0f4RSaORgBst/qeyMnRPu5e1fL0rAuFeWjZhK5hnI7yJFfXIyKn1N/prsco sChLZ34UVVy4V6rha1Rc3EddTRj3zOWZ3r2HapnTmqT69ripb4eKn8P7xerwiJtlmC Hbb0PZg4FlO0WkoVHoQFeAr6lb1ECEOmjMqZbk4IfA7/fz+OK5zVsMiOypLB41DLtF Li1vmjdptSY2Hsisi1TwgwipaNqAlPQv6iopoLSeSyUaKnghFALuTSL/Zv+GbUyNDT ZKizdlPnYSrXDtaOc7m1u0CQMThCoJufgasp54y1eftA4lpCaEKl6wgmWheaEAP7dQ FQLhpukurGo9YzhPH+pXy5tk= Date: Wed, 09 Dec 2020 15:53:44 +0900 References: <2ZE4C0OKC3A7H.2HN5A6QF4EP7L@wilsonb.com> <87zh31sa3y.fsf@cbaines.net> In-Reply-To: <87zh31sa3y.fsf@cbaines.net> Message-Id: <3AIFEQIG2SEFL.2UMS1A13LOXPU@wilsonb.com> User-Agent: mblaze/1.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_0c2005db0cc686830c3319aa_=_" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: elaexuotee@wilsonb.com, elaexuotee--- via Guix-patches From: elaexuotee--- via Guix-patches via X-TUID: Hq0U9Pws9fL1 This is a multipart message in MIME format. ------_=_0c2005db0cc686830c3319aa_=_ Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Christopher Baines wrote: >=20 > elaexuotee--- via Guix-patches via writes: >=20 > > This adds a fork of the `lemonbar' package that supports fontconfig. >=20 > I don't know anything about lemonbar, but this sounds OK in principle. Thanks for the sanity check. > So, it would be nice to change the description (and maybe synopsis) to > set out how this package is different from lemonbar. Oh cool. I have run across several packages that `inherit` from their paren= ts without modifying the description, so just kind of blindly followed suit. Actually, checking package sources however, it looks like inheriting packag= es *do* update synopses and descriptions. > Also, regarding the arguments above, I think you can reduce the > duplication with the lemonbar package by doing something like: >=20 > (arguments > (substitute-keyword-arguments (package-arguments lemonbar) > ((#:make-flags make-flags) > (append make-flags > (string-append > "CFLAGS=3D" > (string-join > (list (string-append "-I" (assoc-ref %build-inputs "freet= ype") > "/include/freetype2") > (string-append "-D" "VERSION=3D" > (format #f "'~s'" ,version))))))))) >=20 > I've only just written this in this email, so I'm not sure if it works, > but I think it's close. Very nice. It required a tad bit of munging, but was very helpful. > Would you be able to send an updated patch? Attached! Note that I opted to `string-append` to lemonbar's synopsis and description= =2E This doesn't seem to be common, but does it make sense here? ------_=_0c2005db0cc686830c3319aa_=_ Content-Disposition: attachment; filename=0001-gnu-Add-lemonbar-xft.patch Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable =46rom 321caf9ba721e0c41dda64298093f1aea1b95b63 Mon Sep 17 00:00:00 2001 =46rom: "B. Wilson" =44ate: Sun, 22 Nov 2020 14:23:48 +0900 =53ubject: [PATCH] gnu: Add lemonbar-xft. =54o: guix-patches@gnu.org =0Agnu/packages/wm.scm(lemonbar-xft): New variable. =2D-- =20gnu/packages/wm.scm | 39 +++++++++++++++++++++++++++++++++++++++ =201 file changed, 39 insertions(+) =0Adiff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm =69ndex 361cecf26f..08b3653c32 100644 =2D-- a/gnu/packages/wm.scm =2B++ b/gnu/packages/wm.scm =40@ -37,6 +37,7 @@ =20;;; Copyright =C2=A9 2020 Marcin Karpezo =20;;; Copyright =C2=A9 2020 EuAndreh =20;;; Copyright =C2=A9 2020 Michael Rohleder =2B;;; Copyright =C2=A9 2020 B. Wilson =20;;; =20;;; This file is part of GNU Guix. =20;;; =40@ -1931,6 +1932,44 @@ formatting, RandR and Xinerama support and EWMH co= =6Dpliance without =20wasting your precious memory.") =20 (license license:x11)))) =20= =2B(define-public lemonbar-xft =2B ;; Upstream v2.0 tag is several years behind HEAD =2B (let ((commit "481e12363e2a0fe0ddd2176a8e003392be90ed02")) =2B (package =2B (inherit lemonbar) =2B (name "lemonbar-xft") =2B (version (string-append "2.0." (string-take commit 7))) =2B (source (origin =2B (method git-fetch) =2B (uri (git-reference =2B (url "https://github.com/drscream/lemonbar-xft") =2B (commit commit))) =2B (file-name (git-file-name name version)) =2B (sha256 =2B (base32 =2B "0588g37h18lv50h7w8vfbwhvc3iajh7sdr53848spaif99nh3mh4"= =29))) =2B (inputs `(("freetype" ,freetype) =2B ("libxft" ,libxft) =2B ("libx11" ,libx11) =2B ,@(package-inputs lemonbar))) =2B (arguments =2B (substitute-keyword-arguments (package-arguments lemonbar) =2B ((#:make-flags make-flags) =2B `(append ,make-flags =2B (list (string-append "CFLAGS=3D" =2B (string-join =2B (list (string-append =2B "-I" (assoc-ref %build-inputs "freetype"= =29 =2B "/include/freetype2") =2B (string-append =2B "-D" "VERSION=3D" =2B (format #f "'~s'" ,version)))))))))= =29 =2B (synopsis (string-append (package-synopsis lemonbar) =2B "-- with fontconfig support")) =2B (description (string-append (package-description lemonbar) =2B " This is a fork of the @code{lemonba= =72} =2Bpackage that adds fontconfig support, for easier unicode usage."))))) =2B =20(define-public xclickroot =20 (let ((commit "309fd17174dba4149b5ea66654c6fd02cfcf7c9a") =20 (revision "1")) =2D-=20 =32.29.2 =0A= ------_=_0c2005db0cc686830c3319aa_=_--