unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: 45mg <45mg.writes@gmail.com>
To: 75091@debbugs.gnu.org
Cc: ludo@gnu.org, 45mg <45mg.writes@gmail.com>, jean-baptiste.note@m4x.org
Subject: [bug#75091] [PATCH] services: syslog: fix configuration file argument
Date: Wed, 25 Dec 2024 12:14:23 -0500	[thread overview]
Message-ID: <397cb53b5bda9e78b811a7bb385255b0fd8e13bc.1735146863.git.45mg.writes@gmail.com> (raw)
In-Reply-To: <87jzbqxc3t.fsf@m4x.org>

* gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
combined arguments which resulted in an argument like "-f
/etc/syslog.conf" being passed to syslogd, leading it to ignore the
argument and execute without a configuration file. Effects of this
included no log files being written, though the Shepherd service ran
successfully.

Ref: https://issues.guix.gnu.org/70677#4-lineno7
Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index fc604f029a..75ce4e8fe5 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1679,7 +1679,7 @@ (define (syslog-shepherd-service config)
    (start #~(make-forkexec-constructor
              (list #$(syslog-configuration-syslogd config)
                    ;; the -f option here is compatible with rsyslog
-                   #$(string-append "-f " syslog.conf)
+                   "-f" #$syslog.conf
                    #$@(syslog-configuration-extra-options config))
              #:file-creation-mask #o137
              #:pid-file "/var/run/syslog.pid"))

base-commit: 3ada4796e9adcea6fce621e639ddbfb181ab6689
-- 
2.47.1





  reply	other threads:[~2024-12-25 17:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 15:34 [bug#70677] [PATCH 0/2] Improve syslog service flexibility Jean-Baptiste Note
2024-04-30 15:36 ` [bug#70677] [PATCH 1/2] services: syslog: Add extra-options argument to syslog service Jean-Baptiste Note
2024-04-30 15:36 ` [bug#70677] [PATCH 2/2] services: syslog: Adjust service for rsyslog compatibility Jean-Baptiste Note
2024-12-23 17:13 ` bug#70677: [PATCH 0/2] Improve syslog service flexibility Ludovic Courtès
2024-12-23 22:34   ` [bug#70677] " Jean-Baptiste Note
2024-12-25 17:14     ` 45mg [this message]
2024-12-25 21:49       ` bug#75091: [PATCH] services: syslog: fix configuration file argument Ludovic Courtès
2024-12-26 11:30     ` [bug#70677] [PATCH 0/2] Improve syslog service flexibility Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=397cb53b5bda9e78b811a7bb385255b0fd8e13bc.1735146863.git.45mg.writes@gmail.com \
    --to=45mg.writes@gmail.com \
    --cc=75091@debbugs.gnu.org \
    --cc=jean-baptiste.note@m4x.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).