unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#75913] [PATCH] gnu: Add emacs-go-translate.
@ 2025-01-28 16:20 Evgeny Pisemsky
  2025-01-30 15:25 ` [bug#75913] [PATCH v1] " Cayetano Santos via Guix-patches via
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Evgeny Pisemsky @ 2025-01-28 16:20 UTC (permalink / raw)
  To: 75913
  Cc: Andrew Tropin, Divya Ranjan Pattanaik, Ian Eure,
	Katherine Cox-Buday, Liliana Marie Prikler

* gnu/packages/emacs-xyz.scm (emacs-go-translate): New variable.

Change-Id: I623079b65f6df2180537a7589b953eaeb57d6a77
---
 gnu/packages/emacs-xyz.scm | 41 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 153785e017..51fd9c01e9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,7 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew@trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d@delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli@incana.org>
-;;; Copyright © 2023 Evgeny Pisemsky <mail@pisemsky.site>
+;;; Copyright © 2023, 2025 Evgeny Pisemsky <mail@pisemsky.site>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel@erlikon.ch>
 ;;; Copyright © 2022-2023 Simon Josefsson <simon@josefsson.org>
 ;;; Copyright © 2023 Fabio Natali <me@fabionatali.com>
@@ -29151,6 +29151,45 @@ (define-public emacs-gif-screencast
 the GIF result.")
     (license license:gpl3+)))
 
+(define-public emacs-go-translate
+  (package
+    (name "emacs-go-translate")
+    (version "3.0.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/lorniu/go-translate")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0603iq1vjbm44sl7qrmkdfcqzzc703h1g5hdcswpj7pi0w7fxb4s"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:test-command #~(list "emacs" "-Q" "--batch"
+                             "-L" "."
+                             "-l" "gt-tests.el"
+                             "-f" "ert-run-tests-batch-and-exit")
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'skip-failing-tests
+                     (lambda _
+                       (substitute* "gt-tests.el"
+                         (("\\(ert-deftest test--gt-translation-life-cycle .*"
+                           all)
+                          (string-append all "(skip-unless nil)\n"))
+                         (("\\(ert-deftest test--gt-valid-literally .*"
+                           all)
+                          (string-append all "(skip-unless nil)\n"))))))))
+    (home-page "https://github.com/lorniu/go-translate")
+    (synopsis "Configurable and scalable translation framework")
+    (description
+     "This is a translation framework on Emacs, with high configurability
+and extensibility.  It can easily be extended to various Text-to-Text
+conversion scenarios.")
+    (license license:gpl3+)))
+
 (define-public emacs-google-translate
   (package
     (name "emacs-google-translate")

base-commit: 49a113e3fc618d6f6bd5000c164a1d33701a30c4
-- 
2.47.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#75913] [PATCH v1] gnu: Add emacs-go-translate.
  2025-01-28 16:20 [bug#75913] [PATCH] gnu: Add emacs-go-translate Evgeny Pisemsky
@ 2025-01-30 15:25 ` Cayetano Santos via Guix-patches via
  2025-01-30 16:18   ` Evgeny Pisemsky
  2025-01-30 16:45 ` [bug#75913] control message for bug #75913 Cayetano Santos via Guix-patches via
  2025-02-04 14:09 ` bug#75913: [PATCH] gnu: Add emacs-go-translate Sharlatan Hellseher
  2 siblings, 1 reply; 6+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2025-01-30 15:25 UTC (permalink / raw)
  To: 75913; +Cc: Evgeny Pisemsky

From: Evgeny Pisemsky <mail@pisemsky.site>

* gnu/packages/emacs-xyz.scm (emacs-go-translate): New variable.

Change-Id: I623079b65f6df2180537a7589b953eaeb57d6a77
---

This v1 fixes lint issues with long lines. If includes minor styling improvements too.

 gnu/packages/emacs-xyz.scm | 45 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 153785e017..9e0b58e944 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,7 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew@trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d@delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli@incana.org>
-;;; Copyright © 2023 Evgeny Pisemsky <mail@pisemsky.site>
+;;; Copyright © 2023, 2025 Evgeny Pisemsky <mail@pisemsky.site>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel@erlikon.ch>
 ;;; Copyright © 2022-2023 Simon Josefsson <simon@josefsson.org>
 ;;; Copyright © 2023 Fabio Natali <me@fabionatali.com>
@@ -29151,6 +29151,49 @@ (define-public emacs-gif-screencast
 the GIF result.")
     (license license:gpl3+)))
 
+(define-public emacs-go-translate
+  (package
+    (name "emacs-go-translate")
+    (version "3.0.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/lorniu/go-translate/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0603iq1vjbm44sl7qrmkdfcqzzc703h1g5hdcswpj7pi0w7fxb4s"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:test-command #~(list "emacs"
+                             "-Q"
+                             "--batch"
+                             "-L"
+                             "."
+                             "-l"
+                             "gt-tests.el"
+                             "-f"
+                             "ert-run-tests-batch-and-exit")
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'skip-failing-tests
+                     (lambda _
+                       (substitute* "gt-tests.el"
+                         (("\\(ert-deftest test--gt-translation-life-cycle .*"
+                           all)
+                          (string-append all "(skip-unless nil)\n"))
+                         (("\\(ert-deftest test--gt-valid-literally .*" all)
+                          (string-append all "(skip-unless nil)\n"))))))))
+    (home-page "https://github.com/lorniu/go-translate/")
+    (synopsis "Configurable and scalable translation framework")
+    (description
+     "This is a translation framework on Emacs, with high configurability
+and extensibility.  It can easily be extended to various Text-to-Text
+conversion scenarios.")
+    (license license:gpl3+)))
+
 (define-public emacs-google-translate
   (package
     (name "emacs-google-translate")

base-commit: b85d20e853192a92093cd8d6a5756ec80e94c658
--
2.48.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#75913] [PATCH v1] gnu: Add emacs-go-translate.
  2025-01-30 15:25 ` [bug#75913] [PATCH v1] " Cayetano Santos via Guix-patches via
@ 2025-01-30 16:18   ` Evgeny Pisemsky
  2025-01-30 16:40     ` Cayetano Santos via Guix-patches via
  0 siblings, 1 reply; 6+ messages in thread
From: Evgeny Pisemsky @ 2025-01-30 16:18 UTC (permalink / raw)
  To: Cayetano Santos; +Cc: 75913

Hi.

It looks like output of guix style, which I intentionally edited to make test-command look less ugly and make substitution lines look similar.

And I do not see any complains from guix lint with my version.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#75913] [PATCH v1] gnu: Add emacs-go-translate.
  2025-01-30 16:18   ` Evgeny Pisemsky
@ 2025-01-30 16:40     ` Cayetano Santos via Guix-patches via
  0 siblings, 0 replies; 6+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2025-01-30 16:40 UTC (permalink / raw)
  To: Evgeny Pisemsky; +Cc: 75913

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]


>jeu. 30 janv. 2025 at 19:18, Evgeny Pisemsky <mail@pisemsky.site> wrote:

> Hi.
>
> It looks like output of guix style, which I intentionally edited to make test-command look
> less ugly and make substitution lines look similar.
>
> And I do not see any complains from guix lint with my version.

You’re absolutely right, I just checked. I probably did something wrong
when I applied your patch.

My bad, sorry about that.

--
Cayetano Santos
GnuPG Key:   https://meta.sr.ht/~csantosb.pgp
FingerPrint: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#75913] control message for bug #75913
  2025-01-28 16:20 [bug#75913] [PATCH] gnu: Add emacs-go-translate Evgeny Pisemsky
  2025-01-30 15:25 ` [bug#75913] [PATCH v1] " Cayetano Santos via Guix-patches via
@ 2025-01-30 16:45 ` Cayetano Santos via Guix-patches via
  2025-02-04 14:09 ` bug#75913: [PATCH] gnu: Add emacs-go-translate Sharlatan Hellseher
  2 siblings, 0 replies; 6+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2025-01-30 16:45 UTC (permalink / raw)
  To: control
  Cc: mail, ian, 75913, cox.katherine.e+guix, liliana.prikler, andrew,
	divya

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]


user guix
usertag 75913 + reviewed-looks-good
thanks

QA review:

- Commit messages
- Package builds
- Lint warnings
- Package tests
- Package style
- List dependent packages build

- New package licenses
- New package tests
- New package synopsis and descriptions

--
Cayetano Santos
GnuPG Key:   https://meta.sr.ht/~csantosb.pgp
FingerPrint: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#75913: [PATCH] gnu: Add emacs-go-translate.
  2025-01-28 16:20 [bug#75913] [PATCH] gnu: Add emacs-go-translate Evgeny Pisemsky
  2025-01-30 15:25 ` [bug#75913] [PATCH v1] " Cayetano Santos via Guix-patches via
  2025-01-30 16:45 ` [bug#75913] control message for bug #75913 Cayetano Santos via Guix-patches via
@ 2025-02-04 14:09 ` Sharlatan Hellseher
  2 siblings, 0 replies; 6+ messages in thread
From: Sharlatan Hellseher @ 2025-02-04 14:09 UTC (permalink / raw)
  To: 75913-done

[-- Attachment #1: Type: text/plain, Size: 86 bytes --]


Hi,

Pushed to master as

7e58d45adf7 * master gnu: Add emacs-go-translate.

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-02-04 14:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-28 16:20 [bug#75913] [PATCH] gnu: Add emacs-go-translate Evgeny Pisemsky
2025-01-30 15:25 ` [bug#75913] [PATCH v1] " Cayetano Santos via Guix-patches via
2025-01-30 16:18   ` Evgeny Pisemsky
2025-01-30 16:40     ` Cayetano Santos via Guix-patches via
2025-01-30 16:45 ` [bug#75913] control message for bug #75913 Cayetano Santos via Guix-patches via
2025-02-04 14:09 ` bug#75913: [PATCH] gnu: Add emacs-go-translate Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).