From: Maxime Devos <maximedevos@telenet.be>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>,
Brian Kubisiak <brian@kubisiak.com>,
54618@debbugs.gnu.org
Subject: [bug#54618] [PATCH] gnu: lbzip2: Fix cross-compilation.
Date: Tue, 29 Mar 2022 11:05:40 +0200 [thread overview]
Message-ID: <38042d6a6141d9ba6b0394ef457a086c15015986.camel@telenet.be> (raw)
In-Reply-To: <b91791f5caf8be939d7e41a1dc9bbaec52d1fdce.camel@ist.tugraz.at>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
Liliana Marie Prikler schreef op di 29-03-2022 om 08:07 [+0200]:
> + (lambda* (#:key inputs native-inputs #:allow-other-
> keys)
> + (let ((gnulib (assoc-ref (or native-inputs inputs)
> "gnulib")))
> (copy-recursively gnulib "lib")
> (setenv "PATH" (string-append "lib:" (getenv
> "PATH")))
> #t)))
Note that referring to inputs by name is discouraged. In this case, the
gnulib origin should be inlined (see ppsspp or gnome-recipes for
examples on how that is done). I don't think there is a native vs.
non-native distinction for origins, but if there is, simply use #+
instead of #$.
I would go with
(let ((gnulib (dirname (search-input-file (or native-inputs inputs) "gnulib-tool.py"))))
[...]).
That way, no input labels are used yet package transformations are
still possible:
(package (inherit lbzip2) (native-inputs [some inputs with a different gnulib]))
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-03-29 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:36 [bug#54618] [PATCH] gnu: lbzip2: Fix cross-compilation Brian Kubisiak
2022-03-29 6:07 ` Liliana Marie Prikler
2022-03-29 9:05 ` Maxime Devos [this message]
2022-03-30 1:45 ` [bug#54618] [PATCH v2] " Brian Kubisiak
2022-03-30 10:39 ` bug#54618: [PATCH] " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38042d6a6141d9ba6b0394ef457a086c15015986.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54618@debbugs.gnu.org \
--cc=brian@kubisiak.com \
--cc=liliana.prikler@ist.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).