From: Maxime Devos <maximedevos@telenet.be>
To: Trev <trev@trevdev.ca>, 57757@debbugs.gnu.org
Subject: [bug#57757] [PATCH] gnu: Add sbcl-stumpwm-pamixer
Date: Mon, 19 Sep 2022 20:33:53 +0200 [thread overview]
Message-ID: <37a6bd56-c9d9-f269-0df6-3eaec651a871@telenet.be> (raw)
In-Reply-To: <87h713jkbn.fsf@codinator.mail-host-address-is-not-set>
[-- Attachment #1.1.1: Type: text/plain, Size: 2337 bytes --]
On 19-09-2022 20:22, Trev wrote:
> Maxime Devos <maximedevos@telenet.be> writes:
>
>> On 19-09-2022 19:47, Trevor Richards wrote:
>>> + (arguments
>>> + `(#:asd-systems '(:pamixer)
>>> + #:phases
>>> + ,#~(modify-phases %standard-phases
>>> + (add-after 'unpack 'patch-pamixer
>>> + (lambda _
>>> + (substitute* "pamixer.lisp"
>>> + (("\"pamixer \"")
>>> + (string-append
>>> + "\"" #$pamixer "/bin/pamixer \""))))))))
>>
>> To support --with-input transformations, you can't do #$input, you have
>> to do #$(this-package-input "pamixer") instead -- or better, don't
>> depend on input labels, by using (search-input-file inputs
>> "bin/pamixer") instead.
>>
>
> Thanks for the feedback. It's hard to tell when a gexp is appropriate
> and where it's not, or how to properly evaluate it all at the right
> time. The current patch builds. Is this problematic in the sense that
> it's using some reference to #$pamixer that is not actually a part of
> the build environment?
It is inappropriate in the sense that '--with-input' rewrites the
'inputs', 'native-inputs' and 'propagated-inputs' fields, but not the
contents of the G-exp.
> Note I had to use a quasiqote and unquote for the `gexp` to work.
> Transforming the arguments into a list so I would not have to do this
> breaks the #:asd-systems keyword value somehow.
How about:
(arguments
(list #:asd-systems ''(:pa-mixers)
#:phases
#~(modify-phases [...])))
(i.e., you are removing a layer of quoting by turning the quasiquote
into a quote, so it needs to be readded for the #:asd-systems).
>
> When I observe the source code it's kinda all over the place when it
> comes to using gexps in some way or when not to.
>
> I will patch this again and document a note about this but if there's
> any clarifying documentation I would happily read it. Apologies in
> advance if I have missed existing documentation.
I'm not aware of any, though I'd like to note that G-exps are new-ish
and hence the 'all over the place' is more "guix style doesn't know how
to transform this kind of old thing yet" than "we chose for s-exps
instead of G-exps".
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-19 18:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 21:41 [bug#57757] [PATCH] * gnu/packages/wm.scm: Add sbcl-stumpwm-pamixer Trevor Richards
2022-09-12 21:41 ` [bug#57757] [PATCH] gnu: " Trevor Richards
2022-09-16 7:50 ` Guillaume Le Vaillant
2022-09-12 21:41 ` Trevor Richards
2022-09-16 9:07 ` [bug#57757] [PATCH] * gnu/packages/wm.scm: " Maxime Devos
2022-09-19 14:31 ` Trev
2022-09-19 16:17 ` Maxime Devos
2022-09-19 17:29 ` Trev
2022-09-19 17:47 ` [bug#57757] [PATCH] gnu: " Trevor Richards
2022-09-19 18:05 ` Maxime Devos
2022-09-19 18:22 ` Trev
2022-09-19 18:33 ` Maxime Devos [this message]
2022-09-19 21:34 ` Trev
2022-09-20 4:38 ` Trevor Richards
2022-09-20 7:17 ` bug#57757: " Guillaume Le Vaillant
2022-09-22 19:08 ` [bug#57757] " Maxime Devos
2022-09-22 20:35 ` Trev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a6bd56-c9d9-f269-0df6-3eaec651a871@telenet.be \
--to=maximedevos@telenet.be \
--cc=57757@debbugs.gnu.org \
--cc=trev@trevdev.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).