From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:36788)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMaSV-00018q-12
 for guix-patches@gnu.org; Mon, 21 Oct 2019 12:23:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMaST-00007t-VS
 for guix-patches@gnu.org; Mon, 21 Oct 2019 12:23:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48885)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iMaST-00007o-Sr
 for guix-patches@gnu.org; Mon, 21 Oct 2019 12:23:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMaST-0006jM-Nh
 for guix-patches@gnu.org; Mon, 21 Oct 2019 12:23:01 -0400
Subject: [bug#37693] Seahorse build
Resent-Message-ID: <handler.37693.B37693.157167494025807@debbugs.gnu.org>
Message-ID: <370f09c854fac2a4d2861c6f2461a8fffdec5f9a.camel@student.tugraz.at>
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Mon, 21 Oct 2019 18:22:16 +0200
In-Reply-To: <20191021172512.2f21d05f@gmail.com>
References: <20191021172512.2f21d05f@gmail.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Miguel Arruga Vivas <rosen644835@gmail.com>, 37693@debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>

Am Montag, den 21.10.2019, 17:25 +0200 schrieb Miguel Arruga Vivas:
> > > >      (inputs
> > > > -     `(("gtk+" ,gtk+)
> > > > +     `(("avahi" ,avahi)
> > > > +       ("gtk+" ,gtk+)
> > > >         ("gcr" ,gcr)
> > > >         ("gnupg" ,gnupg)
> > > >         ("gpgme" ,gpgme)
> > > > @@ -2244,8 +2248,10 @@ engineering.")
> > > >      (native-inputs
> > > >       `(("intltool" ,intltool)
> > > >         ("glib:bin" ,glib "bin")
> > > > +       ("gtk+:bin" ,gtk+ "bin")
> > > >         ("itstool" ,itstool)
> > > >         ("pkg-config" ,pkg-config)
> > > > +       ("vala" ,vala)
> > > 
> > > Likewise, these changes were necessary, right?
> > 
> > Indeed. After changing the build system, I've repeatedly run "guix
> > build seahorse" and added the inputs that the build system
> > complained
> > about until the build succeeded. ("gtk+:bin" is necessary due to
> > the
> > icon cache IIRC).
> 
> I've solved this modifying the %standard-phases, as in other packages
> from gnome.
I'm not sure, whether that is the right approach. Seahorse used glib-
or-gtk-build-system before, so I would assume the generation of those
caches is expected.

> I don't have the last one because it is fixed with 3.30.1.1.  Also, I
> have an extra python that could be a leftover.
Would you mind checking, whether your patch works with gtk+:bin added
and without python? If so, I'd find it preferable to mine.

Regards,

Leo