[bug#38931] gnu: Add gnome-music.

[bug#38931] gnu: Add gnome-music.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

Hello Guix!

Please find the attached patch to add gnome-music.

NOTE: This patch depends on the patch #38930.

Thank you!

Regards,
RG.

[-- Attachment #2: gnome-music.patch --]
[-- Type: application/octet-stream, Size: 2331 bytes --]

From 8f9f3412309e17392708bcf37439ea4d940c2412 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 4 Jan 2020 18:38:19 -0500
Subject: [PATCH] gnu : Add gnome-music.

* gnu/packages/gnome.scm (gnome-music): New variable.
---
 gnu/packages/gnome.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c88e96f0b5..0c3ea5bf57 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -291,6 +291,47 @@ features to enable users to create their discs easily and quickly.")
 for application developers.")
     (license license:lgpl2.1+)))
 
+(define-public gnome-music
+  (package
+   (name "gnome-music")
+   (version "3.34.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "19d28ndk3i6b5dqgfv7jr2cpk86vxh0mx1xzagb43xpxaaq02jdr"))))
+   (build-system meson-build-system)
+   (native-inputs
+    `(("glib:bin" ,glib "bin")
+      ("itstools" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("gettext" ,gettext-minimal)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
+      ("gobject-introspection" ,gobject-introspection)
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gtk+:bin" ,gtk+ "bin")
+      ("gvfs" ,gvfs)
+      ("libdazzle" ,libdazzle)
+      ("libmediaart" ,libmediaart)
+      ("libsoup" ,libsoup)
+      ("pycairo" ,python-pycairo)
+      ("pygobject" ,python-pygobject-3.34)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Simple music player for GNOME desktop")
+   (description "GNOME Music is the new GNOME music playing application
+that aims to combine an elegant and immersive browsing experience
+with simple and straightforward controls.")
+   (home-page "https://wiki.gnome.org/Apps/Music")
+   (license license:gpl2)))
+
 (define-public gnome-user-share
   (package
    (name "gnome-user-share")
-- 
2.24.1

[bug#38931] gnu: Add gnome-music.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

Please make the things which are only required for the build and not required
runtime native-inputs.

Is the license gpl2 only?

How are grilo-plugins searched for?

Why is pycairo and pygobject in the "input" list?  Does the feature that
requires those work?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38931] gnu: Add gnome-music.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hello Danny!

> Please make the things which are only required for the build and not required
> runtime native-inputs.

Yes, please find the attached revised patch.

> Is the license gpl2 only?

It is gpl2+. Please find the attached revised patch.

> How are grilo-plugins searched for?

Not sure. :/

> Why is pycairo and pygobject in the "input" list?

I do not know exactly why, but some parts of the application are (re)written in python.

Regards,
RG.

[-- Attachment #2: gnome-music.patch --]
[-- Type: application/octet-stream, Size: 2362 bytes --]

From 05f4975ecda004c96a5cfa7aa85ef1c6bfef412c Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 14 Jan 2020 18:08:27 -0500
Subject: [PATCH] gnu: Add gnome-music.

* gnu/packages/gnome.scm (gnome-music): New variable.
---
 gnu/packages/gnome.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9b63f555e1..0e41faa458 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,47 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-music
+  (package
+   (name "gnome-music")
+   (version "3.34.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "19d28ndk3i6b5dqgfv7jr2cpk86vxh0mx1xzagb43xpxaaq02jdr"))))
+   (build-system meson-build-system)
+   (native-inputs
+    `(("desktop-file-utils" ,desktop-file-utils)
+      ("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
+      ("gtk+:bin" ,gtk+ "bin")
+      ("itstools" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gvfs" ,gvfs)
+      ("libdazzle" ,libdazzle)
+      ("libmediaart" ,libmediaart)
+      ("libsoup" ,libsoup)
+      ("pycairo" ,python-pycairo)
+      ("pygobject" ,python-pygobject-3.34)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Simple music player for GNOME desktop")
+   (description "GNOME Music is the new GNOME music playing application
+that aims to combine an elegant and immersive browsing experience
+with simple and straightforward controls.")
+   (home-page "https://wiki.gnome.org/Apps/Music")
+   (license license:gpl2+)))
+
 (define-public gnome-boxes
   (package
    (name "gnome-boxes")
-- 
2.24.1

[bug#38931] gnu: Add gnome-music.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hello Danny!

> Please make the things which are only required for the build and not required
> runtime native-inputs.

Yes, please find the attached revised patch.

> Is the license gpl2 only?

It is gpl2+. Please find the attached revised patch.

> How are grilo-plugins searched for?

Not sure. :/

> Why is pycairo and pygobject in the "input" list?

I do not know exactly why, but some parts of the application are (re)written in python.

Regards,
RG.

[-- Attachment #2: gnome-music.patch --]
[-- Type: application/octet-stream, Size: 2362 bytes --]

From 05f4975ecda004c96a5cfa7aa85ef1c6bfef412c Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 14 Jan 2020 18:08:27 -0500
Subject: [PATCH] gnu: Add gnome-music.

* gnu/packages/gnome.scm (gnome-music): New variable.
---
 gnu/packages/gnome.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9b63f555e1..0e41faa458 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,47 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-music
+  (package
+   (name "gnome-music")
+   (version "3.34.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "19d28ndk3i6b5dqgfv7jr2cpk86vxh0mx1xzagb43xpxaaq02jdr"))))
+   (build-system meson-build-system)
+   (native-inputs
+    `(("desktop-file-utils" ,desktop-file-utils)
+      ("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
+      ("gtk+:bin" ,gtk+ "bin")
+      ("itstools" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gvfs" ,gvfs)
+      ("libdazzle" ,libdazzle)
+      ("libmediaart" ,libmediaart)
+      ("libsoup" ,libsoup)
+      ("pycairo" ,python-pycairo)
+      ("pygobject" ,python-pygobject-3.34)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Simple music player for GNOME desktop")
+   (description "GNOME Music is the new GNOME music playing application
+that aims to combine an elegant and immersive browsing experience
+with simple and straightforward controls.")
+   (home-page "https://wiki.gnome.org/Apps/Music")
+   (license license:gpl2+)))
+
 (define-public gnome-boxes
   (package
    (name "gnome-boxes")
-- 
2.24.1

[bug#38931] gnu: Add gnome-music.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

Hi,

I tried this patch but it does not work for me outside GNOME, in an
empty environment.

I added gsettings-desktop-schemas and the following arguments

--8<---------------cut here---------------start------------->8---
(arguments
    `(#:phases
      (modify-phases %standard-phases
        (add-after 'install 'wrap
          (lambda* (#:key outputs #:allow-other-keys)
            (let ((out (assoc-ref outputs "out")))
              (wrap-program (string-append out "/bin/gnome-music")
                `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")
                                           ,(string-append out "/lib/python"
                                                           "3.7"
                                                           ;; TODO: How do we get  version-major+minor?
                                                           ;; (version-major+minor
                                                           ;;  (package-version python))
                                                           "/site-packages")))
                `("GI_TYPELIB_PATH" ":" prefix (,(getenv "GI_TYPELIB_PATH")))
                `("GRL_PLUGIN_PATH"        ":" prefix (,(getenv "GRL_PLUGIN_PATH")))))
            #t)))))
--8<---------------cut here---------------end--------------->8---

But it still fails to start with


--8<---------------cut here---------------start------------->8---
> /gnu/store/j3ja6m8sarvpki7pxzaxfc4r85bkmlzy-gnome-music-3.34.2/bin/gnome-music 
removed, grl-bookmarks
removed, grl-metadata-store
removed, grl-filesystem
removed, grl-podcasts

(org.gnome.Music:29122): GLib-GIO-ERROR **: 20:59:08.968: Settings schema 'org.gnome.Music' is not installed
trace/breakpoint trap
--8<---------------cut here---------------end--------------->8---

Any idea?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38931] gnu: Add gnome-music.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]


Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Hi,
>
> I tried this patch but it does not work for me outside GNOME, in an
> empty environment.
>
> I added gsettings-desktop-schemas and the following arguments
>
> --8<---------------cut here---------------start------------->8---
> (arguments
>     `(#:phases
>       (modify-phases %standard-phases
>         (add-after 'install 'wrap
>           (lambda* (#:key outputs #:allow-other-keys)
>             (let ((out (assoc-ref outputs "out")))
>               (wrap-program (string-append out "/bin/gnome-music")
>                 `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")
>                                            ,(string-append out "/lib/python"
>                                                            "3.7"
>                                                            ;; TODO: How do we get  version-major+minor?
>                                                            ;; (version-major+minor
>                                                            ;;  (package-version python))
>                                                            "/site-packages")))
>                 `("GI_TYPELIB_PATH" ":" prefix (,(getenv "GI_TYPELIB_PATH")))
>                 `("GRL_PLUGIN_PATH"        ":" prefix (,(getenv "GRL_PLUGIN_PATH")))))
>             #t)))))
> --8<---------------cut here---------------end--------------->8---
>
> But it still fails to start with
>
>
> --8<---------------cut here---------------start------------->8---
>> /gnu/store/j3ja6m8sarvpki7pxzaxfc4r85bkmlzy-gnome-music-3.34.2/bin/gnome-music
> removed, grl-bookmarks
> removed, grl-metadata-store
> removed, grl-filesystem
> removed, grl-podcasts
>
> (org.gnome.Music:29122): GLib-GIO-ERROR **: 20:59:08.968: Settings schema 'org.gnome.Music' is not installed
> trace/breakpoint trap
> --8<---------------cut here---------------end--------------->8---
>
> Any idea?

I think the output for the gnome-music package should also be included
in the GI_TYPELIB_PATH.

I think this is the meson build system, which I think accepts
#:glib-or-gtk? #t as an argument. Try adding that, you might be able to
remove some of the wrapping you added above then.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

[bug#38931] gnu: Add gnome-music.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

Thanks, Chris, this was a good tip.
I've made some progress.

With the following arguments (no need for a gsettings-desktop-schemas
input anymore):

--8<---------------cut here---------------start------------->8---
(arguments
    `(#:glib-or-gtk? #t
      #:phases
      (modify-phases %standard-phases
        (add-after 'install 'wrap
          (lambda* (#:key outputs #:allow-other-keys)
            (let ((out (assoc-ref outputs "out")))
              (wrap-program (string-append out "/bin/gnome-music")
                `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")
                                           ,(string-append out "/lib/python"
                                                           ,(version-major+minor
                                                             (package-version python))
                                                           "/site-packages")))
                `("GI_TYPELIB_PATH" ":" prefix (,(getenv "GI_TYPELIB_PATH")))
                `("GRL_PLUGIN_PATH" ":" prefix (,(getenv "GRL_PLUGIN_PATH")))))
            #t)))))
--8<---------------cut here---------------end--------------->8---

gnome-music starts.

Sadly it displays

"GNOME Music could not connect to Tracker"

Tracker is part of the inputs but I guess that's not enough.
I tried installing gnome-music to my default profile, then run it from a
GNOME session, to no avail.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38931] gnu: Add gnome-music.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

And the shell output is

--8<---------------cut here---------------start------------->8---
> /gnu/store/8vv88vlax0cc7mz36ivz2v5y4z8wk054-gnome-music-3.34.2/bin/gnome-music 
removed, grl-bookmarks
removed, grl-metadata-store
removed, grl-filesystem
removed, grl-podcasts
11:22:24 WARNING	Error: tracker-sparql-error-quark, Failed to load SPARQL backend: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Tracker1 was not provided by any .service files

(org.gnome.Music:12866): Grilo-WARNING **: 11:22:24.975: [dleyna] ../grilo-plugins-0.3.10/src/dleyna/grl-dleyna-servers-manager.c:138: Unable to fetch the list of available servers: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name com.intel.dleyna-server was not provided by any .service files
--8<---------------cut here---------------end--------------->8---

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38931] gnu: Add gnome-music.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

I've managed to get rid of the segfault and start gnome-music by setting

       #:configure-flags '("-Denable-lua-factory=no" "-Denable-dleyna=no")

in grilo-plugins.
Looks like dleyna is segfaulting for us.

Now gnome-music show a window with a logo and the text

"Hey Dj
The contents of your Music folder will appear here."

then nothing happens.  I've never used GNOME Music before so I'm not
sure what to expect.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38931] gnu: Add gnome-music.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

gnome-music has been merged on master.
Can this be closed?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#38931: gnu: Add gnome-music.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

On Sat, Aug 22, 2020 at 12:34:47PM +0200, Pierre Neidhardt wrote:
> gnome-music has been merged on master.
> Can this be closed?

Closed

> 
> -- 
> Pierre Neidhardt
> https://ambrevar.xyz/



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]