From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aGUyDypIN2GyDAEAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 13:08:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aEMmCypIN2FNUgAA1q6Kng (envelope-from ) for ; Tue, 07 Sep 2021 11:08:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D85D82A5BF for ; Tue, 7 Sep 2021 13:08:25 +0200 (CEST) Received: from localhost ([::1]:39756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNYxl-0001jp-17 for larch@yhetil.org; Tue, 07 Sep 2021 07:08:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNYwR-0008Fi-5Y for guix-patches@gnu.org; Tue, 07 Sep 2021 07:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNYwQ-0007i5-T7 for guix-patches@gnu.org; Tue, 07 Sep 2021 07:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNYwQ-0005vt-J0 for guix-patches@gnu.org; Tue, 07 Sep 2021 07:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49868 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard , 49868@debbugs.gnu.org Received: via spool by 49868-submit@debbugs.gnu.org id=B49868.163101279422772 (code B ref 49868); Tue, 07 Sep 2021 11:07:02 +0000 Received: (at 49868) by debbugs.gnu.org; 7 Sep 2021 11:06:34 +0000 Received: from localhost ([127.0.0.1]:55470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNYvy-0005vE-GQ for submit@debbugs.gnu.org; Tue, 07 Sep 2021 07:06:34 -0400 Received: from lepiller.eu ([89.234.186.109]:57484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNYvv-0005v1-JN for 49868@debbugs.gnu.org; Tue, 07 Sep 2021 07:06:32 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 01890a7b; Tue, 7 Sep 2021 11:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=g5bi7j3hUdVN ++EXqL44DJkushVVzsKGgjvX6BCuPpA=; b=gsNiY4RqSANNT8mHmlAE2PHfueyL 4M8FtAXo/L3uDRC2VbFSIlInkiC8pFGzD2Erj6L73lwjUWuYD1D0vnx9R8/NC4dX oDohPg8vxiOJ37Co2KeFutSGZcz8ITNwqSFNXuuRBoq6rPo0tV39YLyHm0UrTyG4 bRxTkdjee8aCQJKxXGjNexig0jl/xt/PetJ9bxIH60VlmkKF8UqRAVqGZMFID38J lsLoXcWc5M3cxWe75r8w1IPlnkklwqAwOudJrSXEN15qY6qh3ZOs8Litu7oyFUJS 7yFBRxc5bQIcurN1cwONnY14n60d7epQqOTx8pMNVIByvTpn1qOVLepyVA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 94ead31d (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 7 Sep 2021 11:06:28 +0000 (UTC) Date: Tue, 07 Sep 2021 07:06:20 -0400 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <86y288yavn.fsf@posteo.net> References: <20210804080423.3533-1-pukkamustard@posteo.net> <20210821000926.00deacf3@tachikoma.lepiller.eu> <868s0r72rb.fsf@posteo.net> <865yvv71sw.fsf@posteo.net> <86zgt75lhe.fsf@posteo.net> <86y288yavn.fsf@posteo.net> Message-ID: <36A316B4-720C-4753-AFFC-DBC68DBE5EF4@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----X3X72SSCPY93DG2OUK7EV6ZJWXEES3 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631012906; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sjgWoc14xEMiZG5fYQe6syJk2DJqYe77o6DQYxCsiu0=; b=M4IkZi842XOnufyNuZ4QK/7/Bk/TgfmNFYptruizY9vaw1z4nqEDX9kZUTUBb/puf4Trqx iwxHza3fo/hQXs0PO5Ah3+9FcGr8gf8JkQTMRMaBTiwTHnMokm5g12bA8IO3Sm34TKbi2G RUsMo+z4/2R5P5QjSAu59e9eGSWmcd8/N3gflikIFumi5Oy06cEp8tontb0mxvdDjsiEEL YRvy2BP8cNGClRbAHMxaZCklrkbiN0n4sHvX480FL+5WixudsaW+lypAzs20BNTnNmmZaq H7BkEFQyq7gfD1zWWHDOGFqDf1YNf0JFib972m/T5PRViDFfqdDGo9QDcbgl8w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631012906; a=rsa-sha256; cv=none; b=A74hsdX4cnEao7FeRMPRA+8+UdiUXtKjtAtlrlq2IAC2WK5BvmwJJjHuVCXsht24sRjDFW ODIo1p6f0qO8ebvkt7FTDNUHWBnEq44fbV4IKNPbJTOw70qcKgj8TFYUP2N2IVUxpolSSM 1P504sWUn8btqUJXYeqmFSjR8T9uguE/7wcFpnZhCXRchbVRrTEpZwedo7hoQbubihuSm/ yiw9amAtUSL/pSHXYEBowplUaDF3qVYT8vjNjuRCDmPNozqJ2PM9dTUFowoCcxZhXaWPuC WjfQZTO4DJEBQi6roSlOR08EXGCkUr2e1hQTLwtmi2hFEtMTkO+uDsQv4ArjrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=gsNiY4Rq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=gsNiY4Rq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D85D82A5BF X-Spam-Score: 0.19 X-Migadu-Scanner: scn1.migadu.com X-TUID: ULfD5tKkZ4WS ------X3X72SSCPY93DG2OUK7EV6ZJWXEES3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Instead of reverting, coull you senl a patch on top of master, that simply = replaces the flag? Le 7 septembre 2021 05:33:39 GMT-04:00, pukkamustard a =C3=A9crit=C2=A0: > >I suggest reverting commit 33a1ec29fa0ad72c61cef13c8af08c847eb399c1 >('guix: dune-build-system: Add a profile parameter=2E') and instead >applying attached patch=2E > >The attached patch sets the '--release' flag instead of '--profile >release'=2E From 'dune --help': > >--8<---------------cut here---------------start------------->8--- >--release > Put dune into a reproducible release mode=2E This is in fact a > shorthand for --root =2E --ignore-promoted-rules --no-config > --profile release --always-show-command-line > --promote-install-files --default-target @install=2E You should use > this option for release builds=2E For instance, you must use this > option in your =2Eopam files=2E Except if you already use -p, > as -p implies this option=2E >--8<---------------cut here---------------end--------------->8--- > >I think this is what we want=2E > >Setting '--profile release' was not enough and was causing >inconsistencies with packages that were building with the '-p' flag=2E > >-pukkamustard > ------X3X72SSCPY93DG2OUK7EV6ZJWXEES3 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Instead of reverting, coull you senl a patch on to= p of master, that simply replaces the flag?

Le 7 septembre 2021 05:33:39 GMT-04:00, pukkamustard <pukkamustard@po= steo=2Enet> a =C3=A9crit=C2=A0:

I suggest reverting commit 33a1ec29=
fa0ad72c61cef13c8af08c847eb399c1
('guix: dune-build-system: Add a profil=
e parameter=2E') and instead
applying attached patch=2E

The attac=
hed patch sets the '--release' flag instead of '--profile
release'=2E Fr=
om 'dune --help':

--8<---------------cut here---------------start=
------------->8---
--release
   Put dune into a reproducible relea=
se mode=2E This is in fact a
   shorthand for --root =2E --ignore-promot=
ed-rules --no-config
   --profile release --always-show-command-line
=
   --promote-install-files --default-target @install=2E You should use
 =
  this option for release builds=2E For instance, you must use this
   o=
ption in your <package>=2Eopam files=2E Except if you already use -p,=

   as -p implies this option=2E
--8<---------------cut here------=
---------end--------------->8---

I think this is what we want=2E<=
br>
Setting '--profile release' was not enough and was causing
incons=
istencies with packages that were building with the '-p' flag=2E

-pu=
kkamustard

------X3X72SSCPY93DG2OUK7EV6ZJWXEES3--