From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmbEn-0002k8-IU for guix-patches@gnu.org; Tue, 29 Aug 2017 03:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmbEk-0002Ss-EJ for guix-patches@gnu.org; Tue, 29 Aug 2017 03:47:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51408) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmbEk-0002Sj-A4 for guix-patches@gnu.org; Tue, 29 Aug 2017 03:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dmbEk-0004Ek-2y for guix-patches@gnu.org; Tue, 29 Aug 2017 03:47:02 -0400 Subject: [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful. Resent-Message-ID: Message-Id: <35f7643a.AEQAPOKjjUYAAAAAAAAAAAPmDT8AAAACwQwAAAAAAAW9WABZpRvb@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Tue, 29 Aug 2017 13:16:27 +0530 In-reply-to: References: <20170822171303.21754-1-mail@cbaines.net> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jelle Licht Cc: 28185@debbugs.gnu.org Jelle Licht writes: > 2017-08-29 8:25 GMT+02:00 Arun Isaac : > >> >> Christopher Baines writes: >> >> Modify the install phase to detect when nothing has been installed, >> and error if this happens. This is preferable to continuing, and >> allowing the next phase to fail. >> >> Also, when nothing can be found to be installed, print out each >> file that was considered, along with the regular expressions that >> were used to include and exclude it. >> > >> > * gnu/build/emacs-build-system.scm (install-file?): Add additional err= or >> > checking and logging. >> > --- >> > guix/build/emacs-build-system.scm | 45 ++++++++++++++++++++++++++++-- >> --------- >> > 1 file changed, 32 insertions(+), 13 deletions(-) >> >> I feel that this adds a lot of complexity (lines of code) to the >> emacs-build-system checking for an error that can be quite easily >> identified and fixed otherwise. >> >> WDYT? Maybe, others can comment on this as well. >> > One the one hand, I agree with Arun, though errors in Guix can be a bit > intimidating for newcomers. > Do we want to focus on clear and correct error messages over concise code= ? It's a design choice, and I am unable to make up my mind. I think somebody with more experience than me should take a call. Let's ask Ludo. CCing him... =