From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id EHbELTkPWmYuPgAAA41jLg (envelope-from ) for ; Fri, 31 May 2024 19:56:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 6OxpKjkPWmZ1XwAA62LTzQ (envelope-from ) for ; Fri, 31 May 2024 19:56:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=eFRGfN71; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717178169; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=t48tLq47dJwmJxzjMUlAw2IoNuN706RghVP11ZNIWfI=; b=qMNC2G/Toll3FneQg8ezHNwf6r4yhyZt2rzXIRtcIGuYUIbjEqhamPp/Z4jz3kZMcKuccs hTY7LrgeVarDx41W9QAl8kdvBcAUudzHbQZZsupJfS76/jbFgf/JFBBfuh2mKLRQMFqQQI m/09/9A7tFRBUl8vm33BR88oIw0lytuGzmTN/282QtB6ZC5vUnh1QhdyfD/XWkrWJv2s6+ p/DGTLElLvB+1ad4T/GFv3vWd/sLZYM/WWKz5c2TVLShAze3HJwejKL8RtVcTPWPhVE+iK 87mK6M5bTPOi7JdrE5zT0RKWnzOnyFUDkJ2Bj3om4zwXizxTUkv0b5TmiGQWjw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=eFRGfN71; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717178169; a=rsa-sha256; cv=none; b=di/tginKUgXjGuGVnU/GS9e01qJWe+XWND8HHjq0uYVksGL35Q+jJcZy6VsqTHVp8Kzuzu 63r+XhCF+vDEdfd1BVJiJTn4h1qTjb5Cz26npnR6qnbGVvXnc2fzE/62dMBKaz0eV0spNR wooUE+kdHiqPyGcjeiS5ZL5XLPGozDKy9ySGS3N5XKx6y+wrjIGlaYJUJRzBXUkclFmpUI I5YW0whGrSzeOtOfHEp5KyHUmW6SYrPolo1GKsrcFcmJPU6p2zAXmaJSYkxnwJ4Eo+9paP Da0gI+RR6VEG9ePIDO6EWBtGlsRYJfS6rw3YeAGNzRzljDeErNkwsF3JAHntWw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 731C16B418 for ; Fri, 31 May 2024 19:56:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sD6Tp-00008B-HZ; Fri, 31 May 2024 13:55:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sD6Tn-000081-Fb for guix-patches@gnu.org; Fri, 31 May 2024 13:55:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sD6Tn-000158-6f for guix-patches@gnu.org; Fri, 31 May 2024 13:55:51 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sD6Tx-0003Ds-TD for guix-patches@gnu.org; Fri, 31 May 2024 13:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Resent-From: Sughosha Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 31 May 2024 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71109 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 71109@debbugs.gnu.org, Kaelyn Received: via spool by 71109-submit@debbugs.gnu.org id=B71109.171717811412329 (code B ref 71109); Fri, 31 May 2024 17:56:01 +0000 Received: (at 71109) by debbugs.gnu.org; 31 May 2024 17:55:14 +0000 Received: from localhost ([127.0.0.1]:55304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD6TC-0003Cm-7H for submit@debbugs.gnu.org; Fri, 31 May 2024 13:55:14 -0400 Received: from layka.disroot.org ([178.21.23.139]:35886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD6T7-0003CZ-JD for 71109@debbugs.gnu.org; Fri, 31 May 2024 13:55:12 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6F9884185A; Fri, 31 May 2024 19:54:56 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tqUQ-LzBC-fW; Fri, 31 May 2024 19:54:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1717178095; bh=Ju79pTOzNYBZJ0+mu88idBXntZ5V6I4WvQQOzMeCR0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eFRGfN71MMSdUsV58T823hcZmGVew4G2jUXL4lLq3FRfj3rnkgTMOaHZAuvbY7eqc 9mqOzGI8YjOkS9+xanQvOLNQlMzVB+jhn2HLVQ4OMCR4qwneDwfWxQsEqEJ/EKMX1J ZPgLcAo/nfCaBKCJA7V/Yam36+W5+Xmi6NgL/GvLdNLD6WvECitmkbp/Un7Qklb8jb FMXL5U93BuX2E5fmDp38dAbE3oTSIjm8gS41zjI7rwLxgW1Rnb1LCbA6B8mspLB51g i5P6414OQzz1eapa7ljdpbQVAYwKy+PPxixlfkJbtd2wbJzPDn4JLx+uC0KeLf/zap 3Zq/A0ORa1Nbw== Date: Fri, 31 May 2024 20:51:44 +0530 Message-ID: <3564606.iIbC2pHGDl@localhost.localdomain> In-Reply-To: <87y17qtgea.fsf@gnu.org> References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> <87y17qtgea.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Sughosha X-ACL-Warn: , Sughosha via Guix-patches From: Sughosha via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.85 X-Spam-Score: -6.85 X-Migadu-Queue-Id: 731C16B418 X-Migadu-Scanner: mx13.migadu.com X-TUID: qrGkwx4tGsoY On Friday, May 31, 2024 4:08:53 PM IST Ludovic Court=C3=A8s wrote: > Hi, >=20 > Sughosha skribis: > > This fixes not finding vulkan-loader. >=20 > Could you show how to test it? >=20 > > + (wrap-program file > > + `("LD_LIBRARY_PATH" ":" =3D > > + (,(getenv "LIBRARY_PATH"))))) >=20 > This is probably a bit too broad because LIBRARY_PATH includes > build-time-only dependencies (python, gawk, binutils, bzip2, etc.). >=20 > Could we explicitly list what needs to be there instead? >=20 > Also maybe change =E2=80=98=3D=E2=80=99 to =E2=80=98suffix=E2=80=99 so us= ers can still override > LD_LIBRARY_PATH. >=20 > Thanks, > Ludo=E2=80=99. Hi, Thanks for your review! > Could you show how to test it? Currently if I just run `vulkaninfo`, this error appears: ``` ERROR at /tmp/guix-build-vulkan-tools-1.3.280.0.drv-0/source/vulkaninfo/./ vulkaninfo.h:412: Failed to initialize: Vulkan loader is not installed, not= =20 found, or failed to load. ``` I don't know if something should be patched before building itself. But if I run: `LD_LIBRARY_PATH=3D$(guix build vulkan-loader)/lib vulkaninfo= `,=20 the program will be executed without any error. > This is probably a bit too broad because LIBRARY_PATH includes > build-time-only dependencies (python, gawk, binutils, bzip2, etc.). If I wrap only with vulkan-loader's library path also, it works. But would = it=20 be a "right" way of wrapping a program. > Also maybe change =E2=80=98=3D=E2=80=99 to =E2=80=98suffix=E2=80=99 so us= ers can still override Yes, you are right. I will change it. =2D-=20 Sughosha