From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iEMNOyoBoGBDiAAAgWs5BA (envelope-from ) for ; Sat, 15 May 2021 19:13:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EHq3NioBoGAtYwAA1q6Kng (envelope-from ) for ; Sat, 15 May 2021 17:13:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DCBD2AFF7 for ; Sat, 15 May 2021 19:13:14 +0200 (CEST) Received: from localhost ([::1]:35260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhxqj-000081-QM for larch@yhetil.org; Sat, 15 May 2021 13:13:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhxqY-00005A-Ch for guix-patches@gnu.org; Sat, 15 May 2021 13:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhxqY-0007Hr-4Q for guix-patches@gnu.org; Sat, 15 May 2021 13:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhxqX-000652-Up for guix-patches@gnu.org; Sat, 15 May 2021 13:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47898] [PATCH] [core-updates] Add option --xpath0 to xmllint from libxml2 Resent-From: david larsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 15 May 2021 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47898 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 47898@debbugs.gnu.org Received: via spool by 47898-submit@debbugs.gnu.org id=B47898.162109878023363 (code B ref 47898); Sat, 15 May 2021 17:13:01 +0000 Received: (at 47898) by debbugs.gnu.org; 15 May 2021 17:13:00 +0000 Received: from localhost ([127.0.0.1]:49149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhxqW-00064l-7e for submit@debbugs.gnu.org; Sat, 15 May 2021 13:13:00 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:42822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhxqU-00064O-5p for 47898@debbugs.gnu.org; Sat, 15 May 2021 13:12:58 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id C6D5B1DDBCC9; Sat, 15 May 2021 19:12:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1621098771; bh=nkIE/BnDXb+4lKClooNkZkiV20qqmqgq/mVkhZmAftE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=DFBxjxgu7777KPPpmn6CgOwiMfjVh/GRguKTCgHF0QsKQw+16T+7xuhyZmmkFI/j1 104gSOA5MDDErg9R61Lv3wCJ5QM9284fa3S7xFKLxAYXN9972zZeOs3XANlMS1zTfZ KRBvLdqMf2XeEVAd9cyUVyatMosoD+SRP3a+vrSaBCZTnurmSYclD2g4aXeQJHYMD8 rm22kqCxHb56uWsP4roPKRBXaZA1hVLUE89c3KNmhEDWv0gqaUjRRr4LkDJw9t0Pxl yrlau+3JbYDNltaCVaAJZMkP21UD5wdqEua8V4LSjkSvuh/0q+Rm+i2HskRFIdz3Sl kQx61Klzk9pzw== X-Fuglu-Suspect: 9bb175673f2f4f1fa2bd0d107db53f77 X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Sat, 15 May 2021 19:12:44 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 15 May 2021 19:12:44 +0200 From: david larsson In-Reply-To: <875yzkht7g.fsf@gnu.org> References: <20aec8da67d18b52e5a166f45cab40b2@selfhosted.xyz> <87eeeaiz5h.fsf@gnu.org> <48c1517d3239d55826324aa8f2bc9d4d@selfhosted.xyz> <87bl9eiwx5.fsf@gnu.org> <80bc8f6c73d5aa423cf906d59bbcd43e@selfhosted.xyz> <875yzkht7g.fsf@gnu.org> Message-ID: <350a1a3c73fb0040aadbba0fd34c6518@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621098794; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nkIE/BnDXb+4lKClooNkZkiV20qqmqgq/mVkhZmAftE=; b=RHE4ktgVRRTQsoU0zafih4urodVwkrDMeN5kx836GtLsnAFXY4d/56IEGnvRd1TAOnrECV 1DRpCz5qi8PmWtVB2BfL3bjA7Jm37PujH/7ljSZApuy3wo5zJ41MJmnIUqvsM78qCIKm87 S7waqWnejSLgHATc9nrBruh0JE7llOSwDL0yedWrcuJIqmFAm9x1ZILVuA6H0Kbarc38M2 zHqU0jmrnldKjY8dYbLD2SHSSyNyLujGUfnAuBr/CeZtF968//6cS75JypcK3BeM4rrJ78 /xZo1oVPTWQGmblMw8n5GY4eoifsn9wT4I4OY+Qh8DTrK1sXESzbP9l2n40law== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621098794; a=rsa-sha256; cv=none; b=TLSKLupSGHyFP9M205OSV2v8taYah4wB28Apkcvm6jbBhWGozMU1gWsSUhc4ol/H/1RNqF oEiXE3gIEw6qlYtKi2P+fZbetk3NBXZlTiH2UCIYnCd1F0R0zUHUHjHoRQ5ghY9039CrQd M1da+5jc/GSqGfQ/EwblLYGeRmlGf0oCf9X1pcyY2BzK0xI2+HaGVzeqkWmMtzMD+NEE+Z fMuXsWdVjvOkWC4MJzXGlWqzGxj84kp/joAcxd1On2/wffb7kcwopM4XjzfM9TyBJKbLNt KWFVelIqGPdx5AoPNoKcQ8Ns9tEk4MGE0QswBk+W80vUJdM1pRz7STkinKAhog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=selfhosted.xyz header.s=dkim header.b=DFBxjxgu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=selfhosted.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=selfhosted.xyz header.s=dkim header.b=DFBxjxgu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=selfhosted.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9DCBD2AFF7 X-Spam-Score: -1.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: cd0zw6RcCQux On 2021-05-15 18:12, Marius Bakke wrote: > david larsson skriver: > >>> libxml2-xpath0 is probably better indeed, I don't have a strong >>> opinion. >>> Can you send an updated patch? :-) >>> >>> Thanks, >>> Marius >> >> Updated patch attached! > > Thanks! > > [...] > >> gnu/packages/patches/libxml2-Add-option-xpath0.patch: New file... >> gnu/packages/xml.scm (libxml2-xpath0) [source]: ...apply it. >> --- >> .../patches/libxml2-Add-option-xpath0.patch | 139 >> ++++++++++++++++++ >> gnu/packages/xml.scm | 52 +++++++ >> 2 files changed, 191 insertions(+) >> create mode 100644 >> gnu/packages/patches/libxml2-Add-option-xpath0.patch > > Please also register this patch in gnu/local.mk. Can you also add your > copyright at the top of xml.scm? > > [...] > >> +(define-public libxml2-xpath0 >> + (package >> + (name "libxml2-xpath0") >> + (version "2.9.10") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "ftp://xmlsoft.org/libxml2/libxml2-" >> + version ".tar.gz")) >> + (sha256 >> + (base32 >> + >> "07xynh8hcxb2yb1fs051xrgszjvj37wnxvxgsj10rzmqzy9y3zma")) >> + (patches (list (search-patch >> "libxml2-Add-option-xpath0.patch"))))) > > You can inherit another record in Scheme to avoid duplicating all the > fields. Then the package can be shortened to: > > (define-public libxml2-xpath0 > (package/inherit libxml2 > (name "libxml2-xpath0") > (source (origin > (inherit (package-source libxml2)) > (patches (append (search-patches > "libxml2-Add-option-xpath0.patch") > (origin-patches (package-source > libxml2)))))) > (description > "..."))) > > We should fill out that description to mention how it differs from the > regular libxml2. Can you give it a try? I can make the other changes > on your behalf, but not sure what to write. > > Thanks, > Marius I can fix all of it and send an updated patch again. Best regards, David