unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 65335@debbugs.gnu.org
Cc: ngraves@ngraves.fr
Subject: [bug#65335] [PATCH 1/4] file-systems: canonicalize-device-name: Ignore the "none" case.
Date: Wed, 16 Aug 2023 11:29:26 +0200	[thread overview]
Message-ID: <344951a96d504fb86db43c79262739f5a7c086bb.1692178169.git.ngraves@ngraves.fr> (raw)
In-Reply-To: <cover.1692176564.git.ngraves@ngraves.fr>

---
 gnu/build/file-systems.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 36a59f5f5c..e39bd31c3b 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -1021,8 +1021,8 @@ (define find-partition-by-luks-uuid
 \f
 (define (canonicalize-device-spec spec)
   "Return the device name corresponding to SPEC, which can be a <uuid>, a
-<file-system-label>, or a string (typically a /dev file name or an nfs-root
-containing ':/')."
+<file-system-label>, the string 'none' or another string (typically a /dev
+file name or an nfs-root containing ':/')."
   (define max-trials
     ;; Number of times we retry partition label resolution, 1 second per
     ;; trial.  Note: somebody reported a delay of 16 seconds (!) before their
@@ -1046,8 +1046,8 @@ (define (canonicalize-device-spec spec)
 
   (match spec
     ((? string?)
-     (if (string-contains spec ":/")
-         spec                  ; do not resolve NFS devices
+     (if (or (string-contains spec ":/") (string=? spec "none"))
+         spec                  ; do not resolve NFS / tmpfs devices
          ;; Nothing to do, but wait until SPEC shows up.
          (resolve identity spec identity)))
     ((? file-system-label?)

base-commit: 1a92b3f43c280f143b00f8bb95a173fb85e52664
-- 
2.41.0





  reply	other threads:[~2023-08-16  9:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16  9:24 [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Nicolas Graves via Guix-patches via
2023-08-16  9:29 ` Nicolas Graves via Guix-patches via [this message]
2023-08-16  9:29   ` [bug#65335] [PATCH 2/4] gnu: services: activation-script: Ensure /var/run existence Nicolas Graves via Guix-patches via
2023-08-16  9:29   ` [bug#65335] [PATCH 3/4] gnu: build: activate-current-system: Ensure directory existence Nicolas Graves via Guix-patches via
2023-08-16  9:29   ` [bug#65335] [PATCH 4/4] gnu: system: bootable-kernel-arguments: Ignore the "none" root case Nicolas Graves via Guix-patches via
2023-08-20 22:15 ` [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Nicolas Graves via Guix-patches via
2023-08-20 22:16 ` [bug#65335] [PATCH v2 1/5] file-systems: canonicalize-device-name: Ignore the "none" case Nicolas Graves via Guix-patches via
2023-08-20 22:16   ` [bug#65335] [PATCH v2 2/5] gnu: services: activation-script: Ensure /var/run existence Nicolas Graves via Guix-patches via
2023-08-21 14:09     ` [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Ludovic Courtès
2023-08-20 22:16   ` [bug#65335] [PATCH v2 3/5] gnu: build: activate-current-system: Ensure directory existence Nicolas Graves via Guix-patches via
2023-08-21 14:09     ` [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Ludovic Courtès
2023-08-20 22:16   ` [bug#65335] [PATCH v2 4/5] gnu: system: bootable-kernel-arguments: Ignore the "none" root case Nicolas Graves via Guix-patches via
2023-08-21 14:10     ` [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Ludovic Courtès
2023-08-21 14:15     ` Ludovic Courtès
2023-08-20 22:16   ` [bug#65335] [PATCH v2 5/5] gnu: home: symlink-manager: Allow dedicated device skip Nicolas Graves via Guix-patches via
2023-08-21 14:12     ` [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Ludovic Courtès
2023-09-09 10:47       ` Ludovic Courtès
2023-10-05 13:07         ` Ludovic Courtès
2023-10-05 14:30           ` Nicolas Graves via Guix-patches via
2023-10-12  6:55             ` Ludovic Courtès
2024-02-15 11:45               ` Nicolas Graves via Guix-patches via
2024-02-19 17:48                 ` bug#65335: " Ludovic Courtès
2024-02-19 23:47                   ` [bug#65335] " Nicolas Graves via Guix-patches via
2023-08-21 14:06   ` Ludovic Courtès
2024-02-04  2:19 ` [bug#65335] [PATCH v3 1/5] gnu: build: file-systems: Extend tmpfs fallback Nicolas Graves via Guix-patches via
2024-02-04  2:19   ` [bug#65335] [PATCH v3 2/5] gnu: services: Ensure /var/run existence in activation-script Nicolas Graves via Guix-patches via
2024-02-04  2:19   ` [bug#65335] [PATCH v3 3/5] gnu: build: activation: Ensure /run existence Nicolas Graves via Guix-patches via
2024-02-04  2:19   ` [bug#65335] [PATCH v3 4/5] gnu: system: bootable-kernel-arguments: Extend tmpfs fallback Nicolas Graves via Guix-patches via
2024-02-04  2:19   ` [bug#65335] [PATCH v3 5/5] gnu: home: symlink-manager: Allow busy device skip Nicolas Graves via Guix-patches via
2024-03-28  4:25 ` [bug#65335] [PATCH 0/4] Allow mounting root on tmpfs for impersistence Scott Colby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=344951a96d504fb86db43c79262739f5a7c086bb.1692178169.git.ngraves@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=65335@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).