From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sAGfIpU3GmIOrQAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 15:22:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eFvvHpU3GmK/gQAAauVa8A (envelope-from ) for ; Sat, 26 Feb 2022 15:22:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D2592C2B6 for ; Sat, 26 Feb 2022 15:22:12 +0100 (CET) Received: from localhost ([::1]:51974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNxxb-0007VU-BK for larch@yhetil.org; Sat, 26 Feb 2022 09:22:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNxxS-0007V7-0N for guix-patches@gnu.org; Sat, 26 Feb 2022 09:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNxxR-00082Y-Nr for guix-patches@gnu.org; Sat, 26 Feb 2022 09:22:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNxxR-0007k6-Js for guix-patches@gnu.org; Sat, 26 Feb 2022 09:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Attila Lendvai , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164588527229694 (code B ref 53878); Sat, 26 Feb 2022 14:22:01 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 14:21:12 +0000 Received: from localhost ([127.0.0.1]:54594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNxwd-0007is-K7 for submit@debbugs.gnu.org; Sat, 26 Feb 2022 09:21:11 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:38229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNxwc-0007if-Gi for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 09:21:10 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 6E6A3580106; Sat, 26 Feb 2022 09:21:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Feb 2022 09:21:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=5kGYCkDP/J7v3T v+TCzO7D2vEo8+BQn0EPlVBAqqu+I=; b=hSbDwExq+6kKJvkJ/zAMEqlKaTN6Ex ST7n8mAaKomZ+ZpCJ0LaqfnTZE2JOmeyQfeCkNSXB9YsAY0Or24i7ycO+p8uKyAL zQ07MmXhpOUjhojJSMQpJ1YgfaOivEPKzKJJEJS7hjvOeABtlrmUjwrZsxboH+Yc R2sAjQjlWQripWBvWObHwlH7WM0KT3LqNG4iJhAFIxxb6GWm/BmuE/QNQO0sIHy3 20ioIlf+diOriwUoSaEMT4+GXvSmBxMiln4s83/zs8hmNy4BGHGXzcJFWVOrpNfL yKKvwBLt/bT2OXCMSbM5hFK8rMAZ22zJsfDjdGp1YoaSRhezTvLCFn6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5kGYCkDP/J7v3Tv+T CzO7D2vEo8+BQn0EPlVBAqqu+I=; b=Aqr+535+sAQ1Qk1szb5V2XIuZMuHvNVBj FIIO4tdI+7VUMKBaX04mQVMhTZormCM5Udb7zD+orjf3g2bJhJSocXpqS3wvY3yl 7G9hahtCe7FltLrYr2cKA0F+NyKDwg5Ui/oFFolKGLgFZ48WXmplnyJXGprl6V6q JprRGVgCDvMIAUhpTs3wuEB6r/8aTIwuBLLkU3AVF5wxcN/ZKz0KTg+Hx9Y66+NF /sJyAh3/thwxXYbmKdXZZQE2GmfV34B8lwHbyieGqgyormVa1aNpatLWBbIvLYJA XFkNcthqmjGt7/8Tpfz10Ig2yJcIB01vmSfJmM0chZfHLFx2iCWRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeigdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfgggtsehgtderredttddvnecuhfhrohhmpefrhhhilhhiphcu ofgtifhrrghthhcuoehphhhilhhiphesphhhihhlihhpmhgtghhrrghthhdrtghomheqne cuggftrfgrthhtvghrnhepledtfeevvdevjeegleeltddtteeiveffkeetfedtieehuedt jeduudevhfejkeefnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphesphhhihhl ihhpmhgtghhrrghthhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Feb 2022 09:21:04 -0500 (EST) From: Philip McGrath Date: Sat, 26 Feb 2022 09:20:58 -0500 Message-ID: <3354324.gHnXMxdNb5@bastet> In-Reply-To: <649ff53c6b4ff05db5bad3c75abd9d49752930d1.camel@ist.tugraz.at> References: <20220220060610.178131-1-philip@philipmcgrath.com> <20220226130254.1301333-4-philip@philipmcgrath.com> <649ff53c6b4ff05db5bad3c75abd9d49752930d1.camel@ist.tugraz.at> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3954881.TWLLKBRVyn"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645885333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5kGYCkDP/J7v3Tv+TCzO7D2vEo8+BQn0EPlVBAqqu+I=; b=Kx5uPFdB5tqAHZxQ+fOLahaLNthoPcagQ+qy5OhScpG0feENt5xUtY/ndKvZLQsYl0RgtH v3l+tEOm+R9I0xrbqSVAvppByAuPnUvrFSUARDS+XefURWwuoG/nELmBXAFTF1hoqRS5Vr CNO8/Ihnd7QOb3gD+0zHvyN1jskLewY50NwWBxQOXEtZnvutOvZ53isLNuevWfoKi/L+8Z bL2jofHmlJ3zJ6S1y60iXxvQLadJEf2lcJZIGM1+9dQQpcEGYDUQ5zWfn+J7PxnskBDOYy gSvfqsMx75l1T/Lm5H4KjI1lbASpVARjDayo3yPjmciPnN9K/5fQH3K7U4d7XQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645885333; a=rsa-sha256; cv=none; b=RDGl3gWUHqQXQibzwTvJIyeZS/W42leaZVk+kjsHEbTTfTAd5F42Km5OhoyJ2mws+L0yX9 9b3vK5l/5YVOCN609LxxtDXAFdpwRqg6K/FKsi8kmE53UhMGFWnRzu5SV+gy3wAlLUAzMG EanpOn3b+dLbisI7h6+H6/7wQI9zBA5iH07zFb6vrfJgg9dL9Wi90waQC3cjUpiSg4Naom bT6iqsJ//Lql+hLb1luz9OYyIRh6lU+517UBEUbo8CkKTBTSxcXJtjsTinSIPi9Aph/8Mq XaW6MFwrpm+/cnM63/ZbbMpZygbkwyjeusZZg4cRPOH9F8cGjTyBc+jasjksbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=hSbDwExq; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=Aqr+535+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=hSbDwExq; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=Aqr+535+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7D2592C2B6 X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: m3F5xz3D+5tB --nextPart3954881.TWLLKBRVyn Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Philip McGrath To: 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Attila Lendvai , Malte Gerdes , raingloom , Maxime Devos Subject: Re: [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Date: Sat, 26 Feb 2022 09:20:58 -0500 Message-ID: <3354324.gHnXMxdNb5@bastet> In-Reply-To: <649ff53c6b4ff05db5bad3c75abd9d49752930d1.camel@ist.tugraz.at> References: <20220220060610.178131-1-philip@philipmcgrath.com> <20220226130254.1301333-4-philip@philipmcgrath.com> <649ff53c6b4ff05db5bad3c75abd9d49752930d1.camel@ist.tugraz.at> Hi, On Saturday, February 26, 2022 8:47:45 AM EST Liliana Marie Prikler wrote: > First, can we simplify "make-installation-layer.rkt" to "make- > installation-layer"? I don't think the file extension conveys much > meaning here, or does it? To me (I don't know about anyone else), the ".rtk" extension tells me that I have to pass the file as an argument to `racket`, i.e. that the file is not a launcher from `raco exe` or a script with a shebang that I could `invoke` directly. > > Second, can we find an abbreviation for > > > + (extract-package-source* > > + `((,(origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/racket/2d") > > + (commit %racket-commit))) > > + (sha256 (base32 > > + > > "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr")) > > + (file-name > > + (git-file-name "racket-2d" %racket-version))) > > + "2d" "2d-doc" "2d-lib") > > + (,(origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/racket/algol60") > > + (commit %racket-commit))) > > + (sha256 (base32 > > + > > "09kj6asypmc24n29w0izc9p0q8hpga2hpkchsypfwn5c8zpvihlx")) > > + (file-name > > + (git-file-name "racket-algol60" %racket-version))) > > + ("algol60" ".")) > > + (,%racket-origin > > + ("base" "pkgs/base") ;; FIXME belongs in racket-minimal > > + ("racket-lib" "pkgs/racket-lib") ;; FIXME belongs in > > racket-minimal > > + ("at-exp-lib" "pkgs/at-exp-lib") > > + ("compiler" "pkgs/compiler") > > + ("compiler-lib" "pkgs/compiler-lib") > > + ("net" "pkgs/net") > > + ("net-doc" "pkgs/net-doc") > > + ("net-lib" "pkgs/net-lib") > > + ("racket-doc" "pkgs/racket-doc") > > + ("racket-index" "pkgs/racket-index") > > + ("sandbox-lib" "pkgs/sandbox-lib") > > + ("zo-lib" "pkgs/zo-lib")) > > + (,(origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/racket/cext-lib") > > + (commit %racket-commit))) > > + (sha256 (base32 > > + > > "00w38jpv88fpl4pgj6ndnysvn0s21rjvj0xhznay80msan0vc341")) > > + (file-name (git-file-name "racket-cext-lib" %racket- > > version))) > > + "cext-lib" "dynext-lib") > > [...] > > I think some way to shorten those origins would do wonders in terms of > the number of lines this patch adds. > At one point, I had abbreviated the origins as something like: (REPO-SPEC SHA256 [COMMIT]) where REPO-SPEC is one of: (GITHUB-OWNER GITHUB-REPO) ; ^ e.g. for https://github.com/RenaissanceBug/racket-cookies GITHUB-REPO ; "racket" is owner and COMMIT defaults to `%racket-commit`, but could be overridden for . I think I'd given SHA256 as a literal string, but it could be e.g.: (extract-package-source* `((("2d" ,(base32 "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr")) "2d" "2d-doc" "2d-lib") ...)) if that seems better. I wasn't sure about the trade-off between being slightly more cryptic than explicit origins, but a lot shorter. -Philip --nextPart3954881.TWLLKBRVyn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE9GWrrNY3rqwUFVXPygNjjfo/HHoFAmIaN0oACgkQygNjjfo/ HHpqRQ//Wldp19n9403fhtxqZmr6gwrkYHpj6QLunVETjn26U5ueu3kQxjSs0zMQ JOpdTngsYKAPUD7jU70GtAFLCjU7RiIr1W/u5Xbg1UUtKuQVl6LggMAHSOI6CjSj mreFP9jYW2/6p8Y9uN869WL8CdrY5721N+hD9YbAv5Tu9c0uQa9fjJed/lAASyT9 Hq14VERc4nt2uUIwdez5y7nx/20jUJn1yotmjUY1VqIYxfcIvATn0CVqXk//9C39 qUsJm3cb68t/6V46s/HG1O+0WEd43kWwTInJ2w1oZ2YKW3u7MreVz2dDBgsrRtc8 orTOqvM4ILefTakrMBZ1Za77lc/YoMxfBTIn4yGmBMSpna9ezL8IO89iru/ajh3s o2DBy/rej9KeLUN5ZtfUVA+L8T4j7Z9h/MQhvD78wu4FtuIxrNcKRzcmAmrzcUJ+ exS4R4NcNhiBIIZ7ZT0abZoWH7tZgtdP2ngI590KvOhGXQruc463KRWkCEMHVV3Z 7YxhWXNYAZb/r5msh2CK2piwFBYUplbZB7U/y43AS1MpAlOmoDWG/eF9KIwr60jt 1iytuqf9kQTewyMrQHCZAP10/0mixm8mXjs1W8A7+wCSypsJ5kPkSmWcTuHvmoVt gOqR4/mUm/14+VdHV1fW2z3jQLqD7YB7GgnwdqiQlVbAu6kSjNg= =6tsx -----END PGP SIGNATURE----- --nextPart3954881.TWLLKBRVyn--