From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id fHwVLS1BGWRplQAASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 06:31:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uAoHLC1BGWRSXgEAauVa8A (envelope-from ) for ; Tue, 21 Mar 2023 06:31:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DEFC3EA94 for ; Tue, 21 Mar 2023 06:31:24 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Y7QOg0Yn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679376685; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AFMwXALYZoh/vMBbC/Gc3+gFWOVMTzCSftiSQ0HT5kQ=; b=LQjIUCmBRRB1dzJCre4UZAt+OcNckFbLPjo3CCIzjn+qxczmxZTEzQYDdObxWUw7ThcuNf HrclO9PvoTjvxkgV0iiF0DYN7fzSJIjEn2z2yH9PvnIVjM1Rph6Z/PmfjT7dudZ4uY5fWj aEeAuUuMlf7Lp2Ku6x913uekL8HvEEv3t4L1zT2+DEvObIpjLOih2TKW7V5Z5XjXEZgi8A ywpmh+04Y9wuoKICc0Hv57vgDYY/Ea61/IOvXvG7ZNbKU+QC3+AwXDXXBovVXVNjKeO4Xe gyLHZCbrkW3K3ClrYxsU5nRPmttpxihJf+NE3dKf10uFR8GsFEfNJjyXKbaNpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Y7QOg0Yn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679376685; a=rsa-sha256; cv=none; b=i3yGMqI62uwK9rKMfTjOodsU94Cil1O4fL9h/OiyB6/mWEcXRtYDBQ0KIiam3msFc77dkK P3ybqN47541Z3LMCBbyJUmmFBnIC8BvyA7/3X5+ROZjXegpuStlrPaAdUXaphs6w4qoXH5 kvu2YphUq/4Hbiz1NbBGIagmO1NZoFtjhsqliEDBwvIoPe8Ss+ayPezkqnLZn0rA+weAym Ih59xnKie52CTQ1xAiUi5NhhdoX2rTTnD+ExlJyn+uTyhy5cCRqFX3jWDXP3IOicEhsc/D XfOyHzChkG4kWLQYD4pwiwI5LJu+fks9XAn/bYSL9bcBCFv6+lBZSDLG82anWA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peUaP-00022R-EU; Tue, 21 Mar 2023 01:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peUaM-000223-Id for guix-patches@gnu.org; Tue, 21 Mar 2023 01:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peUaM-0008Q8-5h for guix-patches@gnu.org; Tue, 21 Mar 2023 01:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peUaL-0004Wp-OG for guix-patches@gnu.org; Tue, 21 Mar 2023 01:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62298] [PATCH 7/8] services: mpd: Use user-account (resp. user-group) for user (resp. group) fields. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 05:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62298 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: ludo@gnu.org, 62298@debbugs.gnu.org, maxim.cournoyer@gmail.com Received: via spool by 62298-submit@debbugs.gnu.org id=B62298.167937662017046 (code B ref 62298); Tue, 21 Mar 2023 05:31:01 +0000 Received: (at 62298) by debbugs.gnu.org; 21 Mar 2023 05:30:20 +0000 Received: from localhost ([127.0.0.1]:57386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peUZf-0004Qs-M4 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 01:30:19 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:35714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peUZe-0004Qf-TV for 62298@debbugs.gnu.org; Tue, 21 Mar 2023 01:30:19 -0400 Received: by mail-ed1-f66.google.com with SMTP id y4so55311017edo.2 for <62298@debbugs.gnu.org>; Mon, 20 Mar 2023 22:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679376612; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=AFMwXALYZoh/vMBbC/Gc3+gFWOVMTzCSftiSQ0HT5kQ=; b=Y7QOg0YncocjQqZGPOzeXFBrzqPaoJs7asHMDcVDd0IRcDiz0RjLunh2y/LUHFQdgr n3huIorDr/Kzrcf37XGb+LyVFmWqUASM1B7I9xOS4jjYWzN1c8EhDOJBmbOIRyVFV8y+ el+n4Qd5YmMLu5JnF4viCKATEmickbrPCQwMT9qDj61Uvh/CyPB1CvtgIHIyoiHZxgVE zfkTIZ8k2CDgABtOvbmdgi52URqbLgU+gLD8hRKqfuWhQhccNrfP4is7fbUxumHnU4bU qvdiZsVPsndLG4Z9vnqvZvpJY5V0R1P8f2Z/JyDyDFVMHYaKJROsgANqNhf+cDAkn7ig Vlxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679376612; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AFMwXALYZoh/vMBbC/Gc3+gFWOVMTzCSftiSQ0HT5kQ=; b=qcSSe+Xl/TFXH7xqbm6oOa2IbSv4qm+c5VQu2LtFa6t/pVfNSPDIOcofzHxvCVnhQ4 EuYAXgqeacs4kqNCV7UGUAL8EOwZrIcMZYXxV2wChxmhcwnHXQOnbz8QMrRtiTEm/R20 v2Zr2opK927hDt6keu9HAbH4TgUnQ/E81vqvT+UmvTfzGRHNJN3Pwn+dufHI3Xi/e6MN vBGflRH3YJBM9uXL2e2OmoLx4eG5bxvVaetrbnuSSYKz/AvxX/UzzujHKpCL0rdHbWDB DvVP4i6zT6cJgIRNXSvWobsxyG5l6C32i4YsUhn9AbTnSFAmN+YV0XGIrUOHG8V4hLgc ALig== X-Gm-Message-State: AO0yUKUKntBa3UpPCM44V4E67CYOyvXZLVWV0DxJOEzso2m3mHmshY9V qDN3pxaqdkxSykAMIqeOJPM= X-Google-Smtp-Source: AK7set9fzmvJcUmxWf18QSs/OWsmqYS4N5vp+BTKdQNkyL7PFQZxhJEglAOkEuwDrs2PYG+lCfI3EQ== X-Received: by 2002:a17:906:f2d1:b0:92b:ae6c:23e7 with SMTP id gz17-20020a170906f2d100b0092bae6c23e7mr1384824ejb.56.1679376612595; Mon, 20 Mar 2023 22:30:12 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g5-20020a170906394500b0092fb818127dsm5321528eje.94.2023.03.20.22.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 22:30:12 -0700 (PDT) Message-ID: <32c1e87f3f8bd18e1c18123991ac4dcfebd77b35.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 21 Mar 2023 06:30:10 +0100 In-Reply-To: References: <6e1da37de3839d56546389924ce47b4563d05d94.1679332019.git.mirai@makinata.eu> <27ddb1989f281cee887c903955cc793fc34bd1ab.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 1DEFC3EA94 X-Spam-Score: -0.15 X-Migadu-Spam-Score: -0.15 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: kKVD/27MAg1I Hi Bruno, Am Dienstag, dem 21.03.2023 um 02:10 +0000 schrieb Bruno Victal: > After giving some thought to this, IMO I think it's simply > uninteresting for these fields to accept string values. > Prior to the 5c5f0fc1135ff15f9c4adfc5f27eadd9a592b5d1 refactor, the > names were hardcoded and the refactor allowed them to be changed. I think it's a little late to come to this realization. Note how my prior attempt at fixing 61570 was delayed for more than a month so that a proper sanitizer can be implemented and would have had a better user interface than what you are currently proposing. > Accepting strings is simply uninteresting (or bad) since: >=20 > * A string doesn't uniquely identify an account and results in buggy > behavior [1]. >=20 > * Since the string values are only used to set the 'name' of the > user-account/group records, which is specific to the service as > they're created within the mpd-account procedure, it's simply setting > a vanity value. It's as interesting as allowing the filename in > (mixed-text-file "mpd.conf" ...) to be set by the user. >=20 > * It's clearly unsanitizable since it would require accessing other > fields. Monkeying within (mpd-accounts) with special symbols just > obfuscates the code with no clear benefits to be had, in addition to > defeating the point of having a sanitizer in the first place. >=20 >=20 > I fail to see the utility in ever accepting strings here for what > amounts to a vanity change in 'ps aux' output.=C2=A0 Need I remind you that the original concern was about backwards API compatibility? Yes, accepting strings and doing things with them is broken for the reasons you mentioned and there should be a deprecation warning about this. But not heeding the user values is silly and you should still set those vanity values for the sake of vanity itself. Cheers