From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YM0wHz2BX18SYgAA0tVLHw (envelope-from ) for ; Mon, 14 Sep 2020 14:42:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UEmiGT2BX183RAAA1q6Kng (envelope-from ) for ; Mon, 14 Sep 2020 14:42:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ECAE89401CB for ; Mon, 14 Sep 2020 14:42:04 +0000 (UTC) Received: from localhost ([::1]:54114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHpgB-0006Gx-Bw for larch@yhetil.org; Mon, 14 Sep 2020 10:42:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHpJu-0002mY-R2 for guix-patches@gnu.org; Mon, 14 Sep 2020 10:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHpJu-0000pv-Gb for guix-patches@gnu.org; Mon, 14 Sep 2020 10:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHpJu-0007Oz-CN for guix-patches@gnu.org; Mon, 14 Sep 2020 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43310] [PATCH] gnu: Add lsp-dsp-lib. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Sep 2020 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43310 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 43310@debbugs.gnu.org Received: via spool by 43310-submit@debbugs.gnu.org id=B43310.160009308428386 (code B ref 43310); Mon, 14 Sep 2020 14:19:02 +0000 Received: (at 43310) by debbugs.gnu.org; 14 Sep 2020 14:18:04 +0000 Received: from localhost ([127.0.0.1]:55680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpIy-0007Nm-B4 for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:18:04 -0400 Received: from mout02.posteo.de ([185.67.36.142]:58659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpIw-0007L2-5g for 43310@debbugs.gnu.org; Mon, 14 Sep 2020 10:18:03 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id CB8C62400FB for <43310@debbugs.gnu.org>; Mon, 14 Sep 2020 16:17:55 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BqpNf17tnz6tml; Mon, 14 Sep 2020 16:17:53 +0200 (CEST) Message-ID: <3128d450cf954008cadc7c24d9817c5e88a6b4ea.camel@zrythm.org> From: Alexandros Theodotou Date: Mon, 14 Sep 2020 15:17:48 +0100 In-Reply-To: <20200914140203.GB17272@E5400> References: <9160c83dd3e513eb0f73b6a8b22ee78323fd2555.camel@zrythm.org> <20200914140203.GB17272@E5400> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-8oJgATUbhP/joBMg1oOA" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=zrythm.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.91 X-TUID: pz2h2X7HjM32 --=-8oJgATUbhP/joBMg1oOA Content-Type: multipart/mixed; boundary="=-MxOvHee9eIurc0QrkZwS" --=-MxOvHee9eIurc0QrkZwS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Efraim, Thanks for the review. On Mon, 2020-09-14 at 17:02 +0300, Efraim Flashner wrote: > It looks like everything in the modules directory is vendored. Can we > build it separately and link it in?=20 I asked the author something similar a while back=20 https://github.com/sadko4u/lsp-dsp-lib/issues/1#issuecomment-676517050 I think the build system just expects those modules to be there as sources - not sure if they even build anything to link to. BTW, this is my initial patch, before the author started to provide an all-inclusive=20 tarball in the github releases page: ```scheme (define-public lsp-dsp-lib (package (name "lsp-dsp-lib") (version "0.5.6") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/sadko4u/lsp-dsp-lib") (commit (string-append "lsp-dsp-lib-" version)))) (file-name (git-file-name name version)) (sha256 (base32 "1n5qp9bjsgg1ziy9mqnx034qlzbsp7yl473vk9aigzkyj883dfpj")))) (build-system gnu-build-system) (arguments `(#:tests? #f ; no tests #:make-flags (list "CC=3Dgcc") #:phases (modify-phases %standard-phases (add-before 'build 'copy-modules (lambda* (#:key inputs #:allow-other-keys) (copy-recursively (assoc-ref inputs "lsp-common-lib") "modules/lsp-common-lib") (copy-recursively (assoc-ref inputs "lsp-test-fw") "modules/lsp-test-fw") #t)) (replace 'configure (lambda _ (invoke "make" "config" (string-append "PREFIX=3D" (assoc- ref %outputs "out"))) #t))))) (inputs `(("lsp-common-lib" ,(origin (method git-fetch) (uri (git-reference (url "https://github.com/sadko4u/lsp-common-lib") (commit "lsp-common-lib-1.0.7"))) (file-name (git-file-name name version)) (sha256 (base32 "1alxv2ryivbj122gryxrrvyicw6zgbdk15wp010lrq6r1nj7mjxh")))) ("lsp-test-fw" ,(origin (method git-fetch) (uri (git-reference (url "https://github.com/sadko4u/lsp-test-fw") (commit "lsp-test-fw-1.0.5"))) (file-name (git-file-name name version)) (sha256 (base32 "0n4ircp9bgzwfaa6023bvfsb90qvl2iawbihnwivr5id1js5jq3p")))) )) (home-page "https://github.com/sadko4u/lsp-dsp-lib") (synopsis "Digital signal processing library") (description "The LSP DSP library provides a set of functions that perform SIMD-optimized computing on several hardware architectures. All functions currently operate on IEEE-754 single-precision floating-point numbers.") (license license:lgpl3+))) ``` > Also, I saw that there were a few > test directories. Are there tests to be built? Not sure - I don't see a check/test make target (see `make help`) > > + (arguments > > + `(#:tests? #f ; no tests > > + #:make-flags > > + (list "CC=3Dgcc") >=20 > This can be cc-for-target > (list (string-append "CC=3D" ,(cc-for-target))) ACK > > + (modify-phases %standard-phases > > + (replace 'configure > > + (lambda _ > > + (invoke "make" "config" (string-append "PREFIX=3D" > > (assoc-ref %outputs "out"))) > > + #t))))) >=20 > We'd rather not use %outputs if possible, but to add it to the > lambda. > Also invoke already returns #t >=20 > (lambda* (#:key outputs #:allow-other-keys) > (invoke "make" "config" > (string-append "PREFIX=3D" (assoc-ref outputs > "out")))))))) ACK Please find the updated patch attached. Thanks, Alex --=-MxOvHee9eIurc0QrkZwS Content-Disposition: attachment; filename="0001-gnu-Add-lsp-dsp-lib.patch" Content-Type: text/x-patch; name="0001-gnu-Add-lsp-dsp-lib.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAyZWZiMmUyZGZiZmU0Y2Q4MmI5MGZlZjQ0ZjZkNjkxOWE1Y2FjODY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kcm9zIFRoZW9kb3RvdSA8YWxleEB6cnl0aG0ub3Jn PgpEYXRlOiBNb24sIDE0IFNlcCAyMDIwIDE1OjE2OjMwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Z251OiBBZGQgbHNwLWRzcC1saWIuCgoqIGdudS9wYWNrYWdlcy9hdWRpby5zY20gKGxzcC1kc3At bGliKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9hdWRpby5zY20gfCAzMSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9hdWRpby5zY20gYi9nbnUvcGFja2FnZXMv YXVkaW8uc2NtCmluZGV4IDVlNjAwOGYzMWUuLjM4ZWU0ZjhiY2MgMTAwNjQ0Ci0tLSBhL2dudS9w YWNrYWdlcy9hdWRpby5zY20KKysrIGIvZ251L3BhY2thZ2VzL2F1ZGlvLnNjbQpAQCAtNDc3OCw2 ICs0Nzc4LDM3IEBAIGVkaXRlZCwgY29udmVydGVkLCBjb21wcmVzc2VkIGFuZCBzYXZlZC4iKQog ICAgICAgICxAKHBhY2thZ2UtaW5wdXRzIHp0b29sa2l0KSkpCiAgICAgKHN5bm9wc2lzICJaVG9v bGtpdCB3aXRoIFNWRyBzdXBwb3J0IikpKQogCisoZGVmaW5lLXB1YmxpYyBsc3AtZHNwLWxpYgor ICAocGFja2FnZQorICAgIChuYW1lICJsc3AtZHNwLWxpYiIpCisgICAgKHZlcnNpb24gIjAuNS44 IikKKyAgICAoc291cmNlCisgICAgICAob3JpZ2luCisgICAgICAgIChtZXRob2QgdXJsLWZldGNo KQorICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vc2Fka280 dS9sc3AtZHNwLWxpYi8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgInJlbGVhc2VzL2Rv d25sb2FkL2xzcC1kc3AtbGliLSIgdmVyc2lvbgorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICIvbHNwLWRzcC1saWItIiB2ZXJzaW9uICItc3JjLnRhci5neiIpKQorICAgICAgICAoc2hhMjU2 CisgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgIjA3dzNkMmkwejB4bXZpMW5nY2dzN2xjNWEw ZGE4anZmN3J2NGRuamswMW1kNDNiN2ZraDEiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1 aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzp0ZXN0cz8gI2YgOyBubyB0ZXN0 cworICAgICAgICM6bWFrZS1mbGFncworICAgICAgIChsaXN0IChzdHJpbmctYXBwZW5kICJDQz0i ICwoY2MtZm9yLXRhcmdldCkpKQorICAgICAgICM6cGhhc2VzCisgICAgICAgKG1vZGlmeS1waGFz ZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgKHJlcGxhY2UgJ2NvbmZpZ3VyZQorICAgICAg ICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAg ICAgICAgKGludm9rZSAibWFrZSIgImNvbmZpZyIKKyAgICAgICAgICAgICAgICAgICAgIChzdHJp bmctYXBwZW5kICJQUkVGSVg9IiAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKSkpKSkpKQorICAg IChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9zYWRrbzR1L2xzcC1kc3AtbGliIikKKyAg ICAoc3lub3BzaXMgIkRpZ2l0YWwgc2lnbmFsIHByb2Nlc3NpbmcgbGlicmFyeSIpCisgICAgKGRl c2NyaXB0aW9uICJUaGUgTFNQIERTUCBsaWJyYXJ5IHByb3ZpZGVzIGEgc2V0IG9mIGZ1bmN0aW9u cyB0aGF0IHBlcmZvcm0KK1NJTUQtb3B0aW1pemVkIGNvbXB1dGluZyBvbiBzZXZlcmFsIGhhcmR3 YXJlIGFyY2hpdGVjdHVyZXMuICBBbGwgZnVuY3Rpb25zCitjdXJyZW50bHkgb3BlcmF0ZSBvbiBJ RUVFLTc1NCBzaW5nbGUtcHJlY2lzaW9uIGZsb2F0aW5nLXBvaW50IG51bWJlcnMuIikKKyAgICAo bGljZW5zZSBsaWNlbnNlOmxncGwzKykpKQorCiAoZGVmaW5lLXB1YmxpYyBjb2RlYzIKICAgKHBh Y2thZ2UKICAgICAobmFtZSAiY29kZWMyIikKLS0gCjIuMjcuMAoK --=-MxOvHee9eIurc0QrkZwS-- --=-8oJgATUbhP/joBMg1oOA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl9fe4wACgkQAi6uQjE9 cPP6HAf/ZmSqLmk7idKwAKdkHRuweEzUEqX2S29UU4l4gBGrzpaibyCymkGfdxic yTbIu6ZyUGVS+d1pu9G79e/t4MG5cojnGkycobQK9n550Za8zG3qQ+oqo5Hv/PdS GM2RvYqGFfJuiySw8wVMaBIH+ousToftr8R0dF6V5JrvAGRfm22yfbYMHG0oq+Y+ G8VVRRzSqkiGx1Pt3ponrMQDfNKI+E29zAIZYAikfOs2qw+jc4Svpf5+XxUKVUvD GGMapvXOkwYBhQU21NPTZQvK+X5XAEUFpeaYV0ycI/p6QgxTf+efFzSXDkbK8FVU 8vZPH7dH24ukRoKy8WDfmBTH4rUI1w== =WKL2 -----END PGP SIGNATURE----- --=-8oJgATUbhP/joBMg1oOA--