From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kNqULZnCp2B/YAAAgWs5BA (envelope-from ) for ; Fri, 21 May 2021 16:24:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KJdEKZnCp2BuMAAA1q6Kng (envelope-from ) for ; Fri, 21 May 2021 14:24:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EFF431519C for ; Fri, 21 May 2021 16:24:24 +0200 (CEST) Received: from localhost ([::1]:44754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk64e-0005pn-18 for larch@yhetil.org; Fri, 21 May 2021 10:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk64H-0005nL-Vu for guix-patches@gnu.org; Fri, 21 May 2021 10:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lk64H-0003yu-Nm for guix-patches@gnu.org; Fri, 21 May 2021 10:24:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lk64H-0005V4-Kr for guix-patches@gnu.org; Fri, 21 May 2021 10:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simulacra. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 14:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48501 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48501@debbugs.gnu.org Cc: Tobias Geerinckx-Rice X-Debbugs-Original-To: 48501@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162160702421116 (code B ref -1); Fri, 21 May 2021 14:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 May 2021 14:23:44 +0000 Received: from localhost ([127.0.0.1]:37340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk640-0005UW-9J for submit@debbugs.gnu.org; Fri, 21 May 2021 10:23:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:59668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk63x-0005UN-Va for submit@debbugs.gnu.org; Fri, 21 May 2021 10:23:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk63w-0005HO-PY for guix-patches@gnu.org; Fri, 21 May 2021 10:23:41 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:58126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk63s-0003qj-8G for guix-patches@gnu.org; Fri, 21 May 2021 10:23:39 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id EC58AB46; Fri, 21 May 2021 16:23:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1621607010; x=1623421411; bh=DWKbEkARUJgUojNzHckSzCJ5YWiuyeTrwjq Nq/sISq8=; b=usWFdrWtjyiUSRizmUwHjEyG/e3AbswZz43jD2MKNSa8pCWmQie SQXkl/rFGpQ63aMCOvaTTJVleZze5DjV6Lbw9FbsmWNuW9LIcrUH5r5Wu9NV3aIV izanbVCkL2/GBKLdPcKsUD4w3WFMMTHn8otQlvknwoPIPIaAYgRYpRBMV408d9Li AY/5WHDGIpupf0dC3qLCMgfadc0KqRP/uPvr8CpkfpGIbhFlkTdFZz6d9tXyr/MB aTch/KTsx+V1AT7T1Z81dhEy7eLc+H36la7MeDumTZvlpbAo57/Pk+4k9xA2wkqj 681zzZs+g5J+AgBoWKxw6a/GXr5AKOoUkJh6ryjl3SHnf7eSzlRMoSE6uar3o+/w eg4dOWZHiIn6mOxr/4Yl5D5Mvj2Z1iYauD4m9yXZ9/Hc/9gKtRLW+5pwB+xp6LSG mbiT6IWU9uaLSSO2/mB55z06Buf6Qvw2pIrQUNV5jA4dFjimpk2YwopX7zVKlogP PhnN2dkas9mZi+b2JzV1i+gEd8pFj/fV3+flEoXOim/6/Wv11TLYbLf3FXw1Sb+w anCraNrgoX8dRHixaKABt3U3NHqbrlAUMPrfebUZnYlTsU42EZlWS7SAIyu2LOAB m1z3bAzfq5wcpJxRgLeruzZ1F9GYwlK0tf9Mkiti0LgGkyRejTyCGH8c= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DM5eGN0PXBqI; Fri, 21 May 2021 16:23:30 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 6CFCA806; Fri, 21 May 2021 16:23:30 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx002.mykolab.com (Postfix) with ESMTPS id DB2B74589; Fri, 21 May 2021 16:23:26 +0200 (CEST) Date: Fri, 21 May 2021 11:23:20 -0300 Message-ID: <3094026.NOWVCxSc26@popigai> In-Reply-To: <20210518163405.3618-1-me@tobias.gr> References: <20210518163405.3618-1-me@tobias.gr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=95.128.36.41; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621607065; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DWKbEkARUJgUojNzHckSzCJ5YWiuyeTrwjqNq/sISq8=; b=d0jzu9Mw7ne1vZNoclA4aDapm/FNYwPbBOYl/4Co1fIAQgdWURrFDJkFv5ZVZMhLDVaXwq bV5Rfv9q+0WRPAdedtSjr+T/OgTmDGG7JzsFz/j6jmLl/8b+EHQ7COOQRayYfqIHcIyWIL 1/BIo6xruRCk2Cy1+GmNB4cbaltWmBeNUnABNiYHHe1FLWfDpzCOr0eTWaDzkT6kGofoPZ BMogOd5qGGQx6s8HWQ6UzdTO6i7ByfKIb13ZhCudW0vOIqo12L5b0eEYRF5cXPytarku4O YZQc7Sw2JFbRm9RUnTuei/CLUJcNWBc8iE29tRFKO1CxTqLLuFtKE+9ZQgRBNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621607065; a=rsa-sha256; cv=none; b=uWR6WRsd554rv7UMjfQ+qU7zu3hOp2q/up8jUYkuasmZ4hzA6UKCHCkX6buzIZ6s9XQoHx 5zP5Dw/bScU+71l8SFJVJcy3iEIwV3NIQJsJEfWJpPJwkNPCoA5yAMNrv3TaGxLLa3/RqY kRt3b9fe/SvCnfm/fcfDnqsJAEawISSzK3uqO77JAYk8ZAF20ypeuYpIFupPfyICKfA/xl xvSxw4O9XK4s5L3Lad5gqTtlcIKfdKe+zpu+QjXYVyukHrIbroP4y14KHDP+/S1fOH86Dh vJhGK0Cb0FPuhZW9oO4jsVFm/OBW//K1eEfB3Gfdm/NokEwMLicktxwfxGVEUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=usWFdrWt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=usWFdrWt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EFF431519C X-Spam-Score: -2.44 X-Migadu-Scanner: scn1.migadu.com X-TUID: XUCH/ezNl3Dx Hello, [ I'm just an onlooker on the Guix mailing lists, so don't assign much=20 weight to this comment. ] Em ter=C3=A7a-feira, 18 de maio de 2021, =C3=A0s 13:34:05 -03, Tobias Geeri= nckx-Rice=20 via Guix-patches via escreveu: > The correct =E2=80=98 and =E2=80=99 are not considered word boundaries by= some(?) > terminal emulators like Alacritty, making double-click selection > tedious. Avoid them in untranslated strings like it's 1992. >=20 > * nix/libstore/build.cc (UserLock::acquire) > (DerivationGoal::haveDerivation, DerivationGoal::closureRepaired) > (DerivationGoal::startBuilder, DerivationGoal::runChild) > (DerivationGoal::registerOutputs): Replace =E2=80=98=E2=80=99 with `' in = output. > * nix/libstore/local-store.cc (canonicalisePathMetaData_) > (LocalStore::queryValidPathId): Likewise. > * nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Likewise. > * nix/libutil/util.cc (readLink): Likewise. > --- > nix/libstore/build.cc | 24 ++++++++++++------------ > nix/libstore/local-store.cc | 4 ++-- > nix/libstore/optimise-store.cc | 4 ++-- > nix/libutil/util.cc | 2 +- > 4 files changed, 17 insertions(+), 17 deletions(-) >=20 > diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc > index 5697ae5a43..d6f9a15a46 100644 > --- a/nix/libstore/build.cc > +++ b/nix/libstore/build.cc > @@ -525,7 +525,7 @@ void UserLock::acquire() > int err =3D getgrouplist(pw->pw_name, pw->pw_gid, > supplementaryGIDs.data(), &ngroups); > if (err =3D=3D -1) > - throw Error(format("failed to get list of supplementary > groups for =E2=80=98%1%=E2=80=99") % pw->pw_name); + throw > Error(format("failed to get list of supplementary groups for `%1%=E2=80= =99") % > pw->pw_name); IMHO the backtick looks ugly when it tries to mimick the opening quote=20 character. I think the text looks better if both quote characters are=20 replaced with the straight quote character, e.g. '%1'. =2D-=20 Regards from the peanut gallery, Thiago