From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IJh7ITczxmX6ZAAA62LTzQ:P1 (envelope-from ) for ; Fri, 09 Feb 2024 15:14:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id IJh7ITczxmX6ZAAA62LTzQ (envelope-from ) for ; Fri, 09 Feb 2024 15:14:15 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=soverin1 header.b=eqkb1qNA; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707488055; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=J1Y1KanWFvCz/p+HXzRluN05x9vbe91mrcMJsDXkuNI=; b=pSMpitecF0Ou0ngnBS7vKp+9/iJGy836oaRCSkmZ9fimuuOIKWSqusoKaJS6NT2yHs7enS Ct2w/+gfT1fb9FtRxzvjGLqT3XMwrv8eW1xoGIVJZDsyDXahnZ4l1jBNd9pHsh7XhP5sZU Y+aEjuA9QGa0KcO4nVeft6saDswj7nr/NhTkQRu2F0Iy5xUZqvGJk9pQ/J/nEoTMONMmP6 O1QbWBbH+4qFWii4qUp2udIFOEz1YhZlAJSDiUB1BEuteyEOleWOhgUFOPqbP6OVZwJOrj 2x15tPK+M9dTqaF5fTjEvO3H3UcSHFd8MvLus4E3tJ8IgwiAbdX995AVJOf7eg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=soverin1 header.b=eqkb1qNA; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707488055; a=rsa-sha256; cv=none; b=skqcX9JnvZKsb9ocrR4nJNZb6wCiv/58YLii+dCCZ3hP49Wum9g2B35PJR2GT1ELVY4sDy BqZfydB93ufBezhG4f/wCQh1YCNjXCi9YhBCnfV94qliAgxK4ubgBn6IUsqecjtvLzQ3Rr ms2eX3hAA+9xOMbMK5je5mggXl09yh+/xOYH7iuQ64BzcImbaxCEp/Ipmxxtwx//Y3os/W 9lWm8ihocika13e0x3LZleo/Ds7u045rkfDHoO3xpeqVXvmgdc1jXiPgyWggTvdZhmrMPJ o9BcFxoK197gfvpcfLoRwp2GLt0ZdVZDEKBJq2IfUMFKPIUCORmV2TZNISGajw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4BC1C58424 for ; Fri, 9 Feb 2024 15:14:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYRdX-0001SY-JH; Fri, 09 Feb 2024 09:13:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYRdU-0001SG-Rf for guix-patches@gnu.org; Fri, 09 Feb 2024 09:13:49 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYRdU-0006Yb-Je for guix-patches@gnu.org; Fri, 09 Feb 2024 09:13:48 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYRdi-0006uU-BE for guix-patches@gnu.org; Fri, 09 Feb 2024 09:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68742] [PATCH v3] gnu: river: Add river.desktop file. Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Feb 2024 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68742 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Erik Eduardo , 68742@debbugs.gnu.org Cc: Erik Eduardo Received: via spool by 68742-submit@debbugs.gnu.org id=B68742.170748801026481 (code B ref 68742); Fri, 09 Feb 2024 14:14:02 +0000 Received: (at 68742) by debbugs.gnu.org; 9 Feb 2024 14:13:30 +0000 Received: from localhost ([127.0.0.1]:38943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYRdB-0006t3-Mi for submit@debbugs.gnu.org; Fri, 09 Feb 2024 09:13:30 -0500 Received: from dane.soverin.net ([185.233.34.148]:42969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYRd8-0006sa-Eq for 68742@debbugs.gnu.org; Fri, 09 Feb 2024 09:13:28 -0500 Received: from smtp.soverin.net (unknown [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4TWbRN6rk4z2xPn; Fri, 9 Feb 2024 14:13:04 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4TWbRN23brz3V; Fri, 9 Feb 2024 14:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=soverin1; t=1707487984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J1Y1KanWFvCz/p+HXzRluN05x9vbe91mrcMJsDXkuNI=; b=eqkb1qNAL4tTugOyEfGb5FdIsNQqmbylZQ0eJqLmGj6WuuimX2vFRZUocIJvA1AsugBifD uUibL2B5j+SUEHsIItOnI1QLRNWRvKiCIwlJmCVrRvOpzzFb2DyEgbCvs2fpNXHqbb2l8r U5FY6RLNH6YKl4LRqHtcOJ+tRnMbIRKjerjiJ201XJr4Pp3a+00WWmmKVdhKONc323cgoM IKZk5/3HlDrj2qPmnTm0nn8mpgivmea9TdOH6bLQW/abnbPX4FCjfTbdQwxNqRb6G4891W roRqIM9F4lMBsEAYOUhjBYDW2Llg1h99LaoHbNkLuWVGNEB8rrB0145iHnMhtg== Message-ID: <2f0279dd-725d-22fe-09c6-034c6f1f96b5@elenq.tech> Date: Fri, 9 Feb 2024 15:13:03 +0100 MIME-Version: 1.0 Content-Language: en-US, es-ES, eu References: <53bd1ea6e9a06df4f89c8caf394f5cfac9fc1a75.1707413520.git.erikeah@protonmail.com> From: Ekaitz Zarraga In-Reply-To: <53bd1ea6e9a06df4f89c8caf394f5cfac9fc1a75.1707413520.git.erikeah@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.77 X-Migadu-Queue-Id: 4BC1C58424 X-Spam-Score: -2.77 X-Migadu-Scanner: mx11.migadu.com X-TUID: pLgxMjz65M+5 On 2024-02-08 18:32, Erik Eduardo wrote: > * gnu/packages/zig-xyz.scm (river)[arguments]: Add > 'install-wayland-session phase after 'install phase to install the > river.desktop file inside share/wayland-sessions directory > > Change-Id: I19fbcfa09a6b06ed602ec4be1b06cc6e2cd2a9a1 > --- > gnu/packages/zig-xyz.scm | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm > index 200b5c9940..8343555660 100644 > --- a/gnu/packages/zig-xyz.scm > +++ b/gnu/packages/zig-xyz.scm > @@ -52,7 +52,16 @@ (define-public river > (build-system zig-build-system) > (arguments > (list > - #:zig-build-flags #~(list "-Dxwayland") ;experimental xwayland support > + #:phases #~(modify-phases %standard-phases > + (add-after 'install 'install-wayland-session > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (wayland-sessions (string-append out > + "/share/wayland-sessions"))) > + (mkdir-p wayland-sessions) > + (install-file "contrib/river.desktop" > + wayland-sessions))))) > + #:zig-build-flags #~(list "-Dxwayland") ;experimental xwayland support > #:zig-release-type "safe")) > (native-inputs (list libevdev > libxkbcommon > > base-commit: cce7a6d2d2b18f51d1fcab67b02a38c11d6f4f2d Oh Erik! But we are missing something very important here! Add your copyright header to the top of the file, the rest of us feel alone there in the top. We need some company. You can also use `#$output` instead of `(assoc-ref outputs "out")`, which might be cool to use, as you are already using a gexp in the phases for example. Please send a new version and I'll mark it as reviewed (now I learned how to do it :) ) Best, Ekaitz