unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Herman Rimm via Guix-patches via <guix-patches@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 75283@debbugs.gnu.org
Subject: [bug#75283] [PATCH rust-team] gnu: rust-xremap: Use output for each feature.
Date: Mon, 6 Jan 2025 20:42:11 +0100	[thread overview]
Message-ID: <2eezlodw3yan7gpi4cropxwhxi3weedvklvjviiboorgfmmaxk@fyrtzeepv34e> (raw)
In-Reply-To: <Z3pJTnEc7Yg0544c@3900XT>

Hello,

On Sun, Jan 05, 2025 at 10:56:46AM +0200, Efraim Flashner wrote:
> Do we actually need a separate output/package for each desktop type? Or
> can we just add in all the features and provide just one package for all
> of them?

In .../xremap/src/client/mod.rs, each feature (e.g. wlroots) is used
like:

#[cfg(feature = "wlroots")]
pub fn build_client() -> WMClient { ... }

Enabling multiple features would define multiple build_client in the
module, which would not compile I think.

Cheers,
Herman




      reply	other threads:[~2025-01-06 19:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 13:06 [bug#75283] [PATCH rust-team] gnu: rust-xremap: Use output for each feature Herman Rimm via Guix-patches via
2025-01-05  8:56 ` Efraim Flashner
2025-01-06 19:42   ` Herman Rimm via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eezlodw3yan7gpi4cropxwhxi3weedvklvjviiboorgfmmaxk@fyrtzeepv34e \
    --to=guix-patches@gnu.org \
    --cc=75283@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=herman@rimm.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).