unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Bruno Victal <mirai@makinata.eu>, 66426@debbugs.gnu.org
Subject: [bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules.
Date: Mon, 09 Oct 2023 21:45:59 +0200	[thread overview]
Message-ID: <2e6bfb0e40fddb7f0df045aa3b234c1cf45494cf.camel@gmail.com> (raw)
In-Reply-To: <87y1gb8u73.fsf@gmail.com>

Am Montag, dem 09.10.2023 um 15:36 -0400 schrieb Maxim Cournoyer:
> Hello,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > Am Montag, dem 09.10.2023 um 12:33 -0400 schrieb Maxim Cournoyer:
> > > This series introduces default variable bindings for the default
> > > gnu-build-system IMPORTED-MODULES and MODULES values.  The lack
> > > of a %default-gnu-modules caused enough confusion, as made
> > > apparent by this series.
> > If we're going to do this anyway, let's go big: add modules and
> > imported-modules to the fields of build-system and allow users to
> > use that.
> 
> I don't understand; what would that look like in practice?  Isn't
> this already how it works?  Build systems have #:modules and
> #:imported-modules arguments, which are provided via the 'arguments'
> field of a package.
Well, no.   The build-system record currently contains a name,
description and lowering procedure, but no "immediately helpful" data
for package writers.

> > Perhaps also add short-hands so that (default-modules gnu)
> > expands to (build-system-modules gnu-build-system) and likewise for
> > imported-modules.
> 
> Ah!  I understand the idea now.  It feels a bit strange to me to
> attach such metadata to the build-system record itself though.  At
> any rate, we could discuss this separately and do it in a future
> iteration, perhaps?
> The series posted here already has value in itself, and if we ever go
> to attach this information to build system objects instead of plain
> variables, we could use sed to adjust the code base.
> 
> What do yo think?
Hmm, at the very least I'd like to bikeshed the variable names, hence
my suggestion to encode it into the build system itself, which would
allow any name locally.  %default-anything reads weird to me, plus it's
a mouthful for imported modules.
WDYT about %gnu-build-modules and %gnu-build-system-modules, where
%gnu-build-system-modules keeps its current intent for being imported?
Alternatively we could also rename it to %gnu-build-imported-modules
with a deprecated alias.

Cheers





  reply	other threads:[~2023-10-09 19:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1696868939.git.maxim.cournoyer@gmail.com>
2023-10-09 18:18 ` [bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules Liliana Marie Prikler
2023-10-09 19:36   ` Maxim Cournoyer
2023-10-09 19:45     ` Liliana Marie Prikler [this message]
2023-10-10  1:31       ` Maxim Cournoyer
2023-10-10  4:14         ` Liliana Marie Prikler
2023-10-10 14:36           ` Maxim Cournoyer
2023-10-16 15:28             ` Maxim Cournoyer
2023-10-19  4:04               ` bug#66426: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e6bfb0e40fddb7f0df045aa3b234c1cf45494cf.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=66426@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=mirai@makinata.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).