From: Tim Gesthuizen <tim.gesthuizen@yahoo.de>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 33598@debbugs.gnu.org
Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename
Date: Wed, 19 Dec 2018 18:47:00 +0100 [thread overview]
Message-ID: <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> (raw)
In-Reply-To: <87imzwe2d3.fsf@ambrevar.xyz>
[-- Attachment #1.1: Type: text/plain, Size: 2124 bytes --]
Hi,
I was wondering why I sended patches that do not improve
anything. After some more investigation I found out again what the
patches improve:
The source is repacked by guix and the patches applied before the source
is stored in the store. With the current guix:
┌────
│ ~/src/guix/build$ tar -tf `guix build -S emacs-clang-format`
│ cfe-6.0.1.src/
│ cfe-6.0.1.src/.arcconfig
│ cfe-6.0.1.src/.clang-format
│ cfe-6.0.1.src/.clang-tidy
│ cfe-6.0.1.src/.gitignore
│ cfe-6.0.1.src/CMakeLists.txt
│ cfe-6.0.1.src/CODE_OWNERS.TXT
│ cfe-6.0.1.src/INPUTS/
│ cfe-6.0.1.src/INPUTS/Cocoa_h.m
│ cfe-6.0.1.src/INPUTS/all-std-headers.cpp
│ cfe-6.0.1.src/INPUTS/c99-intconst-1.c
│ cfe-6.0.1.src/INPUTS/carbon_h.c
│ cfe-6.0.1.src/INPUTS/cfg-big-switch.c
│ cfe-6.0.1.src/INPUTS/cfg-long-chain1.c
│ cfe-6.0.1.src/INPUTS/cfg-long-chain2.c
│ cfe-6.0.1.src/INPUTS/cfg-long-chain3.c
│ cfe-6.0.1.src/INPUTS/cfg-nested-switches.c
│ cfe-6.0.1.src/INPUTS/cfg-nested-var-scopes.cpp
│ cfe-6.0.1.src/INPUTS/iostream.cc
│ cfe-6.0.1.src/INPUTS/macro_pounder_fn.c
│ cfe-6.0.1.src/INPUTS/macro_pounder_obj.c
│ cfe-6.0.1.src/INPUTS/stpcpy-test.c
│ cfe-6.0.1.src/INSTALL.txt
│ cfe-6.0.1.src/LICENSE.TXT
│ cfe-6.0.1.src/ModuleInfo.txt
│ cfe-6.0.1.src/NOTES.txt
│ ... < the rest of clangs sources >
└────
With the patches applied:
┌────
│ ~/src/guix/build$ tar -tf `guix build -S emacs-clang-format`
│ ... < repacking and building the source>
│ successfully built
/gnu/store/yds0n90idgaa65ladnpbcdjkqgs8l61d-emacs-clang-format-6.0.1.tar.xz.drv
│ cfe-6.0.1.src/
│ cfe-6.0.1.src/clang-format.el
└────
So it does save disk space. I also think that these sources can be
substituted (This may still not be the case though). The term source
derivation is mentioned in the description of guix builds `-S` option.
I would argue that I implement the file deletion in the source snippet
in package-elisp-from-package. I hope this makes clear what the purpose
of the first two patches is.
Tim.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-12-19 17:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 13:47 [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Tim Gesthuizen
2018-12-13 22:49 ` Ludovic Courtès
2018-12-14 9:23 ` Pierre Neidhardt
2018-12-14 10:06 ` Tim Gesthuizen
2018-12-14 10:31 ` Pierre Neidhardt
2018-12-14 11:00 ` Tim Gesthuizen
2018-12-14 12:09 ` Pierre Neidhardt
2018-12-14 12:12 ` Tim Gesthuizen
2018-12-19 17:47 ` Tim Gesthuizen [this message]
2018-12-19 17:50 ` Pierre Neidhardt
2019-01-04 22:00 ` Tim Gesthuizen
2019-01-06 19:00 ` Pierre Neidhardt
2019-01-06 21:29 ` Tim Gesthuizen
2019-01-07 13:47 ` Pierre Neidhardt
2019-01-07 14:00 ` Pierre Neidhardt
2019-01-07 14:08 ` Pierre Neidhardt
2019-01-07 22:10 ` Ludovic Courtès
2019-01-07 22:14 ` Pierre Neidhardt
2019-01-08 8:39 ` Ludovic Courtès
2019-01-08 8:48 ` Pierre Neidhardt
2019-01-08 9:53 ` Ludovic Courtès
2019-01-08 10:05 ` Pierre Neidhardt
2019-01-08 15:35 ` Tim Gesthuizen
2019-01-10 18:28 ` Tim Gesthuizen
2019-01-10 18:40 ` Pierre Neidhardt
2019-01-10 18:47 ` Tim Gesthuizen
2019-01-10 18:50 ` Pierre Neidhardt
2019-01-07 15:37 ` Tim Gesthuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de \
--to=tim.gesthuizen@yahoo.de \
--cc=33598@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).