From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:58354) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzbpj-0001Ku-Cx for guix-patches@gnu.org; Mon, 19 Aug 2019 03:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzbpi-0000BL-9q for guix-patches@gnu.org; Mon, 19 Aug 2019 03:12:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzbpi-0000BD-3I for guix-patches@gnu.org; Mon, 19 Aug 2019 03:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzbph-0004Fg-TU for guix-patches@gnu.org; Mon, 19 Aug 2019 03:12:01 -0400 Subject: bug#37048: [PATCH core-updates] gnu: qemu: Update to 4.1.0. Resent-To: guix-patches@gnu.org Resent-Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_aa6da2367f457afcbe51425acdfa46bd" Date: Mon, 19 Aug 2019 09:11:20 +0200 From: Rutger Helling In-Reply-To: <20190818234722.GA25156@jasmine.lan> References: <4be5db9d4f44a8463b23950676fab56f@mykolab.com> <20190818234722.GA25156@jasmine.lan> Message-ID: <2d82b1f828231e2d0bf2e05437666595@mykolab.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 37048-done@debbugs.gnu.org --=_aa6da2367f457afcbe51425acdfa46bd Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Thanks for the review! I changed the phase name to prevent-network-configuration and pushed it to core-updates. On 2019-08-19 01:47, Leo Famulari wrote: > On Fri, Aug 16, 2019 at 06:27:42AM +0000, Rutger Helling wrote: > >> Hey Guix, >> >> here's a patch to update QEMU to 4.1.0. >> I'm sending it in for core-updates, since it only works there. It errors >> out with "fatal error: gnu/stubs-32.h: No such file or directory" on >> master (x86_64). Some change in GCC on core-updates seems to have solved >> this problem. > > Thanks! > >> From 170d67512d8f3412ee7f1b19b522fc2cb7cd6e29 Mon Sep 17 00:00:00 2001 >> From: Rutger Helling >> Date: Thu, 15 Aug 2019 22:01:49 +0200 >> Subject: [PATCH] gnu: qemu: Update to 4.1.0. >> >> * gnu/local.mk: Remove qemu-CVE-2018-16872.patch and qemu-CVE-2019-6778.patch. >> * gnu/packages/patches/qemu-CVE-2018-16872.patch: Remove file. >> * gnu/packages/patches/qemu-CVE-2019-6778.patch: Remove file. >> * gnu/packages/virtualization.scm (qemu): Update to 4.1.0. >> [source]: Remove obsolete patches. >> [arguments]: Add phases 'disable-line and 'disable-unusable-tests. > > Can the phase name 'disable-line' be made more explicit? I don't get > what it means in this context. > > Otherwise LGTM! --=_aa6da2367f457afcbe51425acdfa46bd Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Thanks for the review! I changed the phase name to prevent-network-confi= guration and pushed it to core-updates.

On 2019-08-19 01:47, Leo Famulari wrote:

= On Fri, Aug 16, 2019 at 06:27:42AM +0000, Rutger Helling wrote:
Hey Guix,

here's a patch to update QEMU to = 4.1.0.
I'm sending it in for core-updates, since it only works there= =2E It errors
out with "fatal error: gnu/stubs-32.h: No such file or d= irectory" on
master (x86_64). Some change in GCC on core-updates seems= to have solved
this problem.

Thanks!

From 170d67512d8f3412ee7f1b19b522fc2cb7cd6e29 Mon Sep = 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Thu,= 15 Aug 2019 22:01:49 +0200
Subject: [PATCH] gnu: qemu: Update to 4.1= =2E0.

* gnu/local.mk: Remove qemu-CVE-2018-16872.patch and qemu-= CVE-2019-6778.patch.
* gnu/packages/patches/qemu-CVE-2018-16872.patch:= Remove file.
* gnu/packages/patches/qemu-CVE-2019-6778.patch: Remove = file.
* gnu/packages/virtualization.scm (qemu): Update to 4.1.0.
= [source]: Remove obsolete patches.
[arguments]: Add phases 'disable-li= ne and 'disable-unusable-tests.

Can the phase name 'disable-line' be made more explicit? I don't get<= br />what it means in this context.

Otherwise LGTM!


--=_aa6da2367f457afcbe51425acdfa46bd--