From: Rutger Helling <rhelling@mykolab.com>
To: Leo Famulari <leo@famulari.name>
Cc: 37048-done@debbugs.gnu.org
Subject: bug#37048: [PATCH core-updates] gnu: qemu: Update to 4.1.0.
Date: Mon, 19 Aug 2019 09:11:20 +0200 [thread overview]
Message-ID: <2d82b1f828231e2d0bf2e05437666595@mykolab.com> (raw)
In-Reply-To: <20190818234722.GA25156@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
Thanks for the review! I changed the phase name to
prevent-network-configuration and pushed it to core-updates.
On 2019-08-19 01:47, Leo Famulari wrote:
> On Fri, Aug 16, 2019 at 06:27:42AM +0000, Rutger Helling wrote:
>
>> Hey Guix,
>>
>> here's a patch to update QEMU to 4.1.0.
>> I'm sending it in for core-updates, since it only works there. It errors
>> out with "fatal error: gnu/stubs-32.h: No such file or directory" on
>> master (x86_64). Some change in GCC on core-updates seems to have solved
>> this problem.
>
> Thanks!
>
>> From 170d67512d8f3412ee7f1b19b522fc2cb7cd6e29 Mon Sep 17 00:00:00 2001
>> From: Rutger Helling <rhelling@mykolab.com>
>> Date: Thu, 15 Aug 2019 22:01:49 +0200
>> Subject: [PATCH] gnu: qemu: Update to 4.1.0.
>>
>> * gnu/local.mk: Remove qemu-CVE-2018-16872.patch and qemu-CVE-2019-6778.patch.
>> * gnu/packages/patches/qemu-CVE-2018-16872.patch: Remove file.
>> * gnu/packages/patches/qemu-CVE-2019-6778.patch: Remove file.
>> * gnu/packages/virtualization.scm (qemu): Update to 4.1.0.
>> [source]: Remove obsolete patches.
>> [arguments]: Add phases 'disable-line and 'disable-unusable-tests.
>
> Can the phase name 'disable-line' be made more explicit? I don't get
> what it means in this context.
>
> Otherwise LGTM!
[-- Attachment #2: Type: text/html, Size: 2060 bytes --]
prev parent reply other threads:[~2019-08-19 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:27 [bug#37048] [PATCH core-updates] gnu: qemu: Update to 4.1.0 Rutger Helling
2019-08-18 23:47 ` Leo Famulari
2019-08-19 7:11 ` Rutger Helling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d82b1f828231e2d0bf2e05437666595@mykolab.com \
--to=rhelling@mykolab.com \
--cc=37048-done@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).