From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dVzCY-0001Jc-B3
	for guix-patches@gnu.org; Fri, 14 Jul 2017 07:56:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dVzCU-0002iF-CK
	for guix-patches@gnu.org; Fri, 14 Jul 2017 07:56:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35139)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dVzCU-0002iB-8T
	for guix-patches@gnu.org; Fri, 14 Jul 2017 07:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dVzCT-0006UY-RD
	for guix-patches@gnu.org; Fri, 14 Jul 2017 07:56:01 -0400
Subject: [bug#27673] [PATCH] gnu: Add emacs-org-pomodoro.
Resent-Message-ID: <handler.27673.B27673.150003334924933@debbugs.gnu.org>
Message-Id: <2beb7d1c.AEQANFFEJwcAAAAAAAAAAAPVUpsAAAACwQwAAAAAAAW9WABZaLFC@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Fri, 14 Jul 2017 17:25:29 +0530
In-reply-to: <20170712204731.14463-1-go.wigust@gmail.com>
References: <20170712204731.14463-1-go.wigust@gmail.com>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 27673@debbugs.gnu.org


Thanks for the patch!

> +(define-public emacs-org-pomodoro
> +  (package
> +    (name "emacs-org-pomodoro")
> +    (version "2.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/lolownia/org-pomodoro/archive/"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1jalsggw3q5kvj353f84x4nl04a5vmq07h75ggppy1627lb31zm4"))=
))
> +    (build-system emacs-build-system)

Could you also package the tests? You'll need something very similar to
what the emacs-which-key package has.

> +    (propagated-inputs
> +     `(("emacs-alert" ,emacs-alert)))
> +    (home-page "https://github.com/lolownia/org-pomodoro")
> +    (synopsis "Pomodoro technique for org-mode")
> +    (description
> +     "@code{emacs-org-pomodoro} adds very basic support for Pomodoro tec=
hnique
> +in Emacs org-mode.")

Could you extend the description a little more, perhaps by paraphrasing
paragraph 3 of README.md...?
=