[bug#38141] [PATCH] gnu: Add carla.

[bug#38141] [PATCH] gnu: Add carla.

[Alexandros Theodotou]

 From 77de9785c18683c68dc22f640afb614ef4e88a6c Mon Sep 17 00:00:00 2001
 From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 23:56:58 +0000
Subject: [PATCH] gnu: Add carla.

* gnu/packages/audio.scm (carla): New variable.
---
  gnu/packages/audio.scm | 57 ++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 57 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..20c093e610 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -23,6 +23,7 @@
  ;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
  ;;; Copyright © 2019 Arun Isaac <arunisaac@systemreboot.net>
  ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
  ;;;
  ;;; This file is part of GNU Guix.
  ;;;
@@ -3773,3 +3774,59 @@ other Gnaural instances, allowing synchronous 
sessions between many users.")
  a sound card, encodes it into Ogg Vorbis and/or mp3, and sends the 
audio
  stream to one or more IceCast and/or ShoutCast servers.")
      (license license:gpl3+)))
+
+(define-public carla
+  (package
+    (name "carla")
+    (version "2.0.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "https://github.com/falkTX/Carla/archive/v"
+               version ".tar.gz"))
+        (file-name (string-append name "-v" version ".tar.gz"))
+        (sha256
+          (base32
+            "0hbcxwi6ln9vrv61vv11f7dn0z8q3wimjqvzh2z9mklcgx0xij6h"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable-and-show-features
+           (lambda _
+             (setenv "CC" "gcc")
+             (invoke "make" "features")))
+         (delete 'configure))))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("ffmpeg" ,ffmpeg)
+       ("fluidsynth" ,fluidsynth)
+       ("file" ,file)
+       ("liblo" ,liblo)
+       ("libsndfile" ,libsndfile)
+       ("gtk+" ,gtk+)
+       ("python-pyliblo" ,python-pyliblo)
+       ("python-pyqt" ,python-pyqt)
+       ("python-rdflib" ,python-rdflib)
+       ;; python-pyqt shows the following error without python-wrapper:
+       ;; Error while finding module specification for 
'PyQt5.uic.pyuic'
+       ;; (ModuleNotFoundError: No module named 'PyQt5')
+       ("python-wrapper" ,python-wrapper)
+       ("libx11" ,libx11)
+       ("qtbase" ,qtbase)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://kxstudio.linuxaudio.org/Applications:Carla")
+    (synopsis "Audio plugin host")
+    (description " Carla is a fully-featured modular audio plugin host, 
with
+support for many audio drivers and plugin formats. It has features like
+transport control, automation of parameters via MIDI CC and remote 
control
+over OSC. Carla currently supports LADSPA (including LRDF), DSSI, LV2, 
VST2,
+and VST3 plugin formats, plus SF2 and SFZ file support. It uses JACK as 
the
+default and preferred audio driver but also supports native drivers 
like ALSA.")
+    (license license:gpl2+)))
-- 
2.24.0

[bug#38141] [PATCH] gnu: Add carla.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]

Updated patch. Note that I can't get it to build the same derivation
twice:
```
output ‘/gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-2.0.0’ of
‘/gnu/store/nlyk7zhcnq0fl57z95qyf78gf4qsbl2r-carla-2.0.0.drv’ differs
from ‘/gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-2.0.0-check’
from previous round
```

[-- Attachment #1.2: 0001-gnu-Add-carla.patch --]
[-- Type: text/x-patch, Size: 3199 bytes --]

From 5dcd5d3f035e6865c68295dcbcdb4d03c5e6c049 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 23:56:58 +0000
Subject: [PATCH] gnu: Add carla.

* gnu/packages/audio.scm (carla): New variable.
---
 gnu/packages/audio.scm | 57 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index bc79225115..3ce3929165 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2019 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3766,3 +3767,59 @@ other Gnaural instances, allowing synchronous sessions between many users.")
 a sound card, encodes it into Ogg Vorbis and/or mp3, and sends the audio
 stream to one or more IceCast and/or ShoutCast servers.")
     (license license:gpl3+)))
+
+(define-public carla
+  (package
+    (name "carla")
+    (version "2.0.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/falkTX/Carla.git")
+            (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0fqgncqlr86n38yy7pa118mswfacmfczj7w9xx6c6k0jav3wk29k"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable-and-show-features
+           (lambda _
+             (setenv "CC" "gcc")
+             (invoke "make" "features")))
+         (delete 'configure))))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("ffmpeg" ,ffmpeg)
+       ("fluidsynth" ,fluidsynth)
+       ("file" ,file)
+       ("liblo" ,liblo)
+       ("libsndfile" ,libsndfile)
+       ("gtk+" ,gtk+)
+       ("python-pyliblo" ,python-pyliblo)
+       ("python-pyqt" ,python-pyqt)
+       ("python-rdflib" ,python-rdflib)
+       ;; python-pyqt shows the following error without python-wrapper:
+       ;; Error while finding module specification for 'PyQt5.uic.pyuic'
+       ;; (ModuleNotFoundError: No module named 'PyQt5')
+       ("python-wrapper" ,python-wrapper)
+       ("libx11" ,libx11)
+       ("qtbase" ,qtbase)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://kx.studio/Applications:Carla")
+    (synopsis "Audio plugin host")
+    (description "Carla is a modular audio plugin host, with features like
+transport control, automation of parameters via MIDI CC and remote control
+over OSC.  Carla currently supports LADSPA (including LRDF), DSSI, LV2, VST2,
+and VST3 plugin formats, plus SF2 and SFZ file support.  It uses JACK as the
+default and preferred audio driver but also supports native drivers like ALSA.")
+    (license license:gpl2+)))
-- 
2.24.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38141] [PATCH] gnu: Add carla.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> Updated patch. Note that I can't get it to build the same derivation
> twice:
> ```
> output ‘/gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-2.0.0’ of
> ‘/gnu/store/nlyk7zhcnq0fl57z95qyf78gf4qsbl2r-carla-2.0.0.drv’ differs
> from ‘/gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-2.0.0-check’
> from previous round
> ```

Can you build with '--keep-failed', and then run:

  diffoscope /gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-2.0.0{,-check}

and send the output?

The updated patch LGTM, but does not apply any more.  Can you rebase it
on top of current 'master'?

TIA!
Marius

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38141] [PATCH] gnu: Add carla.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]

Hi Marius,

> Can you build with '--keep-failed', and then run:
> 
>   diffoscope /gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-
> 2.0.0{,-check}
> 
> and send the output?
> 
> The updated patch LGTM, but does not apply any more.  Can you rebase
> it
> on top of current 'master'?

Attaching the diffoscope output and updated patch. The output from
diffoscope was 8.5MB so I compressed it. Note that the hash has
changed.

[-- Attachment #1.2: 0001-gnu-Add-carla.patch --]
[-- Type: text/x-patch, Size: 2843 bytes --]

From 879230335a8ef5b40d09f493f380ab310c6976b3 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 23:56:58 +0000
Subject: [PATCH] gnu: Add carla.

* gnu/packages/audio.scm (carla): New variable.
---
 gnu/packages/audio.scm | 56 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index d59b4eb87e..453fa7581f 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3811,3 +3811,59 @@ therefore satisfying any requirements they may have to be self contained,
 as is the case with audio plugins.")
     (home-page "https://gitlab.com/geontime/redkite")
     (license license:gpl3+)))
+
+(define-public carla
+  (package
+    (name "carla")
+    (version "2.0.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/falkTX/Carla.git")
+            (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0fqgncqlr86n38yy7pa118mswfacmfczj7w9xx6c6k0jav3wk29k"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable-and-show-features
+           (lambda _
+             (setenv "CC" "gcc")
+             (invoke "make" "features")))
+         (delete 'configure))))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("ffmpeg" ,ffmpeg)
+       ("fluidsynth" ,fluidsynth)
+       ("file" ,file)
+       ("liblo" ,liblo)
+       ("libsndfile" ,libsndfile)
+       ("gtk+" ,gtk+)
+       ("python-pyliblo" ,python-pyliblo)
+       ("python-pyqt" ,python-pyqt)
+       ("python-rdflib" ,python-rdflib)
+       ;; python-pyqt shows the following error without python-wrapper:
+       ;; Error while finding module specification for 'PyQt5.uic.pyuic'
+       ;; (ModuleNotFoundError: No module named 'PyQt5')
+       ("python-wrapper" ,python-wrapper)
+       ("libx11" ,libx11)
+       ("qtbase" ,qtbase)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://kx.studio/Applications:Carla")
+    (synopsis "Audio plugin host")
+    (description "Carla is a modular audio plugin host, with features like
+transport control, automation of parameters via MIDI CC and remote control
+over OSC.  Carla currently supports LADSPA (including LRDF), DSSI, LV2, VST2,
+and VST3 plugin formats, plus SF2 and SFZ file support.  It uses JACK as the
+default and preferred audio driver but also supports native drivers like ALSA.")
+    (license license:gpl2+)))
-- 
2.24.0


[-- Attachment #1.3: diffoscope-output.tar.gz --]
[-- Type: application/x-compressed-tar, Size: 2508602 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#38141: [PATCH] gnu: Add carla.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> Hi Marius,
>
>> Can you build with '--keep-failed', and then run:
>> 
>>   diffoscope /gnu/store/k22jfy6asbwsxbmmajgghcnnrz6dgaqi-carla-
>> 2.0.0{,-check}
>> 
>> and send the output?
>> 
>> The updated patch LGTM, but does not apply any more.  Can you rebase
>> it
>> on top of current 'master'?
>
> Attaching the diffoscope output and updated patch. The output from
> diffoscope was 8.5MB so I compressed it. Note that the hash has
> changed.

Thanks.  So it looks like resources_rc.py is not reproducible.  It is
not really possible to tell why from the diffoscope output though.

It is generated by PyQt, so I opened a separate bug report about it:

https://bugs.gnu.org/38283

[...]

> From 879230335a8ef5b40d09f493f380ab310c6976b3 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 23:56:58 +0000
> Subject: [PATCH] gnu: Add carla.
>
> * gnu/packages/audio.scm (carla): New variable.

Applied (with indentation change), thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]