From: Maxime Devos <maximedevos@telenet.be>
To: kiasoc5@tutanota.com
Cc: 54067@debbugs.gnu.org
Subject: [bug#54067] [PATCH] gnu: Add python-gym.
Date: Sun, 20 Feb 2022 20:12:53 +0100 [thread overview]
Message-ID: <2b303c132c84ede022018837a29147e9d2fb7075.camel@telenet.be> (raw)
In-Reply-To: <MwNSU61--3-2@tutanota.com>
[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]
[Please keep 54067@debbugs.gnu.org in CC, such that other people
can comment]
kiasoc5@tutanota.com schreef op zo 20-02-2022 om 19:50 [+0100]:
Of course updating python-importlib-metadata is the natural option,
> I don't intend to submit broken patches. But I'm not sure whether
> updating python-importlib-metadata will be smooth, if I run guix
> refresh -l python-importlib-metadata, it says `Building the following
> 74 packages would ensure 131 dependent packages are rebuilt`. It's a
> lot of packages to comb through.
What I'd usually do for testing is
$ ./pre-inst-env guix build python-astroquery@0.4.5 vorta@0.8.3 komikku@0.36.1 [...]
and verify that the builds succeeded.
If their test suites are good, this should catch most issues.
Python packages are typically relatively cheap to build I think, so this
shouldn't take overly long.
We'll have to update python-importlib-metadata anyway eventually,
and it's not realistic to test each individual dependent manually.
> Is there any policy on testing packages for breakage when upgrading?
> Apologies, I should have asked this earlier.
There's (guix)Submitting patches:
10. For important changes, check that dependent packages (if
applicable) are not affected by the change; ‘guix refresh
--list-dependent PACKAGE’ will help you do that (*note Invoking
guix refresh::).
[...]
All these branches are tracked by our build farm
(https://ci.guix.gnu.org) and merged into ‘master’ once everything
has been successfully built. This allows us to fix issues before
they hit users, and to reduce the window during which pre-built
binaries are not available.
(so if building the python packages locally takes too long,
perhaps a temporary branch can be set up to let the build farm
take care of building).
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-20 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 21:29 [bug#54067] [PATCH] gnu: Add python-gym kiasoc5--- via Guix-patches via
2022-02-20 10:35 ` Maxime Devos
[not found] ` <MwNSU61--3-2@tutanota.com>
2022-02-20 19:12 ` Maxime Devos [this message]
2022-02-20 10:36 ` Maxime Devos
2024-01-29 21:58 ` bug#54067: " Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b303c132c84ede022018837a29147e9d2fb7075.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54067@debbugs.gnu.org \
--cc=kiasoc5@tutanota.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).